diff mbox series

bfd/elf.c strtab memory leak

Message ID ZH/kzy91Kw/7oe/D@squeak.grove.modra.org
State Accepted
Headers
Series bfd/elf.c strtab memory leak |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Alan Modra June 7, 2023, 2 a.m. UTC 
  * elf.c (_bfd_elf_compute_section_file_positions): Free strtab
	on set_group_contents failure return path.
diff mbox series

Patch

diff --git a/bfd/elf.c b/bfd/elf.c
index 81eb3ef71fa..af2fb04dcbe 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -4254,7 +4254,11 @@  _bfd_elf_compute_section_file_positions (bfd *abfd,
     {
       bfd_map_over_sections (abfd, bfd_elf_set_group_contents, &failed);
       if (failed)
-	return false;
+	{
+	  if (need_symtab)
+	    _bfd_elf_strtab_free (strtab);
+	  return false;
+	}
     }
 
   shstrtab_hdr = &elf_tdata (abfd)->shstrtab_hdr;