PR11601, Solaris assembler compatibility doesn't work

Message ID ZGWS/0oFOMVSyf+m@squeak.grove.modra.org
State Accepted
Headers
Series PR11601, Solaris assembler compatibility doesn't work |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Alan Modra May 18, 2023, 2:52 a.m. UTC
  Well, it doesn't work on x86 or ppc, which both have # starting
comments anywhere on a line.  I think it is therefore only useful on
sparc.

	PR 11601
	* config/obj-elf.c (obj_elf_section_word): Only compile for sparc.
	(obj_elf_section): Only support solaris .section directive on
	sparc.
	* doc/as.texi (Section): Mention that solaris .section
	directive is only supported for sparc.
  

Patch

diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index a4cf12b144a..bf3ef541ab7 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -974,6 +974,7 @@  obj_elf_section_type (char *str, size_t len, bool warn)
   return 0;
 }
 
+#ifdef TC_SPARC
 static bfd_vma
 obj_elf_section_word (char *str, size_t len, int *type)
 {
@@ -1006,6 +1007,7 @@  obj_elf_section_word (char *str, size_t len, int *type)
 
   return 0;
 }
+#endif
 
 /* Get name of section.  */
 const char *
@@ -1388,6 +1390,7 @@  obj_elf_section (int push)
 		input_line_pointer = save;
 	    }
 	}
+#ifdef TC_SPARC
       else
 	{
 	  do
@@ -1413,6 +1416,7 @@  obj_elf_section (int push)
 	  while (*input_line_pointer++ == ',');
 	  --input_line_pointer;
 	}
+#endif
     }
 
  done:
diff --git a/gas/doc/as.texi b/gas/doc/as.texi
index ea40a9ed75e..ea18df24b14 100644
--- a/gas/doc/as.texi
+++ b/gas/doc/as.texi
@@ -6958,7 +6958,7 @@  the section name is not recognized, the default will be for the section to have
 none of the above flags: it will not be allocated in memory, nor writable, nor
 executable.  The section will contain data.
 
-For ELF targets, the assembler supports another type of @code{.section}
+For SPARC ELF targets, the assembler supports another type of @code{.section}
 directive for compatibility with the Solaris assembler:
 
 @smallexample