From patchwork Sun Apr 2 22:23:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 78309 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1942246vqo; Sun, 2 Apr 2023 15:24:18 -0700 (PDT) X-Google-Smtp-Source: AKy350Y8x0FMYezsEUD8Z4g4OrOeDFNoeqY1FYpAzhl09w9t1ZUI+VHvfLDgGCnj8NEz3mLQcHqZ X-Received: by 2002:aa7:d885:0:b0:4fd:2155:74ef with SMTP id u5-20020aa7d885000000b004fd215574efmr33847942edq.19.1680474258354; Sun, 02 Apr 2023 15:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680474258; cv=none; d=google.com; s=arc-20160816; b=T93mGUZHSz5lbEtNZHXZ83tmJ2rHZIr2jzCoYV/i4nt+4yNqDmIu5XpEMjM+7GBeC+ Lw+QgCoZXK/k2VdTJhNJBN8AK8imWFdaktwa40YfnM/CURBOChBnpwNwcEno9mgzcc4j OE/KrGvRxwqzBInwr3tK+b1CRUkoJScKo0w7esgoGhu7BpZ5FOa9AMYF8cN7Svwx9LJP Et390FmXhrBBYm1gW10Ahl2+16AZ7UFe+eGNV3Rgpq/2jhlGKXAQ26TNuEr2DyCvqNKw BPBOJHDgoj6i4a+KpiNDRlcUwyylvtO13+ovQLERW7cqSlyN1Kx4w3IL/vNGVdZ6lKgl 3sWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ucjCE1Hk9bDmlf1WLQz2evfBJWRBh+108p2eKXlZ+P0=; b=wwmeGIXeveHzsft94zEk1071GaQzUb5cxr5cn+1qRFyw/CMivkjSk9xkmzY/V3Xx8A I/b3t21PoWt+HJgmGUo3bquO7NAzqYor12IWyipX9fU7PBnr7NjP4iWIIW5HOq80kFIw pJBuIu2i31l/YOnwJmOX2zUH1inngUhuV9tH2++fGqTkg3FNrBhZKcVa+lI1TL/5kWcu kQSTPCBsyUiMOj8Crc+A/Moqturc9XXXqybqOvBhlPOKV+6e2ZKKBI/w2V2eI46Fn/dZ 9BBF8Fw7jYOaX4xgi+0AImahotzeMvpf+YVQMl6LLsAqme28hv+h9KIg09N4brQDvhQ5 U/FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DzKMLwxy; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w2-20020aa7d282000000b005024aa3e836si7181970edq.394.2023.04.02.15.24.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 15:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DzKMLwxy; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC49E3858C66 for ; Sun, 2 Apr 2023 22:24:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC49E3858C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680474256; bh=ucjCE1Hk9bDmlf1WLQz2evfBJWRBh+108p2eKXlZ+P0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DzKMLwxyD0n/kajF/lbnI3k8LqIA+mH0eMAHzrYZD78jU9PWc5rngasfKcHc4h2ut EAmAYGwP23s/NDxFoen+EqXUkYrvJvmEHzZo7G0rcpVUi272Hr4R4kKp2rgO/aZ6NA KDM5O2QAU7RxrD0w/zTPt4mqXVKnegfAgU3OTUqA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 774D3385800A for ; Sun, 2 Apr 2023 22:23:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 774D3385800A Received: by mail-pj1-x1034.google.com with SMTP id qe8-20020a17090b4f8800b0023f07253a2cso28599018pjb.3 for ; Sun, 02 Apr 2023 15:23:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680474216; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ucjCE1Hk9bDmlf1WLQz2evfBJWRBh+108p2eKXlZ+P0=; b=UK/ddfioFJu38cR7iMimoSDyGvp8RLyQ5YYeQ3ZHGO8VyFE3gJre/L22vIallAl+IZ sg25g/y7KC8aE+eOXVrfB/fHSqAbfvOYVW/rSvAf9519BV0vsFmzLAFSB7bZq2O7swNd sCoAycOzy6Y9NInqXSGgSNoNb70Jr2hzd33rrj/+L/l4CxwMGmG68baYJ7P1wJ4Os2ry lGESuCgW2kX97PzGIGDZ4y6LWWVccSfZxGR5upYZ1Dt+AZYKx8CAjbbK/WuwJjqNpqNQ 5EgyfbEXwWpniKDWGBNTKEXQDJtDvVR+lbFkIy2NCm5o6YtXqUdrHHu8RUlx8zaL0ucl SQsQ== X-Gm-Message-State: AAQBX9dhQyJa4vGQY12xmPSjwaMuuGUq/1vWL+4ak8+O7TCSERD1SjQu 5VpUnRehdPWJV0i8Ku89HVCiJP1FwO0= X-Received: by 2002:a17:90b:3887:b0:23f:58d6:b532 with SMTP id mu7-20020a17090b388700b0023f58d6b532mr37404988pjb.5.1680474215866; Sun, 02 Apr 2023 15:23:35 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4c75:41d5:4aa9:f18e]) by smtp.gmail.com with ESMTPSA id kd14-20020a17090b348e00b00233ebab3770sm4915486pjb.23.2023.04.02.15.23.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 15:23:35 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 48E061142C55; Mon, 3 Apr 2023 07:53:33 +0930 (ACST) Date: Mon, 3 Apr 2023 07:53:33 +0930 To: binutils@sourceware.org Subject: ubsan: aarch64 parse_vector_reg_list Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762104975952459659?= X-GMAIL-MSGID: =?utf-8?q?1762104975952459659?= tc-aarch64.c:1473:27: runtime error: left shift of 7 by 30 places cannot be represented in type 'int'. * config/tc-aarch64.c (parse_vector_reg_list): Avoid UB left shift. diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 747cf37d4b8..99fb5de2679 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -1393,7 +1393,7 @@ parse_vector_reg_list (char **ccp, aarch64_reg_type type, char *str = *ccp; int nb_regs; struct vector_type_el typeinfo, typeinfo_first; - int val, val_range, mask; + uint32_t val, val_range, mask; int in_range; int ret_val; bool error = false; @@ -1414,8 +1414,8 @@ parse_vector_reg_list (char **ccp, aarch64_reg_type type, typeinfo_first.element_size = 0; typeinfo_first.index = 0; ret_val = 0; - val = -1; - val_range = -1; + val = -1u; + val_range = -1u; in_range = 0; mask = reg_type_mask (type); do @@ -1470,7 +1470,7 @@ parse_vector_reg_list (char **ccp, aarch64_reg_type type, if (! error) for (;;) { - ret_val |= val_range << (5 * nb_regs); + ret_val |= val_range << ((5 * nb_regs) & 31); nb_regs++; if (val_range == val) break;