diff mbox series

ubsan: aarch64 parse_vector_reg_list

Message ID ZCoAZZg7Py/LwyZl@squeak.grove.modra.org
State Unresolved
Headers
Series ubsan: aarch64 parse_vector_reg_list |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra April 2, 2023, 10:23 p.m. UTC 
  tc-aarch64.c:1473:27: runtime error: left shift of 7 by 30 places
cannot be represented in type 'int'.

	* config/tc-aarch64.c (parse_vector_reg_list): Avoid UB left
	shift.

Comments

Richard Earnshaw April 4, 2023, 4:24 p.m. UTC | #1 
On 02/04/2023 23:23, Alan Modra via Binutils wrote:
> tc-aarch64.c:1473:27: runtime error: left shift of 7 by 30 places
> cannot be represented in type 'int'.
> 
> 	* config/tc-aarch64.c (parse_vector_reg_list): Avoid UB left
> 	shift.
> 
> diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> index 747cf37d4b8..99fb5de2679 100644
> --- a/gas/config/tc-aarch64.c
> +++ b/gas/config/tc-aarch64.c
> @@ -1393,7 +1393,7 @@ parse_vector_reg_list (char **ccp, aarch64_reg_type type,
>     char *str = *ccp;
>     int nb_regs;
>     struct vector_type_el typeinfo, typeinfo_first;
> -  int val, val_range, mask;
> +  uint32_t val, val_range, mask;
>     int in_range;
>     int ret_val;
>     bool error = false;
> @@ -1414,8 +1414,8 @@ parse_vector_reg_list (char **ccp, aarch64_reg_type type,
>     typeinfo_first.element_size = 0;
>     typeinfo_first.index = 0;
>     ret_val = 0;
> -  val = -1;
> -  val_range = -1;
> +  val = -1u;
> +  val_range = -1u;
>     in_range = 0;
>     mask = reg_type_mask (type);
>     do


It's a nit, but I tend to prefer ~0u for unsigned values rather than -1u.

R.
diff mbox series

Patch

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 747cf37d4b8..99fb5de2679 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -1393,7 +1393,7 @@  parse_vector_reg_list (char **ccp, aarch64_reg_type type,
   char *str = *ccp;
   int nb_regs;
   struct vector_type_el typeinfo, typeinfo_first;
-  int val, val_range, mask;
+  uint32_t val, val_range, mask;
   int in_range;
   int ret_val;
   bool error = false;
@@ -1414,8 +1414,8 @@  parse_vector_reg_list (char **ccp, aarch64_reg_type type,
   typeinfo_first.element_size = 0;
   typeinfo_first.index = 0;
   ret_val = 0;
-  val = -1;
-  val_range = -1;
+  val = -1u;
+  val_range = -1u;
   in_range = 0;
   mask = reg_type_mask (type);
   do
@@ -1470,7 +1470,7 @@  parse_vector_reg_list (char **ccp, aarch64_reg_type type,
       if (! error)
 	for (;;)
 	  {
-	    ret_val |= val_range << (5 * nb_regs);
+	    ret_val |= val_range << ((5 * nb_regs) & 31);
 	    nb_regs++;
 	    if (val_range == val)
 	      break;