From patchwork Sun Apr 2 22:22:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 78307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1941750vqo; Sun, 2 Apr 2023 15:22:48 -0700 (PDT) X-Google-Smtp-Source: AKy350azV1k4uLiuM5hdMMyawI3FGFmAibA3sv0b65DxuV3/+JXMHYZrtj5VF4pqJFbBqOzCqkab X-Received: by 2002:aa7:da56:0:b0:4fd:2363:16f2 with SMTP id w22-20020aa7da56000000b004fd236316f2mr28681214eds.37.1680474168015; Sun, 02 Apr 2023 15:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680474168; cv=none; d=google.com; s=arc-20160816; b=hgCEqRj6XQUqalDxbGSSfKXSqPeVbr1hnDpZZQmBLZA3cry422vEqsgO8rkIeXNHGq iGOdqF/ydWl1DCCuqs/nwvv3qpAyUr89jMSySxb2Sr3wToyKaURh2t5tHj6ryi+pnnOy P/O1zAlGSxvNxZ+AKhv60hT/KToUzNc6HkftoklUMjQWmlN3In9l6SkLCvkILYCo6d7i Cn34oTCz1p7bqY4d49FLkGRPXqeivhdcj1kFnw5IVEkPoKO+CiSGgE/fv8GFjeA3HzsK L6AWAdoA7wT8uabda2STBQW3hRuEzjWC17fJSTNvS2Ww8NNX3WuiCmDT8urabjmaSmKQ gUjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=7K1UHxSHCwcoZYZ+HPt/RVRuZNtwMrCqVzOPDTQn7tM=; b=mEeNSmfTBP3p+e9RzP1O9cZUk7GlVrdiD28RYAED4ax4dAT5plqPrOH+IEw2u9RnWa /3tzNCil4wz9ubwEOhyunxEqVQDrAVfeLFAHI7ijgDpvyxJYqZJHWeV3z/7iiNMQYSPy xhmJadnwdSRg9Xww+oyZwClpHDjI2yX04U3GJ+mS+KOS9paWP87jsUkPEgQ5cNmVDe+n f58lBiWcI/UDfCfhJamZKDZTcRkOBZZU1a9Wv+Uv3+eBxBvChG+36Yq2ERk5ef6PvSAU bLIcGTAwP/lobMHqj+O1GI53KEJsWS8Zst7KQUcMrXavZy+3NTviIkVKOCwoAfR+cUgi NduA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ZqlZIcBt; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id t5-20020a05640203c500b00502538c4ce3si6449900edw.107.2023.04.02.15.22.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 15:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ZqlZIcBt; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F01DA3858C52 for ; Sun, 2 Apr 2023 22:22:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F01DA3858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680474167; bh=7K1UHxSHCwcoZYZ+HPt/RVRuZNtwMrCqVzOPDTQn7tM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZqlZIcBtc9KDnHryAmzpyaPDplS7HYRh/uSjX5yUCgARTYtq8NX5c+tWeO1+HshYe sxdVYeCuYskcgltdmgKIiy/0jcLTSOt1qRuEVUyRuucF0b9j/ZBHsQZGBQXW72vWI/ ULRwvvrHvdVDPTYvJ9gjPtDzUtWJJwDlbZw8OTQA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id AFB463858CDB for ; Sun, 2 Apr 2023 22:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFB463858CDB Received: by mail-pj1-x1030.google.com with SMTP id e15-20020a17090ac20f00b0023d1b009f52so30667041pjt.2 for ; Sun, 02 Apr 2023 15:22:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680474154; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7K1UHxSHCwcoZYZ+HPt/RVRuZNtwMrCqVzOPDTQn7tM=; b=oeEj0giYvLNDThIF0wIxnOgWM8psdEpBg6S4YfY/2azeVefjsExv4W6F8mN5SkvZ49 wz3jL+JNLFiAv3R5uOgaKdOoG4vaeb+Xsw3IEpUUAhvq4heP4LO+Vm6mWbPLvBP/kTWS FJljrkXBhD/mPaF2nj82uy2X42FIg8S+uMNqgIFHsNPm1UhpH9/1Oadedf7TnrpHYqER b7WHt8PqxQkJaTX963lbjSpXOdQ44CQxgUbMgxtozffKztcRlbpHbRhxBzUSnM9AJeJA qehCI5rHDlTvgiLXoglQ3Q59rL3Lxs8wUA/VwjP+gQAhIwv46ytlHXbl7mDUW8Eut0a3 yxWA== X-Gm-Message-State: AAQBX9dWlR1lAjk3VlhFf0zXclsuVlfmjBS32f5B7PrrUspfvIkfvlPv 4A3/29ZZkhi8xmUcLiXePlyfJ2+uwBk= X-Received: by 2002:a17:903:20d4:b0:1a1:c746:7d6f with SMTP id i20-20020a17090320d400b001a1c7467d6fmr26547917plb.53.1680474153929; Sun, 02 Apr 2023 15:22:33 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4c75:41d5:4aa9:f18e]) by smtp.gmail.com with ESMTPSA id g3-20020a170902740300b001a19f2f81a3sm5200288pll.175.2023.04.02.15.22.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 15:22:32 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8B2C61140137; Mon, 3 Apr 2023 07:52:30 +0930 (ACST) Date: Mon, 3 Apr 2023 07:52:30 +0930 To: binutils@sourceware.org Subject: Memory leak in process_abbrev_set Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762104881344280488?= X-GMAIL-MSGID: =?utf-8?q?1762104881344280488?= We may have added some abbrevs to the list before hitting an error. Free the list elements too. free_abbrev_list returns list->next so we need to init it earlier to avoid an uninitialised memory access. * dwarf.c (process_abbrev_set): Call free_abbrev_list on errors. Set list->next earlier. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index d6fc9fe991c..d08f01cab79 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -990,6 +990,7 @@ process_abbrev_set (struct dwarf_section *section, list->first_abbrev = NULL; list->last_abbrev = NULL; list->raw = start; + list->next = NULL; while (start < end) { @@ -1005,17 +1006,13 @@ process_abbrev_set (struct dwarf_section *section, the caller. */ if (start == end || entry == 0) { - list->next = NULL; list->start_of_next_abbrevs = start != end ? start : NULL; return list; } READ_ULEB (tag, start, end); if (start == end) - { - free (list); - return NULL; - } + return free_abbrev_list (list); children = *start++; @@ -1050,8 +1047,7 @@ process_abbrev_set (struct dwarf_section *section, /* Report the missing single zero which ends the section. */ error (_("%s section not zero terminated\n"), section->name); - free (list); - return NULL; + return free_abbrev_list (list); } /* Return a sequence of abbrevs in SECTION starting at ABBREV_BASE