From patchwork Wed Mar 22 00:13:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 73115 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2080048wrt; Tue, 21 Mar 2023 17:14:18 -0700 (PDT) X-Google-Smtp-Source: AK7set9ON/VHSIqFFepKw89h04TcIEjJtR31VkomcwCu3sFPwHx9huFNwLOB3C7hy+K8OkR82yvD X-Received: by 2002:a17:906:c047:b0:932:615c:33d4 with SMTP id bm7-20020a170906c04700b00932615c33d4mr370298ejb.34.1679444058770; Tue, 21 Mar 2023 17:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679444058; cv=none; d=google.com; s=arc-20160816; b=xnoOfGITXr50ytafZV/2NbUJ4QAVRnhc+yfQ18x0uUu9zDGfVxLCN0kuzCErRV8Slb o2sot0QB5KLW3OHeRmgLX14zQf+lHrHQ375k9UtgIDuK3s18A7D3JmhtfMa53gxnBQYE bsDTwzai4Z8BE2tDz6TtAxnyHM4FZ0nMMy6hLLxXwMinXku6KO2yLAbSP0q3NPwF91zU 8mU3yXQ7rLfP2G9Pv3fzqKSKFgy5rfFQuKxuwZ9oWZm642RxSGID19GVBaVnADo76n6a OTBnKAE0/AZ2Ukk1aN5SaAX9GToxDrk35NKkKJLIUYu1cl2UHX+CT2TioZxDX7JP0oCS 61ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=m/wwyb7VayExJLqva4JELUshANViVSRV+7iEV3q4ZBI=; b=OXz/J27NS12bEsIj1qg9F9nc69FBwD6weAc1hHltk+ogZ5HfF+cJgSXS9XLsQ+s5XG QSxYlmC3NNzn10qvcuUjNnqt1yb3P10hBq5EQzGa/4Lf468+OpiySRnLN1FFDp6+km+S 7hQ0cPpt+cWpjnxu4j6/umZmvSYsJmv3jRACJDg1FDajE4DLED6ePbQTHruGccVTywIR sNJParHBTTD866njXaC5TPLeYwVl5NTldsvxCogsNtSd+Y+BfQ9bLfD0JCaI9wrNq91l sw4pJpAtYxwNy6nbnHDAdnvSy6MMNdSCbb1rzl4HktmfAa8GmfcTNlocMlw+agdmx6fu TtKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rCzk29nj; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id sa15-20020a1709076d0f00b008dcca98e6edsi17361459ejc.29.2023.03.21.17.14.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 17:14:18 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rCzk29nj; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36BD03850439 for ; Wed, 22 Mar 2023 00:13:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36BD03850439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679444034; bh=m/wwyb7VayExJLqva4JELUshANViVSRV+7iEV3q4ZBI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=rCzk29njd8C66SR+4zUlso1PQC6MuP9IPRbEEhIKmRCPGs7lJXXRjxIzCNyUUHWaC pt6AwLxnMx/T0GAso3NFBvsTk4fiCMU2MmUQKLJPTH10BD5jK3RYzAjuawd3pu+YnK 3OVLk0cdUNrtLnbVRrUinLzXsT6AplPpBZDXm7XM= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 69B1E3858C1F for ; Wed, 22 Mar 2023 00:13:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69B1E3858C1F Received: by mail-pl1-x631.google.com with SMTP id iw3so17782576plb.6 for ; Tue, 21 Mar 2023 17:13:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679444023; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m/wwyb7VayExJLqva4JELUshANViVSRV+7iEV3q4ZBI=; b=heFaxOV+Mv4PD1JckXljLVmxdA6FpcyYcl3B2dv1UOuIRN01d9Nusoot7Tjvmxojv4 6K+ckSBa5xjeRLu7ee4uDdly4jSPWvfIufzB2aJqlcrzJCVum8bBxSJPpyTQvrlltWzR NXfqZhDJOBd/Ut+sPmxiSitlD/Yb7SmpGLFd0h2/PLpnsYU+369TbfiGXDOKJwe5j2te 8gI1y71ySLs27RwNWYg2qA3uxlcv5/naUkMI4/wGZRZU2v7xyhPk+I5VDzv/Z6ZOlmU3 nMsloBsBWgYbKPPgFLatbooWnYjHBaAQkHT5XOFJqh3znJDfDWZ6cg+eXr/CF7rR0AdM eDzQ== X-Gm-Message-State: AO0yUKUZ4EeMfQoddnCvJkZhRqaW9RlwqOhTuXy4GNDN3qVgMSZC6w5/ gaEYIYYlQtdzvGmsStHLyWXypnp39KQ= X-Received: by 2002:a17:90a:1a50:b0:23a:f4b4:630 with SMTP id 16-20020a17090a1a5000b0023af4b40630mr1424453pjl.23.1679444023178; Tue, 21 Mar 2023 17:13:43 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id gd16-20020a17090b0fd000b0023d2fb0c3a2sm11913295pjb.46.2023.03.21.17.13.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 17:13:42 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id DAB76114093F; Wed, 22 Mar 2023 10:43:39 +1030 (ACDT) Date: Wed, 22 Mar 2023 10:43:39 +1030 To: binutils@sourceware.org Subject: coff_get_normalized_symtab bfd_release Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761024733672743414?= X-GMAIL-MSGID: =?utf-8?q?1761024733672743414?= We can't free "internal" on errors, since bfd_coff_swap_sym_in may call bfd_alloc. For example, _bfd_XXi_swap_sym_in may even create new sections, which use bfd_alloc'd memory. If "internal" is freed, all more recently bfd_alloc'd memory is also freed. * coffgen.c (coff_get_normalized_symtab): Don't bfd_release on error. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 774edf76f24..0b764b0c45f 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -1753,10 +1753,7 @@ coff_get_normalized_symtab (bfd *abfd) /* PR 17512: Prevent buffer overrun. */ if (symbol_ptr->u.syment.n_numaux > ((raw_end - 1) - raw_src) / symesz) - { - bfd_release (abfd, internal); - return NULL; - } + return NULL; for (i = 0; i < symbol_ptr->u.syment.n_numaux;