diff mbox series

coff_get_normalized_symtab bfd_release

Message ID ZBpIM3lRdkoNAN+5@squeak.grove.modra.org
State Repeat Merge
Headers
Series coff_get_normalized_symtab bfd_release |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra March 22, 2023, 12:13 a.m. UTC 
  We can't free "internal" on errors, since bfd_coff_swap_sym_in may
call bfd_alloc.  For example, _bfd_XXi_swap_sym_in may even create new
sections, which use bfd_alloc'd memory.  If "internal" is freed, all
more recently bfd_alloc'd memory is also freed.

	* coffgen.c (coff_get_normalized_symtab): Don't bfd_release on
	error.
diff mbox series

Patch

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 774edf76f24..0b764b0c45f 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -1753,10 +1753,7 @@  coff_get_normalized_symtab (bfd *abfd)
 
       /* PR 17512: Prevent buffer overrun.  */
       if (symbol_ptr->u.syment.n_numaux > ((raw_end - 1) - raw_src) / symesz)
-	{
-	  bfd_release (abfd, internal);
-	  return NULL;
-	}
+	return NULL;
 
       for (i = 0;
 	   i < symbol_ptr->u.syment.n_numaux;