From patchwork Thu Mar 9 12:17:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 66828 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp254998wrd; Thu, 9 Mar 2023 04:17:54 -0800 (PST) X-Google-Smtp-Source: AK7set8yZQAracst/QzCQNRX1Gggd8rDvKoMYfDgeAGYpa64e9Tz2GY5BvM3Recv/yxQnmIDK4vP X-Received: by 2002:a05:6402:6d5:b0:4ab:4cf0:4ab3 with SMTP id n21-20020a05640206d500b004ab4cf04ab3mr18449108edy.38.1678364274069; Thu, 09 Mar 2023 04:17:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678364274; cv=none; d=google.com; s=arc-20160816; b=nyPFPLXO6rCleNQgkEYTWP95Sy0et1Ac4UhP4COuBY5Ghk7geRVrESLb5gBJ0xcxl9 v413adX5kZ4RUA2h4oSnzIzxXmWMUUtCrPhDy3oskv6rAilpmCDJVYXGNJgEN3vUGhfJ 8y4O8LtJRycop8M+SalK5ukbGwpPtS8Dy6tubI7/bb5Yy6+vKjjHaI79CK6dc7xLlIGa FYGVC8OcFmbgtW5H248o6h4NiTENDgT3vVNxXXBhEKsHWjIGQF7ls/+I9NywVEpz0aA7 lN3S5qF/FGzZ9EoWOnakNRTY6pnYmaPgDtEHmsHmsB+l+JcRYW2qKzhUQYuCtEmX9A89 GILQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=K33IJh8WnMzOxNkLOW9a4pUS/NM6pTbM6tRgGIzOYmg=; b=xlnxNCQ0EmCvJ7kc55av3MC4CBF2X6YhHlOUx2ZHP5n7TL8ygZGAZ+m1BKMqUPpfu1 0UuvC/XYnAPZhKGzZeJeh2a2zHu97NsndgMDRMVgmjbYNfL+QcVHHxq+omuxs0avnQ/z 43/r0NNhfZFkm6PDfwrctwm7nFG+kI2YTCqwF+7P2QHnhvwRsZiEo78XbvAm3n5imho7 Tn8JJ1Tv/vooAhi8wUim4d9R10hLSBmgzex4O53HsP8L94uojPqLoRO5HzlfaUjU0jNP 1JViVln2vx+C98K24GPT2/ZQyFPBFt6F32NrOIqX5qBNIlg/ThtzSrDLelvkkrmu+AUZ 1RKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=sxGt3PNf; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ca24-20020aa7cd78000000b004ad021e0d95si1414478edb.25.2023.03.09.04.17.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 04:17:54 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=sxGt3PNf; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 05F643857C55 for ; Thu, 9 Mar 2023 12:17:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 05F643857C55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678364273; bh=K33IJh8WnMzOxNkLOW9a4pUS/NM6pTbM6tRgGIzOYmg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=sxGt3PNfrJI+IdYocpOlL7ZPBv5IhSg36OLBynm0RM3kwwt+UYeZ66CMNSjMSsEze 7SvAMDFeXtr5pj3LmcpDDahP54NonELLIORLsMNDO0A3HyFHdElfz6htRv3g3hm/Z4 8XXUItFgO0QnA25nON/kKnQmfkYw7GIEvU15KZSI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id A2FF03858000 for ; Thu, 9 Mar 2023 12:17:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2FF03858000 Received: by mail-pf1-x432.google.com with SMTP id cp12so1343880pfb.5 for ; Thu, 09 Mar 2023 04:17:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678364249; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K33IJh8WnMzOxNkLOW9a4pUS/NM6pTbM6tRgGIzOYmg=; b=N38OZGXslvN5q5gX87S1PtwlRdBsxsmfdlUlAYOEfQNzXRPw8Grho+XdSM9i8mvvux jwflis/6553V3DjV4V91TncxyjBAjNxxcIbJ2QbpcbEmQJUga3Z38ZllF/f3SCcAzEDu kji6HFsgWBU2HFlUSCabG7x7DAFQ8zLblMlghwSvDgzWxA7WLAZF7kBBoOlB77kkM7Ax mczoHR2A9CIP9OiaBWvOMmtIxBTljkKH5JunD8asHO7DKuOwtyqXhNNBtVQifRRDBdiG TEFLx3xVB1il0ItVSqcl8OKpaDnPpBuuWoADNhR3clW8NW/R9/BKSYIhILs7aYty2Lwo nY4w== X-Gm-Message-State: AO0yUKVzIikpTBrXn0jeUEWM0b/QCLR+awr6ihZnpdIh4wDL5KJP7+O9 DKGrHrAL76GZCaJgncPvpsQS3Xlo398= X-Received: by 2002:a62:3204:0:b0:5a8:a0df:a624 with SMTP id y4-20020a623204000000b005a8a0dfa624mr15882345pfy.22.1678364249429; Thu, 09 Mar 2023 04:17:29 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4d08:cebd:d73f:b794]) by smtp.gmail.com with ESMTPSA id n4-20020a62e504000000b005a79596c795sm11061020pff.29.2023.03.09.04.17.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 04:17:29 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id EC7951142C8C; Thu, 9 Mar 2023 22:47:26 +1030 (ACDT) Date: Thu, 9 Mar 2023 22:47:26 +1030 To: binutils@sourceware.org Subject: objdump: report no section contents Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759892497087116343?= X-GMAIL-MSGID: =?utf-8?q?1759892497087116343?= objdump's read_section is never used for bss-style sections, so to plug a hole that fuzzers have found, exclude sections without SEC_HAS_CONTENTS. * objdump.c (read_section): Report and return an error on a no contents section. diff --git a/binutils/objdump.c b/binutils/objdump.c index 97532bed97c..0e8e1980b80 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -4477,16 +4477,16 @@ read_section (bfd *abfd, const char *sect_name, bfd_byte **contents) return NULL; } - if (!bfd_malloc_and_get_section (abfd, sec, contents)) - { - non_fatal (_("reading %s section of %s failed: %s"), - sect_name, bfd_get_filename (abfd), - bfd_errmsg (bfd_get_error ())); - exit_status = 1; - return NULL; - } - - return sec; + if ((bfd_section_flags (sec) & SEC_HAS_CONTENTS) == 0) + bfd_set_error (bfd_error_no_contents); + else if (bfd_malloc_and_get_section (abfd, sec, contents)) + return sec; + + non_fatal (_("reading %s section of %s failed: %s"), + sect_name, bfd_get_filename (abfd), + bfd_errmsg (bfd_get_error ())); + exit_status = 1; + return NULL; } /* Stabs entries use a 12 byte format: