From patchwork Mon Mar 6 03:32:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 64417 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1639824wrd; Sun, 5 Mar 2023 19:33:01 -0800 (PST) X-Google-Smtp-Source: AK7set+YzlYoq7P0P9wWBq2nZrXrKbLyw6AOtaZ56Xp40qCqITMzeR9IJZ8MLbmsp/KdVGl3aH3s X-Received: by 2002:a17:907:3e91:b0:8b2:b711:5e62 with SMTP id hs17-20020a1709073e9100b008b2b7115e62mr10949871ejc.52.1678073581479; Sun, 05 Mar 2023 19:33:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678073581; cv=none; d=google.com; s=arc-20160816; b=fCySdknFk5QUBALUEzXHAxu5aHEz2ZixZjc4FmUSX8pNlsA0xjWW8x62NsYZr313Ly Zykc/MaHwimfQY+VHE3a5NqSxksIO/xU3JTOiuT/Uhk1m0pjLk7lROnfCv0l72xIKNt3 8STAzWblcAn1jTDcywH7UEtXusqxtqNk0Fv8Z+rh+zCDf0SvexdTmQy4DNs6FOoQ6oSU jweFkkBa/914T5j4+xQz9d0z447iRKgtzePrsObCDYd+bv9lxRNmy8gcrpb8pEAvxkn2 gbZMUw2l0QOsYcWOpH4RXPwLcoiiZS+Jn2GQ6qpJ2u3ki5oe6dmQdPPsqlPzJtwmbWMF COqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=+SgYdgKHWeIal0TJMl+6O8l9az7MbIukdknzfuxBHGo=; b=KRVTyJftiptkmfQViWWSav7POuFOu90DmUBpauEQwSDmXTwE8t2i11IEnD3rqTvY2E THgATUFrbMd/aX060KG4rnJzrhAnYAEMxWbDYORwyfoJ5jxNFoVq4sSYry4spmL7tgGw bc3qCiawPkwkcMRGHV+DcGyZk5vtRIsCKImz5/f6Qtkr5XDcKqXY9Qi+VN5fpvHgWP+q neruT+F4H3GVe2UmzaJmQmoun7ZH/4O30pSz+cCJnVeQ2VxGwHRFbLQ7VTEwXAPGZ/az We/iOzIoQeTiUxo4wxRak+l61vYHn0674BbxWsf5to4eY7YaAYCHT+j2+/65dj+T2Qc0 ZL5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=jIOlAadv; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id u11-20020a170906c40b00b008cd1905b601si7879446ejz.443.2023.03.05.19.33.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 19:33:01 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=jIOlAadv; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E54F3857BB2 for ; Mon, 6 Mar 2023 03:32:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E54F3857BB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678073576; bh=+SgYdgKHWeIal0TJMl+6O8l9az7MbIukdknzfuxBHGo=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jIOlAadvts3rmpr61XK7GYsMwr1fxpeg7IaP1+ZxcwQDa0jqOyzs3DG/DHknzF/4k 4URuQICTpE5dJw4HPhAZhUyixoLU0SKRzb5oasfUIkVYstgvM3o5oh5wk/d0p6pvym sMW5xzN4lfaWOP8AaCktiEzgP1cnh861tVABLkeM= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id B4D513858024 for ; Mon, 6 Mar 2023 03:32:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4D513858024 Received: by mail-pj1-x102b.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso7621255pjs.3 for ; Sun, 05 Mar 2023 19:32:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678073567; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+SgYdgKHWeIal0TJMl+6O8l9az7MbIukdknzfuxBHGo=; b=zb1Wyrtr8EJ08vLJduNZ5JQgU9OrfmtEKl/oZlIsrtuZsJbymNCTaj54ypDJlszXg/ m8zP5SCP6enc1oh/9wfUGhMAId5iGqt52LMHilTwwePMa0otwDCLvA6Gq0I85wuEIp9S W/ZDJvhWOpMxr7FD6FaF6FS/B1i2BZL4oJ0l/nq/RED0v/zkYnIuGnexWSkJwpdlCArm l/e5LBUL3jfk0+6KaEMx+IhZbm9EpDDBfDjbuk5vmLrNi3C25MiUf1b6qVBnZWrZEU6R 709vCTdQ0XxKEjskArieOSqLxfsDLiAwxZJdxsKVasVkc7vmgaNKNNKFE2L6lu/kI92/ TiNQ== X-Gm-Message-State: AO0yUKXF16tmw3wwRdlKdh/TYD0t9gV/4i1Dt35zMe9NwFZEAbK6oH/G veWqEPZtfn3dR0hzPxOkyHTo6qLrp3M= X-Received: by 2002:a17:903:2441:b0:19e:85e8:f78d with SMTP id l1-20020a170903244100b0019e85e8f78dmr11593655pls.65.1678073567603; Sun, 05 Mar 2023 19:32:47 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:706e:b31e:8824:abae]) by smtp.gmail.com with ESMTPSA id kf3-20020a17090305c300b001994fc55998sm5419396plb.217.2023.03.05.19.32.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 19:32:47 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3436F1142C90; Mon, 6 Mar 2023 14:02:45 +1030 (ACDT) Date: Mon, 6 Mar 2023 14:02:45 +1030 To: binutils@sourceware.org Subject: PR30198, Assertion and segfault when linking x86_64 elf and coff Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759587683839911158?= X-GMAIL-MSGID: =?utf-8?q?1759587683839911158?= PR 30198 * coff-x86_64.c (coff_amd64_reloc): Set *error_message when returning bfd_reloc_dangerous. Also check that __ImageBase is defined before accessing h->u.def. diff --git a/bfd/coff-x86_64.c b/bfd/coff-x86_64.c index 13061cdacff..822504a339b 100644 --- a/bfd/coff-x86_64.c +++ b/bfd/coff-x86_64.c @@ -139,15 +139,19 @@ coff_amd64_reloc (bfd *abfd, break; case bfd_target_elf_flavour: /* Subtract __ImageBase. */ + h = NULL; link_info = _bfd_get_link_info (obfd); - if (link_info == NULL) - return bfd_reloc_dangerous; - h = bfd_link_hash_lookup (link_info->hash, "__ImageBase", - false, false, false); - if (h == NULL) - return bfd_reloc_dangerous; - while (h->type == bfd_link_hash_indirect) - h = h->u.i.link; + if (link_info != NULL) + h = bfd_link_hash_lookup (link_info->hash, "__ImageBase", + false, false, true); + if (h == NULL + || (h->type != bfd_link_hash_defined + && h->type != bfd_link_hash_defweak)) + { + *error_message + = (char *) _("R_AMD64_IMAGEBASE with __ImageBase undefined"); + return bfd_reloc_dangerous; + } /* ELF symbols in relocatable files are section relative, but in nonrelocatable files they are virtual addresses. */ diff -= (h->u.def.value