From patchwork Tue Mar 14 02:06:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 69248 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1516108wrd; Mon, 13 Mar 2023 19:08:46 -0700 (PDT) X-Google-Smtp-Source: AK7set/2LzzvN1mLDdrGJ2ENDnkALmAgBOACML9Se+lCdwDD9n4bHtNhuULIjysnJGrlPy/ZlxIi X-Received: by 2002:a17:907:1690:b0:878:481c:c49b with SMTP id hc16-20020a170907169000b00878481cc49bmr1053438ejc.1.1678759726605; Mon, 13 Mar 2023 19:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678759726; cv=none; d=google.com; s=arc-20160816; b=tWxvth5DSV2Iwcau6HRTSnuJnxULgCgBaNPdbO3Ik+RTGFrEotIY8jtHiSagmJ6iK3 +UAVJhFjDv5YVXaM5Gskm1uuBmYHGx7p6165ifR5NlZO83jeM+KL8z5HeqBtGZAowTMl 3DNC9gzBOviPRXK1emTeLuLS09zvQ3dhhnuMwpmQNLhY0qNG20ZJHIMxOZAQ3i2wOps9 n4aLEoCRyzOj0FP41q8JyAVa3kUrryw8CxtYea2546vSgST8x/N3XircRoU8G4BNoo94 JV9IeLt+o3zIT7DQWG54uYgOf21nCSBkyxH5lzrhrBqlGxOljjJXY6s50xgRTHUhZQSu PGvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=JYXa7CGIxlOsHVGT8MRiaFju1UXVihCbWd64vFPhfkA=; b=Ph1o95IePlWVv2GLWsHxXSxBpq7mEcE+OoVWhRl5qM5BrRDsD6ETBeCLuPTr8Uw8Wi 58Qb+DkQ/VOy7EotffT5HSF1i/xtW9GwzDq0s3jPe55PGSf9B2ZNtZCQ3frBKjRWTpmU WL9ltmt5OxtwlFUXLSkBQUt9yzp/1BbEEql6WhG+IsUUXdiyywTSOw2lCfviK+bruRdj 8LBFweg8SFBmd6wjdyz9VfDsHdMe3g0HMOU9rTIFtJrrfZcuY7PWbXs/1AFAWCFasba7 4nRqXbeGJQQ+cwAxfCRhG4mwSEdTd3byi/z4XvyP3tILm43Tn4t8AB+NUZ19KvO4dbNB 3+vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Ho6P68Rc; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a19-20020a17090682d300b008c215db35a7si1236643ejy.37.2023.03.13.19.08.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 19:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Ho6P68Rc; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DC5D3858032 for ; Tue, 14 Mar 2023 02:08:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DC5D3858032 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678759706; bh=JYXa7CGIxlOsHVGT8MRiaFju1UXVihCbWd64vFPhfkA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Ho6P68Rc+8J/VhlKXmOXT0QfHMOBBzxLA3PT+uWXK+IWZXQKoeAJu2cE6EvuUWk0s vknd+OGWStmmmIvUZ4+NEgof5VxxCTEQsTz99cCjtAFihtbMhHreKXIqgcz45GlWqH 1lWRS4oXAvAaa0l252WsAT73j24ZdU4b2JtHA+W4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id F11023850430 for ; Tue, 14 Mar 2023 02:06:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F11023850430 Received: by mail-pl1-x633.google.com with SMTP id v21so4929518ple.9 for ; Mon, 13 Mar 2023 19:06:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678759617; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JYXa7CGIxlOsHVGT8MRiaFju1UXVihCbWd64vFPhfkA=; b=kSbGzBONqWbbYBDadrkcm7f7+DnIppGKa3L1unc2tBseWXNt4HtWaCyTHSu0i3eRIL l8VkwAH+Jm8SEALy+grVeoeg8EUpccCeM2vwwa2ShOsgH2SvDVWzCrFjsQQ8qzRce4YH HZVIBi4LYXt4pIEZvXFwyRm5/3SqBhGDP2L8FjmhFG6U1DP0yTMi7lG/pUaSb7xoRXLn LTOLwSMJ20IM68UAncHsImr+4L5CS07sDnwhSLVVGCsA3LDfA16AATFlqyX6Ao+hl8D7 D3G8/O66KfhOOsvJcWPbuiFFUn+piMKelMqjNUgkGbYh1ky4Fd29jb+6q98NAGHhSJ3L hvpg== X-Gm-Message-State: AO0yUKVZoHBifdp+e6zV+Smbei9xAz4jskxowR5M5fNDl2q/Onl/TSM4 6l6Yd4ljggnCAXmCBDzTjD735lYS09c= X-Received: by 2002:a17:902:e851:b0:19a:839f:435 with SMTP id t17-20020a170902e85100b0019a839f0435mr14047607plg.3.1678759586829; Mon, 13 Mar 2023 19:06:26 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u7-20020a17090341c700b0019460ac7c6asm451040ple.283.2023.03.13.19.06.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 19:06:26 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 81F7E1142C71; Tue, 14 Mar 2023 12:36:24 +1030 (ACDT) Date: Tue, 14 Mar 2023 12:36:24 +1030 To: binutils@sourceware.org Subject: objdump segfault after symbol table error Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760307159253792425?= X-GMAIL-MSGID: =?utf-8?q?1760307159253792425?= This memcpy segfaults if symcount is -1 (=> syms is NULL). memcpy (sorted_syms, symcount ? syms : dynsyms, sorted_symcount * sizeof (asymbol *)); * objdump.c (slurp_symtab): Don't leave symcount as -1 after an error. (slurp_dynamic_symtab): Likewise for dynsymcount. diff --git a/binutils/objdump.c b/binutils/objdump.c index 0e8e1980b80..5dac13ba868 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -1015,6 +1015,7 @@ slurp_symtab (bfd *abfd) my_bfd_nonfatal (bfd_get_filename (abfd)); free (sy); sy = NULL; + symcount = 0; } return sy; } @@ -1048,6 +1049,7 @@ slurp_dynamic_symtab (bfd *abfd) my_bfd_nonfatal (bfd_get_filename (abfd)); free (sy); sy = NULL; + dynsymcount = 0; } return sy; }