Call bfd_close_all_done in output_file_close

Message ID Y9N2vclgJwnt0fbW@squeak.grove.modra.org
State Repeat Merge
Headers
Series Call bfd_close_all_done in output_file_close |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra Jan. 27, 2023, 7:01 a.m. UTC
  bfd_cache_close_all is good for closing file descriptors, but doesn't
do the cleanup of bfd memory as in bfd_close_all_done.

	PR 13056
	* output-file.c (output_file_close): Call bfd_close_all_done,
	not bfd_cache_close_all.
  

Patch

diff --git a/gas/output-file.c b/gas/output-file.c
index 4c97e8f1a9b..88f40116513 100644
--- a/gas/output-file.c
+++ b/gas/output-file.c
@@ -96,7 +96,7 @@  output_file_close (void)
 
   /* Close the bfd.  */
   if (!flag_always_generate_output && had_errors ())
-    res = bfd_cache_close_all ();
+    res = bfd_close_all_done (obfd);
   else
     res = bfd_close (obfd);
   now_seg = NULL;