From patchwork Thu Jan 26 21:52:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 48911 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp505101wrn; Thu, 26 Jan 2023 13:53:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXt+SznNFZZv15EwM3Jo5gzjAgitBAIUIj7H0xAZUdZ0PKKIZ3ul9W4W7XhzmWy5c9sk7Wkh X-Received: by 2002:a17:906:b317:b0:84e:d302:1551 with SMTP id n23-20020a170906b31700b0084ed3021551mr39852762ejz.37.1674769995743; Thu, 26 Jan 2023 13:53:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674769995; cv=none; d=google.com; s=arc-20160816; b=Frr77EaM/OeGpwWOFvh/VsvKYx4ZFyR7Qo7vd748ZeJd1PevhH9LsMoTjDbahOj4bl Qw7Ykr2CpJhbtyNzIvrJ1XHAcDuZClgDmQQHrXj/WgoKY3Fm7u+w5RN1KhoPZEDF8VPG kS+6UfPr9+iHSRPIxvlwROuqzivBMhTEgU8eOsiNW6M2vFvlIIdcmxv8B0TpwnrZie2U i+wqGZPZ3iQSKrI0ZTLQOwFPQyWVPw+4TbXM+FqmrypoptUbFWMqNjP0kkHbRSuJtPQb n7XmK6oqWynkP1f3uFz0r3CF0jhxb1uhFSsw5zpYjcqExLipu+0zUrRD8y3e+aVNlchV 9WDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=jbv1ppPesoo3gClkLSJoxl8COkHJ4YrfJ9Qlpe9n0TQ=; b=oiGWTSum/Um4bcn7qJLysSZHcdm5dOTjCKObyk8iTJ2ENn3mcdDf+cimpWXCyP1jwR NVvP34+egvBt4NV7EDLuTwqf8JEFmG8IA3mVSO0q8u59H1c6DsEKWOqFEeLQZn42B7yP mxbZD2sfgYxATXwj2qcvAWo1VLOEjwJYhbKzshcwZDMjj7KZvf/Qsd/yN0iGjzE74e/x THb0FkArwGdxrBj2EQGx3aa1l3BCfDbuu99SE5qVavmAIe/vW7p1PL20MGTlvs8HydAz Fv3C1MLh6eLJIYjKHAurxBYcDLo1s19+KA5m2uv9Cz45E6pJv/aBmUG6VvnJ7Y2iZElN oFPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DijWFaSp; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id 12-20020a170906018c00b008736ed0a13asi2678229ejb.343.2023.01.26.13.53.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 13:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DijWFaSp; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E9B083858404 for ; Thu, 26 Jan 2023 21:53:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9B083858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674769992; bh=jbv1ppPesoo3gClkLSJoxl8COkHJ4YrfJ9Qlpe9n0TQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DijWFaSpnI1e27hNwDPNsMcpoAZusNw3tAXWct2q+tDOxlHBChX1ivdZopITho2Ni Tc4jFl/XUW4Hk7CT/X3eDpms3dQjbHoZ4RYIY9G5wzoMpQxOpAMJDZ9PFnEZ+Y+myH cpFqyOHo1BNC+eZeNszCbIvdi5SGVJTzUvd2NmQM= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id A89AA3858C33 for ; Thu, 26 Jan 2023 21:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A89AA3858C33 Received: by mail-pl1-x62d.google.com with SMTP id g23so3088423plq.12 for ; Thu, 26 Jan 2023 13:53:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jbv1ppPesoo3gClkLSJoxl8COkHJ4YrfJ9Qlpe9n0TQ=; b=m4mPBOOhbww2Xh6FKsFMbu7huC8TLMrnWeD/fi/PAt3NuFrRKUFJOefj7ImwyaRue9 CsyNVJJ6kWCn+nkacw9AHjXbz9GRIKAkNLq+xu74KHc9oA2gkuueaAeUZsV8JRKJKdPY 0dOasaQB+BrXglbqWNBCQ972TetLakNQ77VlvQ9YHYVHmJO5MztLyYEaXoKVRU9xgQgM oPeBgjRc2o8HcTbdKM2WUxou1Ou902mRFSV+LWezPDDI0wkBsysVWhdIMIiT2upRLdxt /l362VgpooKGHrLnHuuN9NbGlkd/6u0m3knL6Ts7t6bgm+ANN1PvNLC0wxFw0XCBMzBq PvKQ== X-Gm-Message-State: AFqh2koPH6s8HrX4OIPd/Is82s39QZfN/nQ5Xf2OqQfkbetRYofK+v+m NSVgQOXho1VpeEWt+8ZvG85whHlOxOo= X-Received: by 2002:a17:902:b20d:b0:191:4389:f8f5 with SMTP id t13-20020a170902b20d00b001914389f8f5mr37613222plr.34.1674769981666; Thu, 26 Jan 2023 13:53:01 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id g17-20020a170902869100b00189c62eac37sm1453190plo.32.2023.01.26.13.53.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 13:53:01 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 46F3B1142CC6; Fri, 27 Jan 2023 08:22:59 +1030 (ACDT) Date: Fri, 27 Jan 2023 08:22:59 +1030 To: binutils@sourceware.org Subject: Sanity check dwarf5 form of .file Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756123622820706533?= X-GMAIL-MSGID: =?utf-8?q?1756123622820706533?= There's a comment a few lines earlier saying that demand_copy_C_string has already reported an error if it returns NULL. Given the proximity I decided not to duplicate the comment. * dwarf2dbg.c (dwarf2_directive_filename): Check return of demand_copy_C_string for file. diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c index 86dc16108e4..5f2f58ff7b0 100644 --- a/gas/dwarf2dbg.c +++ b/gas/dwarf2dbg.c @@ -1195,6 +1195,8 @@ dwarf2_directive_filename (void) { dirname = filename; filename = demand_copy_C_string (&filename_len); + if (filename == NULL) + return NULL; SKIP_WHITESPACE (); }