diff mbox series

Correct ordering problem in comm-data.exp

Message ID Y4cQAk+8VjJUNcAS@squeak.grove.modra.org
State Repeat Merge
Headers
Series Correct ordering problem in comm-data.exp |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra Nov. 30, 2022, 8:10 a.m. UTC 
  * testsuite/ld-elf/comm-data.exp: Build libcomm-data.so before
	attempting to read it to set ELF64.
diff mbox series

Patch

diff --git a/ld/testsuite/ld-elf/comm-data.exp b/ld/testsuite/ld-elf/comm-data.exp
index cea03df2366..f46d69350b6 100644
--- a/ld/testsuite/ld-elf/comm-data.exp
+++ b/ld/testsuite/ld-elf/comm-data.exp
@@ -48,19 +48,8 @@  if { [istarget "mips*vr4100*-*-elf*"] \
     append LFLAGS " -call_shared"
 }
 
-# Set the pointer size according to the ELF flavor.
-set AFLAGS ""
-if [is_elf64 "tmpdir/libcomm-data.so"] {
-    append AFLAGS " --defsym ELF64=1"
-}
-# HPUX targets use a different .comm syntax.
-if [istarget "*-*-hpux*"] {
-    append AFLAGS " --defsym HPUX=1"
-}
-
-set testname "Common symbol override test"
-
 # Define a global symbol.
+set testname "Common symbol override test"
 run_ld_link_tests [list \
     [list \
 	"$testname (auxiliary shared object build)" \
@@ -72,16 +61,18 @@  run_ld_link_tests [list \
 	} \
 	"libcomm-data.so" \
     ] \
-    [list \
-	"libpr26580-1.so" \
-	"$LFLAGS -shared" "" \
-	"$AFLAGS_PIC $AFLAGS" \
-	{ pr26580-b.s } \
-	{ } \
-	"libpr26580-1.so" \
-    ] \
 ]
 
+# Set the pointer size according to the ELF flavor.
+set AFLAGS ""
+if [is_elf64 "tmpdir/libcomm-data.so"] {
+    append AFLAGS " --defsym ELF64=1"
+}
+# HPUX targets use a different .comm syntax.
+if [istarget "*-*-hpux*"] {
+    append AFLAGS " --defsym HPUX=1"
+}
+
 # bfin-elf does not currently support copy relocs.
 setup_xfail "bfin-*-*"
 clear_xfail "bfin-*-linux-uclibc*"
@@ -121,6 +112,14 @@  run_ld_link_tests [list \
 	} \
 	"comm-data3b" \
     ] \
+    [list \
+	"libpr26580-1.so" \
+	"$LFLAGS -shared" "" \
+	"$AFLAGS_PIC $AFLAGS" \
+	{ pr26580-b.s } \
+	{ } \
+	"libpr26580-1.so" \
+    ] \
     [list \
 	"pr26580-1" \
 	"$LFLAGS --as-needed -Ltmpdir -lpr26580-1" "" \