From patchwork Fri Nov 18 01:02:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 22004 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp711172wrr; Thu, 17 Nov 2022 17:03:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf7tY0tykMZJJRhaRjVbie0M+3J/QNDX6c+vNlb44poQolgbixlfUcc23Z31zVK+S9rW7c3k X-Received: by 2002:a17:906:398b:b0:7ad:b868:f096 with SMTP id h11-20020a170906398b00b007adb868f096mr4160700eje.295.1668733391905; Thu, 17 Nov 2022 17:03:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668733391; cv=none; d=google.com; s=arc-20160816; b=rIndhWHBf6ts6oLI0sjiIp9p+Uo3FROKGYketPWSUlwFtxvWZVhu+cTQet3/81yZH0 zJ574VHRzzoPI5yML66wNXvYGZbywUBs1+ML5m4B17E4Lyg9/Pk6sEvjJXJ9+i3CRA9w rb2llEpwWvP0j0+75iIwn3BCY7lAbMIU2KrO+d9uNi8QMX5iJ5vkFd3ybRd5PLh+KuSi kfcxP3adG+bFqMz7LMjRntOtd6ONKWuR5Gg7t0vbOFl9tKP3s0iYm8xP0Hm6J29y6u57 xuyV0WNr4/E3AHkrG2LNaqLzdoYaeSaETVUO3Z2y+e/6fSVil4Y6sazTKJ70wvWFyJlC nsrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=dNihokxnN/8xJxBD3mvUVZc+KmNoJCR2DY153e9LH0Y=; b=mzeNcr7/IrBFVhCMFsrsNPsiZrXyQGwy4UFwGLmfcTKI1go+VON3lEFbmnAqsw8pU7 77bqTWVVsXN0HpEhJhq7OyPkHGTKYwDyDrRYR8iAb4nVpwlQruPohD6VndSVKcn7LLfo L49dS+DYCV/EknI8tWC11a28g5RNIZHOmiphnVSTdGKdn0pMIUj2mDaoT3VLR8a1j6BA uFNc5F4PWgeoqPQORvDrwR6+amMsMUfwoGv0H6yZbPSE+afMqX9xLb441J/tKAWfSGIB IGzLT9fBqQF5YVWCMLESVSq+mmEUjQsCTxbNEszwhCvfCmM0nZZT/UEVKAmuV6Cjd2Vh uXxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=P9X8YFLV; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h22-20020aa7cdd6000000b004604906b23csi1857811edw.545.2022.11.17.17.03.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 17:03:11 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=P9X8YFLV; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF3A53857838 for ; Fri, 18 Nov 2022 01:03:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF3A53857838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668733390; bh=dNihokxnN/8xJxBD3mvUVZc+KmNoJCR2DY153e9LH0Y=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=P9X8YFLVh4jUYAuiN4kNvWJnv/dTuxBPPNKs9a9aeOVbHew8Ih+RCPiB5iYhFT2EO SAL9YfouFhj1ceh9rlQqS7JNT93H+1BmAJSEFw6fi6fAppO/vJvrPwRsump1tnzh1Y pDB+UmkZLk7VMetsm626S4kRTWZ7sB0KaHGOWKdY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id A51303857838 for ; Fri, 18 Nov 2022 01:02:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A51303857838 Received: by mail-pg1-x536.google.com with SMTP id 62so3623104pgb.13 for ; Thu, 17 Nov 2022 17:02:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dNihokxnN/8xJxBD3mvUVZc+KmNoJCR2DY153e9LH0Y=; b=ycG758nXVhXqqPZSE/rQ0zUXjskuW6qNHyCQ1AQSnXY7/3yTovBHuSLxcCruLr3wcm lMr+UE9C84hDBhMuLkd0yZoo3Yq0IPrzYmq3iFh8G4/dTWB3KR6vxbfAnSwB9w9UUCuL mNKXdaA5HsG2ArRfjt0Qg+zNMVjuFN1NnKx7Qlzg9kIJt9nKc6pxSKmabQNRDniNG7+U +PVsoCOLmt2n4urhqz7eoQnolr+Q4o2WQpz7fh7WaajqbWfVGewewvSXjIhYLBnNUb0q 5iEmP5AB1bcFarQefCFvr/26bZBr2ropUok2QGY5FCzNr3iaLSCtUmdkKN+nFn6V36pG Hsww== X-Gm-Message-State: ANoB5pmwH/HSqc9bxBimspuCjxQJmFlWTzH5ohwow7S2pKrEPLCvJ/yB /SURvgZBM5GsIf0GTnT2cdVjDyibmXQ= X-Received: by 2002:a63:eb15:0:b0:476:ea7d:2931 with SMTP id t21-20020a63eb15000000b00476ea7d2931mr4415079pgh.142.1668733370074; Thu, 17 Nov 2022 17:02:50 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4d9e:9cf4:c6f4:81ce]) by smtp.gmail.com with ESMTPSA id w11-20020a170902ca0b00b001867fdec154sm2003653pld.224.2022.11.17.17.02.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 17:02:49 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 4306B11409DD; Fri, 18 Nov 2022 11:32:47 +1030 (ACDT) Date: Fri, 18 Nov 2022 11:32:47 +1030 To: binutils@sourceware.org Subject: go32 sanity check Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749793785213873704?= X-GMAIL-MSGID: =?utf-8?q?1749793785213873704?= * coff-stgo32 (go32exe_check_format): Sanity check stubsize against filesize before malloc. diff --git a/bfd/coff-stgo32.c b/bfd/coff-stgo32.c index cb0df389375..17271753a7a 100644 --- a/bfd/coff-stgo32.c +++ b/bfd/coff-stgo32.c @@ -291,6 +291,10 @@ go32exe_check_format (bfd *abfd) if (last_page_size != 0) stubsize += last_page_size - 512; + ufile_ptr filesize = bfd_get_file_size (abfd); + if (filesize != 0 && stubsize > filesize) + goto fail_format; + /* Save now the stub to be used later. Put the stub data to a temporary location first as tdata still does not exist. It may not even be ever created if we are just checking the file format of ABFD. */