From patchwork Thu Nov 10 10:12:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 18044 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp56896wru; Thu, 10 Nov 2022 02:12:50 -0800 (PST) X-Google-Smtp-Source: AMsMyM629eIobdFv50EpeqVv5M2iK1heHr+QATLgTBJfkVF53z4aQRIoSso3M4obtYBmUzzOht22 X-Received: by 2002:a17:906:2681:b0:783:6a92:4c38 with SMTP id t1-20020a170906268100b007836a924c38mr58861527ejc.75.1668075170333; Thu, 10 Nov 2022 02:12:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668075170; cv=none; d=google.com; s=arc-20160816; b=J9T5VZpZO075fImZmKx8opm8TBo3GOQk6wIiGtKmIIrOlvHReLcR0d4IuNihT4fwHS kNpeEfBhZM4gWB2psMl9Ty1sw33j9NK2PLPHWTlgR7+dR6uWDIhT4DhrdrZoc5WH6W2a z7Ft+mnk4svQQYPpKmKtomocaI6v978mzySoAIKnjLuLPmlxh+OVJxBMuPhYsWb609Bo pguzDkmt3COHo+PYr65mnze1OLydXQDk6oalU2VHYt4erXZNmUsz87xi8p3zvMjpbx6V sU4r8bNhB9SmFj6E4/JLeqvoWLmJdzDUdv5ESbUkOBkxn9X1dYdhu+slwUs3IshAZfl3 VFNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=eEW591YS0JZucAn2D8gFufdcGvvdF786q2p0CgsuHu8=; b=pgTe2PkIrB3+5c883d1XPX9EwmDKiot1f68uBaFKIETw4rYZOCgdgxQxuA6c3sQlOb CnYgRYI2pyk5yAanu1BgGetGbcGsku3TAbnsQhPM4UxX3N3F2XLaeOTwZH5yCCSeZQxa jrx42v//ojSL3ke9wBjCsjAz4roN8AU44ihYyga4F0qkDPvy9mn4fqeYfHuxhBN/kyH5 WWscyJKMda5llusn3lQdX/I8gpn7ALbVdEDiwDR26I2wi38Tk8WByijI2XNFp4cuqIJU LcNs6ztzIZs/CsjSAZFq8U8lHCE9mg5KJn2zI0Yg7hbeKFGsCqpExqOJacGXIAYij4iJ tR7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ATuw9dRk; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qa41-20020a17090786a900b007ae814af686si7082521ejc.974.2022.11.10.02.12.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 02:12:50 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ATuw9dRk; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF6F63858C2F for ; Thu, 10 Nov 2022 10:12:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF6F63858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668075168; bh=eEW591YS0JZucAn2D8gFufdcGvvdF786q2p0CgsuHu8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ATuw9dRk2xHHiNYnw83QZRmlqrniYvbeBxdpkpXHRDEQ37ehGRDoAsSYRYXEYl9xP T4rE+xzv7qSxMLQjwUYBA4iqrxwBon+K23G/SgqINp7FtZ/n34PZF51nrsA/YD51Cj V2LiQqTOXy8Qe14bXSpi0GNJM0/KXqAHOcDcZBig= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id D014E3857C51 for ; Thu, 10 Nov 2022 10:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D014E3857C51 Received: by mail-pf1-x42b.google.com with SMTP id 130so1542142pfu.8 for ; Thu, 10 Nov 2022 02:12:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eEW591YS0JZucAn2D8gFufdcGvvdF786q2p0CgsuHu8=; b=a6Y1stUsl1ZlxbMxC5ObS0bvOdDJdxLB/eTlSHQln+8AamZKVdFru30HdZqdmnBAe2 gQ2rmKMFKi8I1K5xiBe54Wq581dpAGl/yP+/OfAjxQsFtPQKw19godr3QO/46GX0ST1Z sx+qPAlxBlZJIWW+Lh4gaiGaF9+5ACzYz9qp+OkyG3RhFNuXtSvIvHVnnp8fQU2VqvMx wo4Nxdd53/sd4lgYESv92D2PyNMbzTQ2WkJe0Bt6kAGLyeRgLcrEN8dRHtDvcF+ggD/1 OoOMT7WorYeNrk6K2Olj+D9e3gSJLqFxLiBl1lnigGuqIKAGnF2SiLrVfN1yeQRO8pBF VEbw== X-Gm-Message-State: ACrzQf2BEqMFQzOhsVaXWzOjJEloPclsrJyRzY/RaCxu9pGUVf/ZK98Q fjvXBCkBq961uU0kTuUPQiyLy79xDw8= X-Received: by 2002:a63:7d43:0:b0:46f:8466:4de2 with SMTP id m3-20020a637d43000000b0046f84664de2mr54278982pgn.478.1668075157349; Thu, 10 Nov 2022 02:12:37 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id z11-20020a1709027e8b00b00186f81a074fsm10723633pla.290.2022.11.10.02.12.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 02:12:36 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 4360D1142E79; Thu, 10 Nov 2022 20:42:34 +1030 (ACDT) Date: Thu, 10 Nov 2022 20:42:34 +1030 To: binutils@sourceware.org Subject: mach-o reloc size overflow Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3036.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749103590110440681?= X-GMAIL-MSGID: =?utf-8?q?1749103590110440681?= * mach-o.c (bfd_mach_o_canonicalize_reloc): Set bfd_error on multiply overflow. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 664ff44a8e7..bacb1a6252d 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -1663,7 +1663,10 @@ bfd_mach_o_canonicalize_reloc (bfd *abfd, asection *asect, size_t amt; if (_bfd_mul_overflow (asect->reloc_count, sizeof (arelent), &amt)) - return -1; + { + bfd_set_error (bfd_error_file_too_big); + return -1; + } res = bfd_malloc (amt); if (res == NULL) return -1;