Sanity check SHT_MIPS_OPTIONS size

Message ID Y23642YK4HTWnn3X@squeak.grove.modra.org
State Repeat Merge
Headers
Series Sanity check SHT_MIPS_OPTIONS size |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra Nov. 11, 2022, 7:33 a.m. UTC
  * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Use
	bfd_malloc_and_get_section to read contents of .MIPS.options.
  

Patch

diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index e0e23926f03..932167c15c6 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -7523,11 +7523,7 @@  _bfd_mips_elf_section_from_shdr (bfd *abfd,
     {
       bfd_byte *contents, *l, *lend;
 
-      contents = bfd_malloc (hdr->sh_size);
-      if (contents == NULL)
-	return false;
-      if (! bfd_get_section_contents (abfd, hdr->bfd_section, contents,
-				      0, hdr->sh_size))
+      if (!bfd_malloc_and_get_section (abfd, hdr->bfd_section, &contents))
 	{
 	  free (contents);
 	  return false;