From patchwork Sat Oct 29 04:52:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 12629 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1185642wru; Fri, 28 Oct 2022 21:52:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7myMKOHu87aPGmr4jQejpCAFqeIPE3Ubxh9bzcdgTxSnCR2OS7/sp/U5U7cVxVISutTUJZ X-Received: by 2002:a17:906:9746:b0:78e:11cc:3bb3 with SMTP id o6-20020a170906974600b0078e11cc3bb3mr2312538ejy.379.1667019171533; Fri, 28 Oct 2022 21:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667019171; cv=none; d=google.com; s=arc-20160816; b=L1iFg686P4cq/e9Q0+6K2kjYdc3A+IPYJ7hXhtLq1/2UgvfK4Ci+MoN1X3nP1E6O4L YWfuu2O3x27Eu7mzvHn3tGsT2kY8T9iMJwgnBl7a5Z+GB8zINbQRNMwP3bgeu/HRJH7W tm8QDIs0VCkRLdur+IXmSgljlB3EknJfJktHAhDsD08/AAHl3aTOyOtXS39LhK3fL3DE MC7ZJrhXUz8rpxhOBs9YKMsoI7iCwKDtHE4shiETOjjRSIgKXTq7PlZ3HPOucdTsoUwT niCF67+49hHLVipWBCoQ+rT/GKQxIje4POIMPEtLy6+dUlTi1ctchpVUrx1BchwFbg60 zONg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=SOysNDHJXJJu2FZ7C2HvAv6LIsY5oV6ENqFfzP0qqRo=; b=We6h0stYKID3X1r1dLqd3nxkXe8t+EeYNL2MK3QDe08wtKC86orDBcPGHvTpqVqD3t TubCimjw1yZmTSTUmxDhbecLXPn9U4V9lfEhki/uJqB9/z9Sw55ak7I5fZ6ZeMT1u0NC Vkeu7jGvYXd7IiTvnbNeLQKY6TZMkhJiCsTyrny7iX1rgNei6odocCgHifFzbRmXQztx AhPKxCuTFRF7MkUHH5k5gcpcV9yVdgKYDzGgZf+JtQIhyOhnXQ1I8WZVISTr0qVRWh8B 1uWhXzaze6QRf6nNw2hcKj5DSI4wLHJSCQQ14c/ab03J+wSVXdtqGsVExLXHndwxYLWn II6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=I9masRwd; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ht10-20020a170907608a00b007aa5e6c4b5bsi893525ejc.164.2022.10.28.21.52.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 21:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=I9masRwd; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10AE73858C2D for ; Sat, 29 Oct 2022 04:52:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10AE73858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667019169; bh=SOysNDHJXJJu2FZ7C2HvAv6LIsY5oV6ENqFfzP0qqRo=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=I9masRwdZvy4M0vnWHMdnGvu0HRlyPaAzsyu89Q435/KARBo/Zbce+W+jMxnvxE7Z 84ZMjNIqNErhmWTscfpJOKwROzsDVRuer728giuqpoM7q+SNHXzb0omAqx07CQuTjJ wZC44LQk4WC0fK9QS8PeuD/I6EAr2/cnlScqChww= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id A315F3858428 for ; Sat, 29 Oct 2022 04:52:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A315F3858428 Received: by mail-pg1-x52a.google.com with SMTP id h185so6473876pgc.10 for ; Fri, 28 Oct 2022 21:52:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SOysNDHJXJJu2FZ7C2HvAv6LIsY5oV6ENqFfzP0qqRo=; b=o6nlSukx/X3mZusldOEA0cDRjlIhcryDpBMktQdzpbt4WApLw32NVQ0zY+oVUL9IfI cwTzLT1/mPzmCkPKEITNbEZv/qaKr+KZQy0eBGq/iHl0HiKqgamy1rppTY78bLLvh7JC Fz5FS5ldC7pvtxETDCB/2jUHntIvuxdRYFwSWnjQJ8PI3nLoM6jmkx4imqkEG7B+aWd9 +zuwpBBxUMiJiUqCv7k0ldomCiFiZCEF0wP4/rvLQyn+LXvlYD9/BjZcDYs3/qvh/byD QN23JddQkhlxGuo0KneqRQ/v3u91TeblK9dKXF1lL7GcRp05HV5137vx65Fo5QNyEbUh uP3A== X-Gm-Message-State: ACrzQf1e1mrRsGlP93KjRpGPSPMSwdMHp4XeqCtym4rkMTjRDhgA5og6 SSMJcTSCWlF1cnnZPoVk/DcLnoQm/4E= X-Received: by 2002:a05:6a00:4008:b0:56c:ee89:d5a9 with SMTP id by8-20020a056a00400800b0056cee89d5a9mr2955752pfb.75.1667019143158; Fri, 28 Oct 2022 21:52:23 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e93b:3bfb:5587:694b]) by smtp.gmail.com with ESMTPSA id x11-20020a17090aa38b00b0020b7de675a4sm257045pjp.41.2022.10.28.21.52.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 21:52:22 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 773221140870; Sat, 29 Oct 2022 15:22:19 +1030 (ACDT) Date: Sat, 29 Oct 2022 15:22:19 +1030 To: binutils@sourceware.org Subject: NULL dereference read in som_write_object_contents Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747996295080183022?= X-GMAIL-MSGID: =?utf-8?q?1747996295080183022?= objcopy copy_object may omit the call to bfd_copy_private_bfd_data for various conditions deemed non-fatal, in which case obj_som_exec_data will be NULL for the output file. * som.c (som_finish_writing): Don't dereference NULL obj_som_exec_data. diff --git a/bfd/som.c b/bfd/som.c index b3a72e36ede..7a5ee35f0e2 100644 --- a/bfd/som.c +++ b/bfd/som.c @@ -4211,7 +4211,7 @@ som_finish_writing (bfd *abfd) /* Setting of the system_id has to happen very late now that copying of BFD private data happens *after* section contents are set. */ - if (abfd->flags & (EXEC_P | DYNAMIC)) + if ((abfd->flags & (EXEC_P | DYNAMIC)) && obj_som_exec_data (abfd)) obj_som_file_hdr (abfd)->system_id = obj_som_exec_data (abfd)->system_id; else if (bfd_get_mach (abfd) == pa20) obj_som_file_hdr (abfd)->system_id = CPU_PA_RISC2_0; @@ -4242,7 +4242,8 @@ som_finish_writing (bfd *abfd) exec_header = obj_som_exec_hdr (abfd); exec_header->exec_entry = bfd_get_start_address (abfd); - exec_header->exec_flags = obj_som_exec_data (abfd)->exec_flags; + if (obj_som_exec_data (abfd)) + exec_header->exec_flags = obj_som_exec_data (abfd)->exec_flags; /* Oh joys. Ram some of the BSS data into the DATA section to be compatible with how the hp linker makes objects