From patchwork Tue Feb 21 05:53:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 59768 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1693417wrn; Mon, 20 Feb 2023 21:54:12 -0800 (PST) X-Google-Smtp-Source: AK7set/iodyKYPuzUnwReT6rVJ04AYK1bv5EOabqm1wBq7PvTwzwQkeWHABzXjOxZ0/fyLtBZyht X-Received: by 2002:a17:907:3f8e:b0:8b1:77bf:3beb with SMTP id hr14-20020a1709073f8e00b008b177bf3bebmr23242537ejc.24.1676958852450; Mon, 20 Feb 2023 21:54:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676958852; cv=none; d=google.com; s=arc-20160816; b=cq/nOH+f/C6YsFpZHSVk9Pryhpb3F+T0LLFrfUylnAsnYKe3xBYnn4w7WMSmcfl4WG CgbwibFSHuM2a2zQbwIj5+F25eUvD9gLjgAT+AvYlgSYazUJXq6EK4aO6Jr395+n6AXZ X1tTdRNvPfdmC0VrXZ7o9Omp2RtUNCNhppQTIYgz9mCYrzh6Caifdqo3LoITZtb6W5yj KNL0I2EFmOa22oydxZZwBsLww058BXNmFZ9s6G7z3JQ2Ya+U6fSPB+uKt6HuRhlWeBy9 9pV6KSiNt9MRsSoaYfYX475Y7MR11ixwQn2Pgclywq9un73HWi6tIMK5sTn7+gz9gdjN V1pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=UAJ47cF4NbiiTwty51vaMQOV32FVwV+1ZKrMZiFg3h8=; b=skoaJblnltfPmtC0wpzwBXiIhJfkhrZKl+5K/im2rdEggPTEpdCd57qmE92rZmE8TO v+yi1PFCinwAX/+LqVx24bw5+zUz4j0+VJYJa9ny1bpdVToKVPuj2guKYZwGEkStVPFF BRQ1Y+0q9HhyllJTZU+hDTfh/Oyu2y0BP0cn2AfVQM5jUvWWHZ4Tr/oM6SifIuhcAwUP oWAK1KIIjADON7IEUx0h+p0VZu99SkLaX8kpXa3TZfa5VaJmuiz910al0pZeqMVK7xHp r00vgCyVmkbudVAODB4OwIxid3AEznd4fLzUgC/4sY/YMC8YM4eC3mYnnTczHi78NUzR IKHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=AG0Rc7fV; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ex18-20020a170907955200b008d6385c40c4si4037519ejc.696.2023.02.20.21.54.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 21:54:12 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=AG0Rc7fV; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67C38385800C for ; Tue, 21 Feb 2023 05:54:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67C38385800C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676958849; bh=UAJ47cF4NbiiTwty51vaMQOV32FVwV+1ZKrMZiFg3h8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=AG0Rc7fVlwMRxKckFTg0J7ni20+jp0BhHgqvmIbkJUJDOKo5h2n+/P/orRfF6mdgT FaRFf3tqzfSpgnUTCbDt69cLuRlmLIt3xeGaKFoBVw1SonUEq51IS/MPORliD/DSEN ZBdLqiFZ0BRgLs0KFaiBbiSI26//1huAV0Cl5edA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id DD3953858C3A for ; Tue, 21 Feb 2023 05:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD3953858C3A Received: by mail-pj1-x1029.google.com with SMTP id x34so131948pjj.0 for ; Mon, 20 Feb 2023 21:54:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UAJ47cF4NbiiTwty51vaMQOV32FVwV+1ZKrMZiFg3h8=; b=CmaQkgZxVFdk5Ea1kU5EVf5G0lCMk2inM/LUvAfpptTJEMIXB8QGNBSujNYluFfZIn VMqmgKCMBfMtnXBNdacvPa70sgXK3bTvYmbnRUX3Kh/Knb6hdBSU+Y+ArW1dUPWL6w2E wVHbqREBJZ/Kp6Y2Dn7lE92jT5FUrb4J1jilOpiC1w7UjKGFvXtvf8jWuQuc5pqniMm7 fuwnEVxXneNUgaLVR2HW9kjJb8iG7Ejs+gRQrPQmGqNSjzZ1OYDX+mkFFPFXdxVkUWom PHGKEFYijn+mqUYX99Jg3srrIviVVYj+7/FPCuTApBQneRMXl1xT6HyqXkM88DwPUFyv rCyw== X-Gm-Message-State: AO0yUKWGY2EvH3B7SxnZNQq/LsSuFMIErTB6UKHQ8QbeFmL+XH8ORHoP +vPZZbvbNbaN/Mnqti25QFL+gVs1JXE= X-Received: by 2002:a17:902:fb4d:b0:196:8a80:4d91 with SMTP id lf13-20020a170902fb4d00b001968a804d91mr3676982plb.35.1676958840760; Mon, 20 Feb 2023 21:54:00 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id x5-20020a170902ea8500b0019c32968271sm2491345plb.11.2023.02.20.21.54.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 21:54:00 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 172751142D4E; Tue, 21 Feb 2023 16:23:58 +1030 (ACDT) Date: Tue, 21 Feb 2023 16:23:58 +1030 To: binutils@sourceware.org Subject: Both FAIL and PASS "check sections 2"? Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758418805615935401?= X-GMAIL-MSGID: =?utf-8?q?1758418805615935401?= * testsuite/ld-checks/checks.exp (check sections 2): Don't continue on with rest of test past first fail. diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp index a0b6ade00c3..52b4088637a 100644 --- a/ld/testsuite/ld-checks/checks.exp +++ b/ld/testsuite/ld-checks/checks.exp @@ -61,17 +61,18 @@ proc section_check {} { # Make sure that we got some output from the linker if [string match "" $exec_output] then { fail $test - } + } else { - # Now remove our expected error message - regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output + # Now remove our expected error message + regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output - # And check to see if anything else, (unexpected) was left - if [string match "" $exec_output] then { - pass $test - } else { - verbose -log "Unexpected linker message(s): $exec_output" - fail $test + # And check to see if anything else, (unexpected) was left + if [string match "" $exec_output] then { + pass $test + } else { + verbose -log "Unexpected linker message(s): $exec_output" + fail $test + } } }