diff mbox series

Both FAIL and PASS "check sections 2"?

Message ID Y/RcdkYHUwcnAETA@squeak.grove.modra.org
State Repeat Merge
Headers
Series Both FAIL and PASS "check sections 2"? |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra Feb. 21, 2023, 5:53 a.m. UTC 
  * testsuite/ld-checks/checks.exp (check sections 2): Don't
	continue on with rest of test past first fail.
diff mbox series

Patch

diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp
index a0b6ade00c3..52b4088637a 100644
--- a/ld/testsuite/ld-checks/checks.exp
+++ b/ld/testsuite/ld-checks/checks.exp
@@ -61,17 +61,18 @@  proc section_check {} {
     # Make sure that we got some output from the linker
     if [string match "" $exec_output] then {
 	fail $test
-    }
+    } else {
 
-    # Now remove our expected error message
-    regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
+	# Now remove our expected error message
+	regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
 
-    # And check to see if anything else, (unexpected) was left
-    if [string match "" $exec_output] then {
-	pass $test
-    } else {
-	verbose -log "Unexpected linker message(s): $exec_output"
-	fail $test
+	# And check to see if anything else, (unexpected) was left
+	if [string match "" $exec_output] then {
+	    pass $test
+	} else {
+	    verbose -log "Unexpected linker message(s): $exec_output"
+	    fail $test
+	}
     }
 }