From patchwork Wed Feb 8 23:13:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 54634 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3741067wrn; Wed, 8 Feb 2023 15:14:23 -0800 (PST) X-Google-Smtp-Source: AK7set9j9j1QvFJmVrlpak/W9GaMUhqThXovuhFSqMBUvk9Bnd7io/PCgiq5zIHflkq6mTuopXv8 X-Received: by 2002:a05:6402:380e:b0:4a3:43c1:843e with SMTP id es14-20020a056402380e00b004a343c1843emr4895502edb.18.1675898063513; Wed, 08 Feb 2023 15:14:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675898063; cv=none; d=google.com; s=arc-20160816; b=Jfe4u+GpJi0sz4Ss9KHcNE/YW1xFZR3/F44gIim3rK12wVzQNIPzPflI0N7dHxyGnP ctuROMR9P1vx0GfvhUJLFkDO1izpGm+Shxqj9aF1CKIHtpGo6z9zuSmLnnhEk5rHZy9k 81DT9Svd/fYrR1rhvC7jkkY0dHFW0OZEcRfyGJsvKo6JiOpJvs49DtYjvI/xLayOdg2P 5pxj1fkID4WCpRZaFEeecr+3WWHZR/Cnwcw/tFoeXt7svxOWGyEG6v1wrsaaESui31ql Gwl/UdXDDXxCsr6tvxIcCSzWctWQUNNmvRoJb9a4xEpUoUZYbGXT4Pvqcd+Unt5Tub5z h+Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=9ruWzWkr3DMOTewMoR4gC38tMUM4sSQXw3OcNztOigI=; b=api4x73rtiqLbR8iEDAkFKy8MiTaBIRkC0bq2zpGS8A1YG0fEgG16ieO3wXUisXmna hIu525cIYcVDM5Qdu+RnuHwON4Om4X5gDzGSu1GiqduHGaotkh0e1RVACO4oNWCuK62g I2sV8cK0v9F5WFEHRJ668ztLaukaCZtjRU9eoXKNuGtQ0UFyl8CzQPEcs7olQhRYAwPQ a/Wk1jlo/MrtOK6FcLLGOJBK/UtqEdNHoAyqpyE1tIjgxoYsMYE65RhdQWvtC69FBBtn MXTadilrHGtZtvSFQUZDlxTax8b/9N/dnbs8du+SOT1Z1LRfv/6CaoE+kuie4af2GzYc CWMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xUrsAOCu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t6-20020a05640203c600b004a08a5f9e49si73932edw.48.2023.02.08.15.14.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:14:23 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xUrsAOCu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48C0F3858C53 for ; Wed, 8 Feb 2023 23:14:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48C0F3858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675898062; bh=9ruWzWkr3DMOTewMoR4gC38tMUM4sSQXw3OcNztOigI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=xUrsAOCuOyGk4f6qp+nZ+UkC0lZvfCqHEVXOK94tDA6N0fU+hdHLiS5rRlDeBxu12 xODnLuonh6/7ZkY4yob3QKRMZWsaXoKQql0weo1vIQlvfKDnIYyPZMHQkF76ITNuJC rLSEx/S55+QdYjTnOf+YHszrePROm8KaNAG2fpj8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id ADC693858413 for ; Wed, 8 Feb 2023 23:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADC693858413 Received: by mail-pj1-x1035.google.com with SMTP id pj3so422196pjb.1 for ; Wed, 08 Feb 2023 15:13:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9ruWzWkr3DMOTewMoR4gC38tMUM4sSQXw3OcNztOigI=; b=A2az3QXfvoB/iVRAQwAI4UJbgeKVrAoQG/K9kP8ONKx7uMngXqcyPg6p92MmXZPHPL y6PCDXi9R83nWi79nLp44dX0erJDsg3ph9mxsDP8glq1jzcCTn+lK9vrWQ67LaTqRq/I 0+B/Lm11jwkdCOdxbMvPKs4aZO3EiqFYUSglKa8db7qGtECV/o1j1+0Z67e5g5nMi8Ve dULvdNzF7kiuTrJTmeH8Sh7FQoR0owmX5eAV5+2EfhzZwGwQGjBftd+QMhtrz87Kz2/8 lYHLHo02lpLbEivKPfPcoLDt8zYzT6mz+ENwtqs901LWfjQn8q/SZHsTTKmfuN+77dON +8Hg== X-Gm-Message-State: AO0yUKUv8+cw9+6LYzuSAD3G4/nxZ0yeuqsRY3J4OdWVDkpQHh9Tu6Pi sM2lKwvHksNasV2y58HzJk0/3wKbpQM= X-Received: by 2002:a17:902:cad1:b0:198:fb56:1a0a with SMTP id y17-20020a170902cad100b00198fb561a0amr5948599pld.34.1675898018573; Wed, 08 Feb 2023 15:13:38 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id w22-20020a170902d71600b00174c1855cd9sm7230591ply.267.2023.02.08.15.13.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:13:38 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2C53C1142D73; Thu, 9 Feb 2023 09:43:36 +1030 (ACDT) Date: Thu, 9 Feb 2023 09:43:36 +1030 To: binutils@sourceware.org Subject: Memory leak in bfd_init_section_compress_status Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757306487848949451?= X-GMAIL-MSGID: =?utf-8?q?1757306487848949451?= * compress.c (bfd_init_section_compress_status): Free uncompressed_buffer on error return. diff --git a/bfd/compress.c b/bfd/compress.c index 2cf8a6c28c9..2a402c3f65c 100644 --- a/bfd/compress.c +++ b/bfd/compress.c @@ -1083,7 +1083,10 @@ bfd_init_section_compress_status (bfd *abfd, sec_ptr sec) if (!bfd_get_section_contents (abfd, sec, uncompressed_buffer, 0, uncompressed_size)) - return false; + { + free (uncompressed_buffer); + return false; + } sec->contents = uncompressed_buffer; if (bfd_compress_section_contents (abfd, sec) == 0)