Memory leak in bfd_init_section_compress_status

Message ID Y+QsoGbCT4Ei4rlW@squeak.grove.modra.org
State Repeat Merge
Headers
Series Memory leak in bfd_init_section_compress_status |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra Feb. 8, 2023, 11:13 p.m. UTC
  * compress.c (bfd_init_section_compress_status): Free
	uncompressed_buffer on error return.
  

Patch

diff --git a/bfd/compress.c b/bfd/compress.c
index 2cf8a6c28c9..2a402c3f65c 100644
--- a/bfd/compress.c
+++ b/bfd/compress.c
@@ -1083,7 +1083,10 @@  bfd_init_section_compress_status (bfd *abfd, sec_ptr sec)
 
   if (!bfd_get_section_contents (abfd, sec, uncompressed_buffer,
 				 0, uncompressed_size))
-    return false;
+    {
+      free (uncompressed_buffer);
+      return false;
+    }
 
   sec->contents = uncompressed_buffer;
   if (bfd_compress_section_contents (abfd, sec) == 0)