From patchwork Fri Sep 30 11:41:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Frager, Neal via Binutils" X-Patchwork-Id: 1590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp439121wrs; Fri, 30 Sep 2022 04:42:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Td/D6eF2nj/Xc/XJyc1+pVkFeBz0rT6g2YgV80s0QEFQRtxhLW92TwMu2LWunQ6/PIxHd X-Received: by 2002:a50:9510:0:b0:453:dded:60e with SMTP id u16-20020a509510000000b00453dded060emr7513334eda.204.1664538128232; Fri, 30 Sep 2022 04:42:08 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id cz28-20020a0564021cbc00b0045515cd902esi1701786edb.149.2022.09.30.04.42.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 04:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=kJ5p2Ril; arc=fail (body hash mismatch); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 281B5385483F for ; Fri, 30 Sep 2022 11:42:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 281B5385483F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664538126; bh=kWZu03Ax/zEVKGnB+bKPjLV5tmXBAIbVAkLG4hVa11o=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=kJ5p2Ril1HjZ8d56MtcvJbj/3CBQfSzbosQZ2dHID96c/fU39cOPwTyLDknGk3jW5 ykFsJp5p7rNFJ2zkbFWYuWcoCPhQzXISqEEW6uCQoOevhJMCX4UdDk0ulH/iXQMTzM 0Cgq/FIo8yTXLsG2wD9fqrgvWgmjGrkqsG23piYA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by sourceware.org (Postfix) with ESMTPS id 7A22E385C402 for ; Fri, 30 Sep 2022 11:41:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A22E385C402 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFtqY7/g9ENK+d/UGokCuAE/T8KcYnRpzaYaBH0v1V3pcU8LOUszV9/Dcv9++kKsjz9QWtJu1d54Eobsurp68hmXA3tDA58TNIiJlyoF/q5MgO6/DXdlbmKgfarBkvuPMehA5bCBkzvdH0zFdkrNej2d6b27gyN9H4rgw0R+rZeFQ41ErJgYf0Urxm4/Lo68qTqlSqWHGbTLKvFbTuwas6HGaqrfghpdVzD9wD9SKDYPikjmXFj2CFcaa/3xaeQxupYJ6w/EZ60M7K5t4WPD7VQ49hNmxMYP35JILNC7XJxreAVudixdyVyy04JdlNs93l9i5nCpWWSp3UibWjCj9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/n7QPfbZOCbF0emg+bvQT5HouReMWwtDCIcfjFPsyL8=; b=KxxytoXCOP2iGu6q1Qtce/ITMbzDoB/Sbw9txXQUhxTTr2iRNL/ZOfAV7/A9TTcv7+VccN5+h8OlsEj5SFaX5Q6FoirrNMl17DX7+gEWM3bHJH+7XGhffkvveG1lFdF31HGpna/bZ2TRHpPkyDHxkvGsgcOUNGSZ6elwVlnuC9Dktfk1Viu092AyaQvGn7wfF6llwA1OG0VYZXXoE3WCJaY/LvLXTH0ws7oxkOoLZ2JbEqjfIbFUKVRLQrarmbvazk9/q1fUJHJjqh9LyFh8jTVuTVax0dZY5IvbmysVMcr7otq1fZlYIHeGI73NSxBY8piJ3j6EVer9hFjxQqHgzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB4219.namprd12.prod.outlook.com (2603:10b6:5:217::14) by LV2PR12MB5752.namprd12.prod.outlook.com (2603:10b6:408:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Fri, 30 Sep 2022 11:41:37 +0000 Received: from DM6PR12MB4219.namprd12.prod.outlook.com ([fe80::2ba:ca85:382c:9e67]) by DM6PR12MB4219.namprd12.prod.outlook.com ([fe80::2ba:ca85:382c:9e67%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:41:37 +0000 To: "Potharla, Rupesh via Binutils" Subject: [PATCH V2] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5. Thread-Topic: [PATCH V2] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5. Thread-Index: AdjUwRNkpgWkySb5SZCB3QeEM2Q5Ug== Date: Fri, 30 Sep 2022 11:41:37 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-30T11:37:40Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=903dbf1d-7a27-44a9-b81e-38393ccb00a1; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-09-30T11:41:21Z msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid: 79044499-56df-4871-807f-44dc169bbb4d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB4219:EE_|LV2PR12MB5752:EE_ x-ms-office365-filtering-correlation-id: a4f5f13f-6410-4c5e-4b43-08daa2d8bc00 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hz6BzPD2zQmSD4BcQHdX/E2t16D2mWH21PvuMA7eaUj3nOHxhDJaDyNyW7LSNKEl3wJryzVIpBrsFDG7DQSL91bDGTcnwLygDfQgQbCdOp95i5mlUndYRI89iZrVnprr88npLSymm3Bm2lmQuxgvDspSMeC4P+RXT7zFhdG8w/ceqAyfLWyReDcnsFPjqUAttPsPixbgLoBvijZg2y4R4ZJ1plergVplusGN/61ZhmKaJR6xcjbcFrL3ZePuIifrp/eHTzYy01E9vpAXngq1B4rotvEny78ls1EEz5ZbJWS6Dliq3BIAr35YoEZCuQqyKCWuNlOErqP5kdL3yQ2BJWh7ZwW8C8K8/L+kOe6+U1OF7t67XDlm13dsz14/VuEDl5J26o7sHI7NPRteZ/ZnaELHEaqPKe/GqkNhjzagU/yVwa1bbX7YuTLeJvRZvkZb4m7Z5JErcllklvjXHl7WbICgIsZZ2kXGQ+MVdhHEid6iTLFuAK6mfTWVUGPKdE/gSNCbzYj4McgFMZcmpTLi/Ursv8YoROZBRuVspr2XJjdMA4OmXWy3tN3tIhUMCWa0kqmxGz2BGVJjtwMtRh6ebVHMt1q7N33KM96REY2aFr1IapSo/Rd5IXfOE9pKGVCoMMCsBtmVOu0WbKIlF1pin/aSKj+zHUWaYVGbbYrZWdPG6+EHyvfN/aSJDYz551GC+cCecEGUsn059IArEfrHKPOWoJDe7MEw/W0N3k8ifHRdSXrU+NNxiYXVVoetz4hF+TG3d6dCkgJXD4fTU91KwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4219.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(451199015)(54906003)(316002)(6916009)(478600001)(4326008)(8676002)(41300700001)(64756008)(76116006)(66946007)(66556008)(66476007)(66446008)(33656002)(122000001)(38100700002)(83380400001)(9686003)(26005)(86362001)(4744005)(55016003)(38070700005)(6506007)(7696005)(5660300002)(52536014)(99936003)(2906002)(186003)(8936002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: zhwvrAyeequEKQFeDtRTudkfYJLpvXPCbyz4uals3UVWV6hn+KjTADSHFYAEvztad4GNE/591mk3O6QH13H7bogVwPH2650yld/oGycbyOZh3kaDNLwfv8bqht0XrQoYClC5D0uSe3a+qkEONtLcvZRwNjYskTp8ex9MV6/d4Qlyi06xCPIJ/tU/Ka7kDV59XSm/RxJL2hopKUwOwd9i79dePvB9f5Bl6b1q49huuqwJUddQHMWoLyBwNJpTMMF41UmaISRQAJ2LVnz0AVuIi9SDA1YSP+LMMWLp3iT3ODLVVoa75ioIsn50J24Ipdxh+clHi2QLAOnriWIoS+mXbHzFudDc+3oYDqFihLkCEh3FhyNXkN5xxoG3w8Yt2CfPByHtp3iLqjcfRfkWPZ6ru3YSoh5rir20Ex4FtbysdjBVPymg+hSfL2Sv8YNYKSPT58Y5TnxVzn4J8bBLPGJgQNZtblykFJm/VUm6lP+jqhPTgFD8VmBzBt0Efn9nsMw5If9R7rzMNHKI+ELBO8z8Ojc460Vz+0m8pfc4xOEaBfwkwU/3W9XjAQD/0hk1AH796mth+eBkyx+hcoe6QtRubg96OX6rjmJQh8OXiPhm2XABZ/cnrhMQ6b/f9jI1Zi9quCDF4zQxRL7viub21VM+QooA+VeB6Pnv8lGRfs7Am/aS7ew2iqKR0t/0ZWk4cKc35adEpKsVJrHbChK4bQzEARHCkjShyYFM7UyuQoBfvqaj0dZwSsTmLj4fuOyCa5LVCuL5xhHYgShKzh9RME8J4Uo04oHTKICsKYoeX5GGC8aSHlSZyU205/KQFkLBiNdATA5WVZ0gw1FJvYa8x4yVX6GfglpejzxotlLlqhxrVPamtg5fEgHZIVpPkDdXuXz6Rff663ryo0f5bSJFzD7o9J0HB6p8ZybIwzQqHyi6I2pv6IJcjAxPA7Oa4rrT/h1BnMdpVZE3Rvtq1E953GTyXXMmxPdK6FnLcvTxHwo14TU8ztMjMyYXyAGPwMwogkkbzrQxiahhdRQWYZ6ATQOL6uWMkA1XFW1tPg+lgpeD0GcGhIgouvMC7Pe/iTsZ9H1/tkEx3/6xLKMGeKVEL9Ir7bOAqCnggcum9zNTy0q6pufdMWTNei+G4isRmptaejysYtXn8CNiFouuFGNaU+qFUBuocbjciwJ/I31kL2W8rsZ6FxhydNnFfxEOOEBTKGc7LZBuPyl9OYEcwveoLNrW/78CSbDl0o5VR6FAW6d779Ewmo9exFeTPZzgHbA0vaJFCEvmtHxizvFUdNRSHCnijF8AsDeqtLRZr+ZQJoAlxW3FFzykNMUpAE+vk5UW/Ddhu1l/akEn2owDOvs4xk14J/9TEpVfDpR065aWyWXMAVyHrOtSVqqvGGgfeJUqfM42izfCXA1dYvA9hYcz3KhJyD/5QwkBE3OD4HGppsnlZsm+fXraEENCbePfNVvZHKWowNN1ze6yK00/KDFXAK2dNxhN4BnrBhmzGhOT/ETBbiqA5UcEiYK4hSsPI5UuVt0TUxeg1853P8M2rXzTZwQ8YHPoPsX4dU3jcv4rswtVxa1PrIA9c/beywC6eqrjLD+7 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4219.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f5f13f-6410-4c5e-4b43-08daa2d8bc00 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 11:41:37.6961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n6LPEo3Z0cjaMV+N60rRjuIoABJtnyI9Txx6bn5rRg196WX8JsRi135aByiBhq22szl3uMO5JRrKVkT8omu72w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5752 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Potharla, Rupesh via Binutils" From: "Frager, Neal via Binutils" Reply-To: "Potharla, Rupesh" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Kumar N, Bhuvanendra" Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745394732073144018?= X-GMAIL-MSGID: =?utf-8?q?1745394732073144018?= [AMD Official Use Only - General] Hi, Can you review the code changes and send in your comments/suggestions? Patch Inline: ----------------- Skip dwo_id for split dwarf. * dwarf2.c (parse_comp_unit): Skip DWO_id for DW_UT_skeleton. --- bfd/dwarf2.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 2.25.1 Regards, Rupesh P diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c index 4a6a1e40185..364cc9a6480 100644 --- a/bfd/dwarf2.c +++ b/bfd/dwarf2.c @@ -4411,13 +4411,23 @@ parse_comp_unit (struct dwarf2_debug *stash, if (version < 5) addr_size = read_1_byte (abfd, &info_ptr, end_ptr); - if (unit_type == DW_UT_type) + switch (unit_type) { + case DW_UT_type: /* Skip type signature. */ info_ptr += 8; /* Skip type offset. */ info_ptr += offset_size; + break; + + case DW_UT_skeleton: + /* Skip DWO_id field. */ + info_ptr += 8; + break; + + default: + break; } if (addr_size > sizeof (bfd_vma))