From patchwork Thu Apr 27 23:35:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleg Tolmatcev X-Patchwork-Id: 88408 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp591662vqo; Thu, 27 Apr 2023 16:35:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4eJoeo+rXexY8Rf4sZdbrRpZjTsMAp/RDoSLkqst2s1kMmasq6e/QuQ9PtXzbTIW1TLRjf X-Received: by 2002:a50:ee8c:0:b0:506:c238:4067 with SMTP id f12-20020a50ee8c000000b00506c2384067mr3467926edr.8.1682638545282; Thu, 27 Apr 2023 16:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682638545; cv=none; d=google.com; s=arc-20160816; b=ylz/WkCr0NyMmp571F0uXstVVua8BKHLa4GqVROXE5yMRwTg4Xc9SbLaIQQQJBfFI6 tkbwCH4RJuBxguIGFJGSY0MZx5Kh8eoHqvcVAY4XZj6/rFDrg33exC6LSxUTJxs44NjG iAqpW0iBj48nHlm7EULpBqYt5zaPpEItfAtYls2UEvJAaLZzeI95LMRvqTLWeFcPUfLT Sfe9KY6IKUtxtjk92i49c0cg6y1/UtOyds9qWiRqNy0Qm5verFR5IO2t1wrrw5c+/PYp NcIyNqaJayjy946RtktC7DPINezYpIH5BuHguwDNeTPld61+22SBFlK5u0n+JMbkL6GL RZIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:to:subject :message-id:date:mime-version:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=funJ36YV43bUzKfF3W8f+bUr2PMQaU3lpMSUNwhvIt8=; b=P9G1OPFsNp6iULeKyytiPvKJBmuGFnEe1Oo6OWB088mEV0ngMPqezK+g1i4JBps7Xx sh4WPNwlZjlK1kkHTcHzftLqPFQd827taplCT8yuXvnBA3tiwZsmiX7ovUKlbaIthkzb gH84EUcKMt/lj0CN8HZq1e/qack6o0HBbw43TC2Drrd2+Z9IEK154+NbQE3Xremyu3Cy 2c1bujNDouixIoqOLvvgZdu/a2POIiEdQ3K03XwZ8KUzVfF24RKiqZ77zyWuA7TRJDIj iI6o6zjVTpVLcnpOpTqAAu0pFZjRF+tj2JC//aUiHdV7WdNEyMWKbOghBc6QkcsguuTN H28A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mSzGrzG9; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id f14-20020a50ee8e000000b005083e031fd0si14436831edr.321.2023.04.27.16.35.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 16:35:45 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mSzGrzG9; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D91CE3858C27 for ; Thu, 27 Apr 2023 23:35:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D91CE3858C27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682638543; bh=funJ36YV43bUzKfF3W8f+bUr2PMQaU3lpMSUNwhvIt8=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mSzGrzG9J033M8f4/SOPfXWfpHjmXY8fKB7ZKdGiOOrhtVlqsbBYtefCwhvluiEWC GAsVHZNNt0ybpkNfCk1daDv3oGK0j9z5VvsY6/tbz+WUBdVlJMU4ARea66PZThtywJ yhy1gOOK0rPpxYKGlcSSf7Saae8xhqJI4S15RJAc= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id E64583858D37 for ; Thu, 27 Apr 2023 23:35:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E64583858D37 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f00d3f98deso6808987e87.0 for ; Thu, 27 Apr 2023 16:35:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682638533; x=1685230533; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wskpFExTKrY+dPQmE6KH5+Zlu0IGJgPAJSbRveLiyo4=; b=LmmakDLx4440ugufQeNSreQ0LF9VbDHI3I197yKqoGlsw60+lAGwaizfmuAIpMtwgx ZDiB71RmUx5gQrR0Bs4ohpu/Aiw8/nnkT//jbdq0zdzzqdmypcc9y+pKQ2XSrrgP0Y/n Zi5fClcyQOm41yYtskX5TRZ+l9hof9e/TocVECOvZQaqk5BUpTfxLw/oS9q3knuiZo7y d6EZDcFa+uUe7WdfEOnN9GjAKMu9gC2XWAPWmTwm6nqIjN2FaW0xYChlwOxffEhI+tZb ZgIE6bBpcTFjxAQzAxrpUNDWTmLwdEEMv0fDPWv7g3lgFxGPs7fbr9RuvPT11sqsQ4Mf I8Og== X-Gm-Message-State: AC+VfDwFivL9xczfhyqxvErnY0IfDq08ogG8L/jfQBqQctGT9qERagMV Zof5rhkWqXaWQPaoSQ44mzAOUaq++36FvG8b6ixxLN8w X-Received: by 2002:a05:6512:904:b0:4ef:ef9f:f24f with SMTP id e4-20020a056512090400b004efef9ff24fmr1007509lft.13.1682638532600; Thu, 27 Apr 2023 16:35:32 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 28 Apr 2023 01:35:20 +0200 Message-ID: Subject: [PATCH] make ar faster To: binutils@sourceware.org X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Oleg Tolmatcev via Binutils From: Oleg Tolmatcev Reply-To: Oleg Tolmatcev Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764374395071711201?= X-GMAIL-MSGID: =?utf-8?q?1764374395071711201?= Hello all, this patch makes ar faster by increasing the buffer size from 8 KB to 8 MB. --- bfd/archive.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bfd/archive.c b/bfd/archive.c index 4cc2f7c9..d179bcd3 100644 --- a/bfd/archive.c +++ b/bfd/archive.c @@ -2209,11 +2209,14 @@ _bfd_write_archive_contents (bfd *arch) } } + char *buffer = bfd_malloc (DEFAULT_BUFFERSIZE * 1024); + if (buffer == NULL) + return false; + for (current = arch->archive_head; current != NULL; current = current->archive_next) { - char buffer[DEFAULT_BUFFERSIZE]; bfd_size_type remaining = arelt_size (current); /* Write ar header. */ @@ -2226,7 +2229,7 @@ _bfd_write_archive_contents (bfd *arch) while (remaining) { - size_t amt = DEFAULT_BUFFERSIZE; + size_t amt = DEFAULT_BUFFERSIZE * 1024; if (amt > remaining) amt = remaining; @@ -2245,6 +2248,8 @@ _bfd_write_archive_contents (bfd *arch) } } + free (buffer); + if (makemap && hasobjects) { /* Verify the timestamp in the archive file. If it would not be