From patchwork Tue Jun 20 11:43:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Branislav Brzak X-Patchwork-Id: 110435 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3599997vqr; Tue, 20 Jun 2023 04:43:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fXh0xRNX6NzlSUet7Gqb1GvHqnJ0EmqtPjTj0w1v3LRWfBGsiGPQtHmqcQLAtQbiwq/5M X-Received: by 2002:a05:6402:345a:b0:51a:482d:9ddd with SMTP id l26-20020a056402345a00b0051a482d9dddmr5975969edc.21.1687261399382; Tue, 20 Jun 2023 04:43:19 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v14-20020aa7d80e000000b0051843d33c1asi1028303edq.143.2023.06.20.04.43.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 04:43:19 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@syrmia.com header.s=selector1 header.b=T1Q3iBEI; arc=fail (body hash mismatch); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D03883858C53 for ; Tue, 20 Jun 2023 11:43:17 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2139.outbound.protection.outlook.com [40.107.21.139]) by sourceware.org (Postfix) with ESMTPS id 2EAD73858D1E for ; Tue, 20 Jun 2023 11:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EAD73858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=heNrhm1W3t3Ia1ihilfy7mgdW6NQBB9lfDYOnQZAs8+fz7daRnIRDP7m8PBXiy46OReLAA2ku0ctxT1i9UNwValAvsCDRkcqIztJjSu4xaxZfIZZWm8NhGx8SsagUvwpKn+pLSnThG7wZqSlL1TcFv+LGxUSvK8+D6fIIeg0K3qj82ONfq0m7zW8n35OX7+PdolR0efvnAcZvGZKoBgozBjZDdxclEwARdQ4U24VgFfInW22wTQu0y22a/68DqTgE6rKQVDsxl52ZDEBi8cMjwlOkzC1f+HXTUP/CkxnF/25F/jSgqNcBa1UaMyIqOWbPhbBSajnE+FFZnWYvOt+Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h7ARF/rSAaJBsjM1ODPI7CqaFgH0AkNOuH/3msxljeM=; b=HluSPQUaTMa9IDrVWs/jOPdV7EJ1OBXZL/EY5KIgmqgT3l9DieN9Au5woUrMn3iu3Jao9IbfcPa6wyzdz4fVoDWuIQdhQoiLjiSLb2c9azHBuDysR2x1fU6Tij/ITCW9lu4HHSGoR3/0m1BSGR1bgwjSryzzIQILacepJeMp2DZzw+bzRvhNzhcxwJ8hd+nmCw86JRovgx+MdtGZTrFH6DkBZ65NGOrjbAm9tiifV9xIgV9kZGV7eP/+/vk1o2sLvl1LexFo1WJ/IBeogllPCQvvtsTkjDmwuGk68lBPhZzU9xKZVjEiLQ2Syp2gUCYhYIgODpTNU81dP8V/8cShwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h7ARF/rSAaJBsjM1ODPI7CqaFgH0AkNOuH/3msxljeM=; b=T1Q3iBEIKaNjJq0V2eYUOdsDwGwEUI89saxrQo1tBrA1xDAuV2p1ej0c8V9dLcgX8r1DTaquoSRTxSuhgSdiaAy9uRjqWcDVDbj5AJdCAlTzDnFKUF/8DUy8Au58TcwliaLXCBWMg8jzu+s4lYpVqDDc4XhOOX5DXUajIR+HmqI= Received: from AM6PR03MB4984.eurprd03.prod.outlook.com (2603:10a6:20b:88::29) by AM7PR03MB6166.eurprd03.prod.outlook.com (2603:10a6:20b:142::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 11:43:08 +0000 Received: from AM6PR03MB4984.eurprd03.prod.outlook.com ([fe80::17fc:8700:8177:b3d7]) by AM6PR03MB4984.eurprd03.prod.outlook.com ([fe80::17fc:8700:8177:b3d7%4]) with mapi id 15.20.6500.029; Tue, 20 Jun 2023 11:43:07 +0000 From: Branislav Brzak To: "binutils@sourceware.org" CC: Dragoslav Sicarov , Djordje Todorovic Subject: [PATCH 0/1] riscv: Ensure LE instruction fetching Thread-Topic: [PATCH 0/1] riscv: Ensure LE instruction fetching Thread-Index: AQHZo2ws0sALiG2JmES9FozG5tvgQA== Date: Tue, 20 Jun 2023 11:43:07 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR03MB4984:EE_|AM7PR03MB6166:EE_ x-ms-office365-filtering-correlation-id: a5a053ce-238e-474a-38ac-08db71838469 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ia27eJl5kutkUKB6lWZNjCstyoERQeRSak6ixwaY1ey+zgrNJyhRNCufWiyJIwTSQhOhUfAbO4a1yGabrtHkuzTshZUHG3xlq01S99GXXIFz2iVpfR/Pt+9ZhlQF5gnl3zJvcBz9n/SHp4IcytrOLOgTeMOuRlM1uJQZfvtkPtDo5zk7R5Izs/RpIl4XnuxQDAXaKV0Al67t/LAfwo+iTPfgcG9k4TuaSMZAm7WdhR0qjdnYQICyCoSHcGPYfxNLmNr6is1LeREtVsOw8IUDcIZoDZsy+pvJwyWuT46SBy3G21mPTM686rZyU8mUWC68pnxrEYiuQtzXDAWWNsEcR+J98alxa53hhGM47wYKb0cGkKc8mJOc/2wJwEobBJX1eiIEyk2DPKKFiB0dzU8fISne4YY6EeqxRiz2yMSFYVuQlRWkQMGtvne+Y5w5T7L8wUrCqmCB8lKXIb+8ZmZeQiCZ355DCLKO+Um34TsJpqLfw98hElXJfmlUxMAr3lX90xWD/e/X2WCd25XLYLcilkoLw7C/ruHV/A0jqdyCu5PjQJDLTWixZ/Qnl7hH1G0l9neu9IcrYaeT2q5LqTfuwZ60MEx4zvUfRi+ohQ5cc3s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR03MB4984.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(366004)(39830400003)(136003)(376002)(396003)(451199021)(5660300002)(52536014)(33656002)(66946007)(316002)(4326008)(91956017)(76116006)(66476007)(66556008)(64756008)(66446008)(6916009)(4744005)(2906002)(19627405001)(8936002)(8676002)(41300700001)(55016003)(7696005)(54906003)(38070700005)(86362001)(478600001)(38100700002)(122000001)(107886003)(186003)(26005)(9686003)(6506007)(99936003)(71200400001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?HRqjRcJCUjHdIIlf3PPplxH?= =?iso-8859-1?q?lBgTzjPqTd9HnmE/66wPG5Bh6CDbgRaW/+lgcKqqpuUQoNqkwigXqwtUEF/v?= =?iso-8859-1?q?8RtK5hs4Q+D5KYrMbg8L9tIAEBBfpQnBXgr86Cp9yyEmNJX3uPT0A9X4Ma5E?= =?iso-8859-1?q?T/KJSoIVcBR4YxYZ8LZH1zm7oIeUddo+PxWkSq4DlIOjBzinaVvJzeB2f54h?= =?iso-8859-1?q?Bxl2K4K9CJ0YJJtexR91mVF7lnV3te8bpKJkL0qecfYomgC4qiaz3O0LdUtw?= =?iso-8859-1?q?zFlKTjVITbbzsEwT41R/gYlkhZP6Qsx04HPF7/Vit9z5S9aRNfbQXo4ZzQQn?= =?iso-8859-1?q?FJsVfn5XDJNV/2ZbC81gLjcAwnP72ifgSpjgmrONcdZx9q2ZbkPkNY335HuL?= =?iso-8859-1?q?P53iFnHmHN4TxPFNRV9LJplAt5s6ll+WESiLVTFjyrzKinBPQYmtuV2xW9ul?= =?iso-8859-1?q?k0NckReyyOfZNDk10StHO8Gz+yIr60e2PGASKHmXKU/ovayGHiQX/3GGWMti?= =?iso-8859-1?q?haUyJZ6HXMwJUftNxQt4A4OU6h0w+RRMXQgw9TfY2jqMRPpa2ycA7V2rnUk8?= =?iso-8859-1?q?PeaP7vkIyRhccpUYNrBimV37f5B9Y9W3T2Ygl1J/VAPCa5jmBSkGA+tUnRAo?= =?iso-8859-1?q?Pe3vGA8TWRWBsCnTZmrYtJcYQf9cn5I4GA0gP0s1A6xbiNS5GWP/gwI4743h?= =?iso-8859-1?q?cw1n2ir5NKynmcUkUGEtPyHtqDYLaI/d0AM35JxDWJMefV9/g4VNcT75tPPX?= =?iso-8859-1?q?oBLbAu0MQamMoxryF4JJ+ZjcS6jrKHhlSEIA8FlbSnqYEfvi2LIfot4H+a8S?= =?iso-8859-1?q?yUAV7MVC73b3CATiYLz1KSL5YDik4S5UQFY/CRFNcls9+7i/uST2yMD2LfYI?= =?iso-8859-1?q?7APgOSQUHfnMmPmn5TeDPxLSO6eqGuKOqHv0RuWLBVyqOKQtc3jPK2kLYvrW?= =?iso-8859-1?q?EwVIt+9uyY2UbsHPAv86IcbBgQ52202zZ+4B1TA+4te0AYDGWxzWBahr25tB?= =?iso-8859-1?q?2s2JZcvOVGzb+TkaQdum19g9aH5g8D2Ec3ZL2rpyqLhcKwloSe4WplieZ0FH?= =?iso-8859-1?q?8/y2keH0bsAz6X5qMzffl+l30Prunh/0KHLPFelWWJ+Y0RN07KdlHb6EiYhp?= =?iso-8859-1?q?uw0/9xMl8Sn0NFW+MkebhfTkwNJ7vFU5HonlXdfspQ4VIiAAx6i2rmW/d0QC?= =?iso-8859-1?q?LWChxSk/e7T1RCjeJgC2eWv/crwlolStEka7nvoEVx6pYiXKbDPE8z0A/bcP?= =?iso-8859-1?q?PgEo5qgA59c0WBPynCsTuU+zmFHFwDS43EbIi9kCW92AHbxqY7OiDN0zwg8r?= =?iso-8859-1?q?szkICGxr1EL/mlYmzBWqO+Kf6VoC66pgK+97tNeitU1vXWQPUbjl3I9JRFUN?= =?iso-8859-1?q?/MXCxgw3SPvd/4DyxxyN58tjl7dXEdfBI/GScZ+3N9nBU4BiL6RK1uE2aFS9?= =?iso-8859-1?q?exemVw7YdizXPjKLrWD9TW+mzH7cU98Gjy9gOZV54JhURqewK2xqWHBUr19V?= =?iso-8859-1?q?IzqRiCBa2UfYu8mwXC2A84rdtWYPymD0wCm2uof8Bilcr4+8PtwOwJ0OiEzL?= =?iso-8859-1?q?xO/q1x3apewcGVxyz2a9meKZhraVM4z/0SYzCuumy+fO+baLJ3KJ8usjY6Y8?= =?iso-8859-1?q?5f67NyUTYuxKxRd9E?= MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR03MB4984.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5a053ce-238e-474a-38ac-08db71838469 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 11:43:07.8598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tLlyETX/WkUVrtm8DFlf32qfuwBf4WwHijScxN/N7Sc450CcuzqsWfgOCoh9rL78EyACQMC55uyShzB7dFtqjHPJRc/W0x96LMkKkV4xm30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6166 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769221808864207335?= X-GMAIL-MSGID: =?utf-8?q?1769221808864207335?= Currently riscv gdb code looks at arch byte order when fetching instructions. This works when the target is LE, but on BE arch it will byte swap the instruction, while the riscv spec defines all instructions are LE encoded regardless of system memory endianess. Branislav Brzak (1): gdb/riscv: Ensure LE instruction fetching gdb/riscv-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 391716c3138697a0b8a1836c1ffdb44b1b6b9da4 Mon Sep 17 00:00:00 2001 From: Branislav Brzak Date: Tue, 20 Jun 2023 13:20:40 +0200 Subject: [PATCH] * riscv-tdep.c (riscv_insn::fetch_instruction): Always fetch instructions as LE --- gdb/riscv-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index 500279e1ae9..b4f98089937 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -1812,7 +1812,7 @@ ULONGEST riscv_insn::fetch_instruction (struct gdbarch *gdbarch, CORE_ADDR addr, int *len) { - enum bfd_endian byte_order = gdbarch_byte_order_for_code (gdbarch); + enum bfd_endian byte_order = BFD_ENDIAN_LITTLE; gdb_byte buf[RISCV_MAX_INSN_LEN]; int instlen, status; -- 2.34.1