diff mbox series

[2/2] RISC-V: Add "lp64e" ABI support

Message ID 9a77cb454bd020e0010fc02543e3d3ae7564eb79.1690251857.git.research_trasio@irq.a4lg.com
State Accepted
Headers
Series RISC-V: Add ratified 'E' base ISA support with draft ABIs |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Tsukasa OI July 25, 2023, 2:26 a.m. UTC 
  From: Tsukasa OI <research_trasio@irq.a4lg.com>

Since RV32E and RV64E are now ratified, this commit prepares the ABI
support for LP64E (LP64 with reduced GPRs).

gas/ChangeLog:

	* config/tc-riscv.c (riscv_set_abi_by_arch): Update the error
	message.  (md_parse_option): Accept "lp64e".
	* doc/c-riscv.texi: Update the documentation to allow "lp64e".
	* testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l:
	Change error message.
	* testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l: Likewise.
	* testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l: Likewise.
---
 gas/config/tc-riscv.c                           | 4 +++-
 gas/doc/c-riscv.texi                            | 5 ++---
 gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l | 2 +-
 gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l | 2 +-
 gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l | 2 +-
 5 files changed, 8 insertions(+), 7 deletions(-)

Comments

Kito Cheng July 25, 2023, 1:27 p.m. UTC | #1 
Reviewed-by: Kito Cheng <kito.cheng@sifive.com>

On Tue, Jul 25, 2023 at 10:27 AM Tsukasa OI
<research_trasio@irq.a4lg.com> wrote:
>
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> Since RV32E and RV64E are now ratified, this commit prepares the ABI
> support for LP64E (LP64 with reduced GPRs).
>
> gas/ChangeLog:
>
>         * config/tc-riscv.c (riscv_set_abi_by_arch): Update the error
>         message.  (md_parse_option): Accept "lp64e".
>         * doc/c-riscv.texi: Update the documentation to allow "lp64e".
>         * testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l:
>         Change error message.
>         * testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l: Likewise.
>         * testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l: Likewise.
> ---
>  gas/config/tc-riscv.c                           | 4 +++-
>  gas/doc/c-riscv.texi                            | 5 ++---
>  gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l | 2 +-
>  gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l | 2 +-
>  gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l | 2 +-
>  5 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index 80c14a3cd221..963f9967638f 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -384,7 +384,7 @@ riscv_set_abi_by_arch (void)
>         as_bad ("%d-bit ABI not yet supported on %d-bit ISA", abi_xlen, xlen);
>
>        if (riscv_subset_supports (&riscv_rps_as, "e") && !rve_abi)
> -       as_bad ("only the ilp32e ABI is supported for e extension");
> +       as_bad ("only ilp32e/lp64e ABI are supported for e extension");
>
>        if (float_abi == FLOAT_ABI_SINGLE
>           && !riscv_subset_supports (&riscv_rps_as, "f"))
> @@ -3897,6 +3897,8 @@ md_parse_option (int c, const char *arg)
>         riscv_set_abi (32, FLOAT_ABI_QUAD, false);
>        else if (strcmp (arg, "lp64") == 0)
>         riscv_set_abi (64, FLOAT_ABI_SOFT, false);
> +      else if (strcmp (arg, "lp64e") == 0)
> +       riscv_set_abi (64, FLOAT_ABI_SOFT, true);
>        else if (strcmp (arg, "lp64f") == 0)
>         riscv_set_abi (64, FLOAT_ABI_SINGLE, false);
>        else if (strcmp (arg, "lp64d") == 0)
> diff --git a/gas/doc/c-riscv.texi b/gas/doc/c-riscv.texi
> index b175ba0a7293..e7fdbfa22afb 100644
> --- a/gas/doc/c-riscv.texi
> +++ b/gas/doc/c-riscv.texi
> @@ -65,9 +65,8 @@ aren't set, then assembler will check the default configure setting
>  @item -mabi=ABI
>  Selects the ABI, which is either "ilp32" or "lp64", optionally followed
>  by "f", "d", or "q" to indicate single-precision, double-precision, or
> -quad-precision floating-point calling convention, or none to indicate
> -the soft-float calling convention.  Also, "ilp32" can optionally be followed
> -by "e" to indicate the RVE ABI, which is always soft-float.
> +quad-precision floating-point calling convention, or none or "e" to indicate
> +the soft-float calling convention ("e" indicates a soft-float RVE ABI).
>
>  @cindex @samp{-mrelax} option, RISC-V
>  @item -mrelax
> diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
> index f7306cb24d20..419a01d5d53a 100644
> --- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
> +++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
> @@ -1,4 +1,4 @@
>  .*Assembler messages:
>  .*Error: can't have 64-bit ABI on 32-bit ISA
> -.*Error: only the ilp32e ABI is supported for e extension
> +.*Error: only ilp32e/lp64e ABI are supported for e extension
>  .*Error: ilp32d/lp64d ABI can't be used when d extension isn't supported
> diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
> index 706690ac9c64..7b2fcda8d685 100644
> --- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
> +++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
> @@ -1,4 +1,4 @@
>  .*Assembler messages:
>  .*Error: can't have 64-bit ABI on 32-bit ISA
> -.*Error: only the ilp32e ABI is supported for e extension
> +.*Error: only ilp32e/lp64e ABI are supported for e extension
>  .*Error: ilp32f/lp64f ABI can't be used when f extension isn't supported
> diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
> index ab64b1546f63..a06e9ea1aa93 100644
> --- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
> +++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
> @@ -1,4 +1,4 @@
>  .*Assembler messages:
>  .*Error: can't have 64-bit ABI on 32-bit ISA
> -.*Error: only the ilp32e ABI is supported for e extension
> +.*Error: only ilp32e/lp64e ABI are supported for e extension
>  .*Error: ilp32q/lp64q ABI can't be used when q extension isn't supported
> --
> 2.41.0
>
diff mbox series

Patch

diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
index 80c14a3cd221..963f9967638f 100644
--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -384,7 +384,7 @@  riscv_set_abi_by_arch (void)
 	as_bad ("%d-bit ABI not yet supported on %d-bit ISA", abi_xlen, xlen);
 
       if (riscv_subset_supports (&riscv_rps_as, "e") && !rve_abi)
-	as_bad ("only the ilp32e ABI is supported for e extension");
+	as_bad ("only ilp32e/lp64e ABI are supported for e extension");
 
       if (float_abi == FLOAT_ABI_SINGLE
 	  && !riscv_subset_supports (&riscv_rps_as, "f"))
@@ -3897,6 +3897,8 @@  md_parse_option (int c, const char *arg)
 	riscv_set_abi (32, FLOAT_ABI_QUAD, false);
       else if (strcmp (arg, "lp64") == 0)
 	riscv_set_abi (64, FLOAT_ABI_SOFT, false);
+      else if (strcmp (arg, "lp64e") == 0)
+	riscv_set_abi (64, FLOAT_ABI_SOFT, true);
       else if (strcmp (arg, "lp64f") == 0)
 	riscv_set_abi (64, FLOAT_ABI_SINGLE, false);
       else if (strcmp (arg, "lp64d") == 0)
diff --git a/gas/doc/c-riscv.texi b/gas/doc/c-riscv.texi
index b175ba0a7293..e7fdbfa22afb 100644
--- a/gas/doc/c-riscv.texi
+++ b/gas/doc/c-riscv.texi
@@ -65,9 +65,8 @@  aren't set, then assembler will check the default configure setting
 @item -mabi=ABI
 Selects the ABI, which is either "ilp32" or "lp64", optionally followed
 by "f", "d", or "q" to indicate single-precision, double-precision, or
-quad-precision floating-point calling convention, or none to indicate
-the soft-float calling convention.  Also, "ilp32" can optionally be followed
-by "e" to indicate the RVE ABI, which is always soft-float.
+quad-precision floating-point calling convention, or none or "e" to indicate
+the soft-float calling convention ("e" indicates a soft-float RVE ABI).
 
 @cindex @samp{-mrelax} option, RISC-V
 @item -mrelax
diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
index f7306cb24d20..419a01d5d53a 100644
--- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
+++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64d.l
@@ -1,4 +1,4 @@ 
 .*Assembler messages:
 .*Error: can't have 64-bit ABI on 32-bit ISA
-.*Error: only the ilp32e ABI is supported for e extension
+.*Error: only ilp32e/lp64e ABI are supported for e extension
 .*Error: ilp32d/lp64d ABI can't be used when d extension isn't supported
diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
index 706690ac9c64..7b2fcda8d685 100644
--- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
+++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64f.l
@@ -1,4 +1,4 @@ 
 .*Assembler messages:
 .*Error: can't have 64-bit ABI on 32-bit ISA
-.*Error: only the ilp32e ABI is supported for e extension
+.*Error: only ilp32e/lp64e ABI are supported for e extension
 .*Error: ilp32f/lp64f ABI can't be used when f extension isn't supported
diff --git a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
index ab64b1546f63..a06e9ea1aa93 100644
--- a/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
+++ b/gas/testsuite/gas/riscv/mabi-fail-rv32e-lp64q.l
@@ -1,4 +1,4 @@ 
 .*Assembler messages:
 .*Error: can't have 64-bit ABI on 32-bit ISA
-.*Error: only the ilp32e ABI is supported for e extension
+.*Error: only ilp32e/lp64e ABI are supported for e extension
 .*Error: ilp32q/lp64q ABI can't be used when q extension isn't supported