diff mbox series

[4/8] x86: absorb allocation in i386-gen

Message ID 8f43bf06-9323-8838-bcdc-bfbf9a850ae2@suse.com
State Unresolved
Headers
Series x86: mnemonic and register string literals |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Jan Beulich Jan. 13, 2023, 11:07 a.m. UTC 
  When generating the mnemonic string table we already set up an
identifier for the following entry in a number of cases. Re-use that on
the next loop iteration rather than re-doing allocation and conversion.
---
Could also be folded directly into "x86: re-use insn mnemonic strings as
much as possible"; separate for now to keep the earlier change a little
more simple.
diff mbox series

Patch

--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -1750,13 +1750,15 @@  process_i386_opcodes (FILE *table)
   fprintf (table, "const char i386_mnemonics[] =\n");
   fprintf (fp, "\nextern const char i386_mnemonics[];\n\n");
 
+  str = NULL;
   for (l = strlen (opcode_array[offs = j = 0]->name); j < i; j++)
     {
       const char *next = NULL;
       size_t l1 = j + 1 < i ? strlen(next = opcode_array[j + 1]->name) : 0;
 
       name = opcode_array[j]->name;
-      str = mkident (name);
+      if (str == NULL)
+	str = mkident (name);
       if (l < l1 && !strcmp(name, next + l1 - l))
 	{
 	  fprintf (fp, "#define MN_%s ", str);
@@ -1769,8 +1771,9 @@  process_i386_opcodes (FILE *table)
 	  fprintf (table, "  \"\\0\"\"%s\"\n", name);
 	  fprintf (fp, "#define MN_%s %#x\n", str, offs + 1);
 	  offs += strlen (name) + 1;
+	  free (str);
+	  str = NULL;
 	}
-      free (str);
       l = l1;
     }