commit: Add expected failures for some bfin linker tests
Checks
Commit Message
Hi Guys,
I am checking in the patch below to add some expected failure markers
for BFIN linker tests. This is mostly for tests that fail in the same
way as they do for the FRV target - with a warning message about being
unable to put fixups into a read-only section.
Cheers
Nick
ld/ChangeLog
2023-06-14 Nick Clifton <nickc@redhat.com>
* testsuite/ld-elf/comm-data5.d: Expect to fail for bfin.
* testsuite/ld-elf/ehdr_start-missing.d: Likewise.
* testsuite/ld-elf/ehdr_start-userdef.d: Likewise.
* testsuite/ld-elf/ehdr_start-weak.d: Likewise.
* testsuite/ld-elf/ehdr_start.d: Likewise.
* testsuite/ld-elf/pr19539.d: Likewise.
* testsuite/ld-elf/pr22269a.d: Likewise.
* testsuite/ld-elf/pr22269b.d: Likewise.
* testsuite/ld-elf/pr23591.d: Likewise.
* testsuite/ld-elf/pr23648.d: Likewise.
* testsuite/ld-misc/defsym1.d: Likewise.
* testsuite/ld-scripts/empty-address-1.d: Likewise.
* testsuite/ld-scripts/empty-address-2a.d: Likewise.
* testsuite/ld-scripts/empty-address-2b.d: Likewise.
* testsuite/ld-scripts/pr14962-2.d: Likewise.
* testsuite/ld-scripts/pr14962.d: Likewise.
* testsuite/ld-scripts/weak.exp: Likewise.
@@ -1,6 +1,6 @@
#source: comm-data5.s
#ld:
#readelf: -r
-#xfail: frv-*-*linux* lm32-*-linux*
+#xfail: bfin-*-*linux* frv-*-*linux* lm32-*-linux*
There are no relocations in this file.
@@ -2,3 +2,4 @@
#ld: -e _start -T ehdr_start-missing.t --no-dynamic-linker
#error: .*: undefined reference to `__ehdr_start'
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
+#xfail: bfin-*-*
@@ -2,7 +2,7 @@
#ld: -e _start -T ehdr_start-userdef.t
#readelf: -Ws
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
-#xfail: frv-*-*
+#xfail: bfin-*-* frv-*-*
#...
Symbol table '\.symtab' contains [0-9]+ entries:
@@ -2,7 +2,7 @@
#ld: -e _start -T ehdr_start-missing.t --no-dynamic-linker
#nm: -n
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
-#xfail: frv-*-*
+#xfail: bfin-*-* frv-*-*
#failif
#...
@@ -2,7 +2,7 @@
#ld: -e _start --build-id
#nm: -n
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
-#xfail: frv-*-* lm32-*-*
+#xfail: bfin-*-* frv-*-* lm32-*-*
#...
[0-9a-f]*000 [Adrt] __ehdr_start
@@ -4,7 +4,8 @@
#readelf : --dyn-syms --wide
#warning: .*: creating DT_TEXTREL in a PIE
#target: *-*-linux* *-*-gnu* *-*-solaris* arm*-*-uclinuxfdpiceabi
-#xfail: ![check_pie_support]
+# The BFIN target always generates a relocation.
+#xfail: ![check_pie_support] || bfin-*-*
Symbol table '\.dynsym' contains [0-9]+ entr(y|ies):
#pass
@@ -3,7 +3,8 @@
#ld: -pie --no-dynamic-linker
#readelf: -r -x .data.rel.ro
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
-#xfail: ![check_pie_support]
+# The BFIN target always generates a relocation.
+#xfail: ![check_pie_support] || bfin-*-*
There are no relocations in this file.
@@ -4,7 +4,8 @@
#readelf: -r -x .data.rel.ro
#warning: -z dynamic-undefined-weak ignored
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
-#xfail: ![check_pie_support]
+# The BFIN target always generates a relocation.
+#xfail: ![check_pie_support] || bfin-*-*
There are no relocations in this file.
@@ -3,8 +3,8 @@
#source: pr23591c.s
#ld: -e _start
#readelf: -sW
-#xfail: frv-*-linux* lm32-*-linux*
-# frv-linux and lm32-linux fail with complaints about emitting dynamic
+#xfail: bfin-*-*linux* frv-*-linux* lm32-*-linux*
+# bfin, frv, and lm32 fail with complaints about emitting dynamic
# relocations in read-only sections.
#...
@@ -1,6 +1,6 @@
#ld: --gc-sections -T pr23648.t
#target: [check_gc_sections_available]
-#xfail: frv-*-linux* lm32-*-linux*
+#xfail: bfin-*-*linux* frv-*-linux* lm32-*-linux*
#nm: -B
#failif
@@ -1,7 +1,7 @@
#ld: -e 0 --defsym foo=1 tmpdir/start.o tmpdir/libfoo.a
#nm: -B
#source: dummy.s
-#xfail: frv-*-linux*
+#xfail: bfin-*-*linux* frv-*-linux*
# Check that --defsym works on archive.
#failif
@@ -1,6 +1,6 @@
#ld: -T empty-address-1.t
#nm: -n
-#xfail: frv-*-*linux*
+#xfail: bfin-*-*linux* frv-*-*linux*
#...
0+0 [AT] _start
#...
@@ -1,7 +1,7 @@
#source: empty-address-2.s
#ld: -Ttext 0x0000000 -Tdata 0x200 -T empty-address-2a.t
#nm: -n
-#xfail: frv-*-*linux* riscv64*-*-* tic54x-*-*
+#xfail: bfin-*-*linux* frv-*-*linux* riscv64*-*-* tic54x-*-*
#...
0+0 T _start
#...
@@ -1,7 +1,7 @@
#source: empty-address-2.s
#ld: -Ttext 0x0000000 -Tdata 0x200 -T empty-address-2b.t
#nm: -n
-#xfail: frv-*-*linux* riscv64*-*-* tic54x-*-*
+#xfail: bfin-*-*linux* frv-*-*linux* riscv64*-*-* tic54x-*-*
#...
0+0 T _start
#...
@@ -1,7 +1,7 @@
#ld: -T pr14962-2.t
#source: pr14962a.s
#nm: -n
-#xfail: frv-*-*linux*
+#xfail: bfin-*-*linux* frv-*-*linux*
#...
0+2000 [AT] _start
@@ -5,6 +5,8 @@
#xfail: mmix-knuth-mmixware
# The reference to x would normally generate a cross-reference error
# but the linker script converts x to absolute to avoid the error.
+#xfail: bfin-*-*linux*
+# The bfin backend complains about attempting to put a fixup into a read-only section.
#...
0+2000 A x
@@ -26,6 +26,7 @@ set testname "weak symbols"
if { [is_elf_format] } {
# hppa64 is incredibly broken
setup_xfail hppa64-*-*
+ setup_xfail bfin-*-*
} elseif { [is_pecoff_format] } {
# Weak symbols are broken for most PE targets.
if { ![istarget aarch64-*-*]