From patchwork Tue Dec 12 10:02:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 177216 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7618034vqy; Tue, 12 Dec 2023 02:02:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeOWnfD8ee8Lb3VE0zBseWWGEwMcJj+0mWgtokJ+1JTb5laeQ1MN9ywpYwLw5O4jacPhab X-Received: by 2002:ac8:7d89:0:b0:425:4043:8d40 with SMTP id c9-20020ac87d89000000b0042540438d40mr5341958qtd.91.1702375368713; Tue, 12 Dec 2023 02:02:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702375368; cv=pass; d=google.com; s=arc-20160816; b=KtcwJD3ysiRBKFXtLRF+rTxoj9bLa2jNlqYh7Z36PhO4tYh4FkZHsvpSkRkI5BSwwk g4os93mmZAtxlfW0Fpn8p0DKdbMnD6f8QYqiYou3fr/E6/gqGJNfD31zOUNCKYEgvEhO sDD2oNssToSnzxC7rAjnrg+Sc0mpoDC2m0TyhUzS4EAL6Na+ZR+HHBOGGsMyPrB0QAB2 stlTQrlgtUElD0bSITTC7QHWhzesc3ogyi6UdmxUptljxAomPRnwXjxUWWjatarFCOzi MaYE5nuxikTc26xKN/IlBkdCYElthaQmv3F0AbJN6Sbu8wE75G6Ho1vhXfm55VEwpT0q OxBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :subject:to:from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=pH1TABUuME8SRxqCZHTS3uc3Sz+HEYHPCMuakQN0+K0=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=tvpCXkbYj1lOfoihOD0lY6YTFFb27580gStrMMRqHo04ytWhv/D6oQj5y0Y01T9e9F hHKzYXKS6J213UQwPqmBmQTZht6zO/c3XMSsltegMLfUHvSLceFJt/E8GtLZEF+pwd5E +V8DyUkxUxFpwzjJS3dULSVsM+HzRB513AymoMdI1cVCIbz/H2NEWodC8EITFa57kwAW R7xALjs8hWwVh0e1aOHJ2ywgXEYNQsSkvCDYByAj+HvhtDwb1TW1us46vzvm4syYJ0kT ewcqZRX+mxal3gnLV5ubLq6zSFsMEF9Bdg3Qdb5p+G/9w4dzqJTTsgMM+vuWj7cONCWB UKAQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XmfUJEmw; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id cc24-20020a05622a411800b00423e91f2f2csi11275820qtb.74.2023.12.12.02.02.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 02:02:48 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XmfUJEmw; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 777633857C5A for ; Tue, 12 Dec 2023 10:02:48 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8B5A93858C78 for ; Tue, 12 Dec 2023 10:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B5A93858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B5A93858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702375364; cv=none; b=spBd174hcaI6y6y3DYpze5GBcqj+29PmmcDJVdjLBcdHLRydYG/Qa/Jyf9VvpNvqyfOPD4QtHJJWQYQAif5TGwWsnU4uWVh7//NOCMC4ym3WSVpnWfLm1iTeM5Mrhh3FJAyVOaMTrr+4+OYHc3eFSTsLvlohJjueNJl7lzzzlds= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702375364; c=relaxed/simple; bh=VH+SFLl5FqHgkv0f6CI0Oq4UJCdrU07BmLzLyWZ65+8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dm1hrI/nDHn1pqOno9Ppjo/nv70YuzIkkDAskC+lHrvJVFeNsqaQe3ppZliVE20l5WIfyBJVenwDjIX7/i2vt+Vahlos7nvCeJD1SzrETNQ4tV0OjI0X612vaY0wd4i9/RDBy5sL/xNAv85y8jy3RYGMal+/OgJQwCv4P2iDWlw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702375363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=pH1TABUuME8SRxqCZHTS3uc3Sz+HEYHPCMuakQN0+K0=; b=XmfUJEmwLRmsZU2CZP3t0G5TWb55iDsj5YmQMIzswwu55ckzTqIaDsKXT33JVjIJG80UY3 KIv6f4Z5NZWZjeibCGRg8VCJArtqAB4/8+8xwoBAqdHuXM976LlrIvBLnGCzbbrcbkBDyN /KlkRjACQQ44Wsv2+DARUoeQBjyaw1g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-u4qrLKmdO_izN1rCc_W3tA-1; Tue, 12 Dec 2023 05:02:41 -0500 X-MC-Unique: u4qrLKmdO_izN1rCc_W3tA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6CF64285F992 for ; Tue, 12 Dec 2023 10:02:41 +0000 (UTC) Received: from prancer.redhat.com (unknown [10.42.28.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1883A492BE6 for ; Tue, 12 Dec 2023 10:02:40 +0000 (UTC) From: Nick Clifton To: binutils@sourceware.org Subject: Commit: Fix whitespace snafu in tc-riscv.c Date: Tue, 12 Dec 2023 10:02:39 +0000 Message-ID: <87edfroi0w.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785069954370069790 X-GMAIL-MSGID: 1785069954370069790 Hi Guys I am applying the patch below in order to fix this compile time warning/error message: gas/config/tc-riscv.c: In function 'md_apply_fix': gas/config/tc-riscv.c:4364:11: error: this 'if' clause does not guard... [-Werror=misleading-indentation] 4364 | if (!riscv_record_pcrel_fixup (riscv_pcrel_hi_fixup_hash, | ^~ gas/config/tc-riscv.c:4370:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 4370 | bfd_putl32 (bfd_getl32 (buf) | ^~~~~~~~~~ Cheers Nick diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c index a46a6a4ec48..b902c6ba2c1 100644 --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -4367,11 +4367,11 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED) target)) as_warn (_("too many pcrel_hi")); - bfd_putl32 (bfd_getl32 (buf) - | ENCODE_UTYPE_IMM (RISCV_CONST_HIGH_PART (value)), - buf); - if (!riscv_opts.relax) - fixP->fx_done = 1; + bfd_putl32 (bfd_getl32 (buf) + | ENCODE_UTYPE_IMM (RISCV_CONST_HIGH_PART (value)), + buf); + if (!riscv_opts.relax) + fixP->fx_done = 1; } relaxable = true; break;