From patchwork Wed Sep 27 15:49:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 145431 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2723207vqu; Wed, 27 Sep 2023 08:52:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGe7+P+sClhQHk+Y5/NtAaOKiLAju+SEGzGLcbCv+ahQTN104yWc9zH4b2Z8VeluLuSjByH X-Received: by 2002:aa7:db91:0:b0:52a:1c3c:2ecc with SMTP id u17-20020aa7db91000000b0052a1c3c2eccmr2299960edt.25.1695829946731; Wed, 27 Sep 2023 08:52:26 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id r26-20020aa7da1a000000b0052a3d03c783si13764388eds.192.2023.09.27.08.52.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 08:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=MwFWai6V; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8DC873861932 for ; Wed, 27 Sep 2023 15:49:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DC873861932 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695829784; bh=YyguB7J0ryVRE2gRXCs194zCCAM/fDdkH1opqUfkZsU=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MwFWai6VYITPeF99Q4gX5eFuReEGjwCY8eI7nrH5zDhdZGEGzSSxUKvS9Q9JXOlIx DBngP7fQaRNILPNjcKH9N8gmMjbPIMtHXRY+Qy4po/kJ1YdmST54RnVU8gQJkIBx+K uzCldfCFIJMxi1Z/cOu579ahwJRfX66j3wQNp+1k= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2074.outbound.protection.outlook.com [40.107.13.74]) by sourceware.org (Postfix) with ESMTPS id 93CE738618C5 for ; Wed, 27 Sep 2023 15:49:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93CE738618C5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lAU4ShRv3qzUjQIzCLIFlNL5Bgn2Oba/4sWKtA49MB5RGk/4pe9cfH84sWc17AYmb1rc0qnjPvKnAxK+PYFzz7AatNYTibTZ4jo3nU0GIkAH9v+jzg2rN3+8KON5V7vcXt2pv+ykA060/27GXBGLeJeVsG+xlF/rOS5avYVFqtQw7EcBSWFAq9yvaM6hlOQpNzYXeNb35sw3iAWJgF+53NIl7JS6m2HwrBLE84Pz7z8xESoOjJgEosjkZnsOW7yb8MF8rq3iTK4Ods/YKtc1a5dRXsM/QTZJ1xzLUD/NAJDRoEEAfWtPVkuMvryTZXJBEOjCOV6SWDcICZP9PFLliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YyguB7J0ryVRE2gRXCs194zCCAM/fDdkH1opqUfkZsU=; b=h1vsg8WVtKvCs/Zo2b6wGJPMhqRkVDLKdcpFLZMeVx+646Xx5DGWZ3Po4ZaqNSs6E621bij0FjTGM5X/og62x5EYiMscr8MHJ0tKsIOIW2Zq9kTgTMhiw6GdhR9ckYKo063HxK9+HX4TG9nAGMQXt9106Zi2rrxOESTtgQ4JqtHs+zyjaJSwcjVBWwGQl/s6SwsAV0BhaQaqlk4zuJd2KlNAcQl3ay/nZtaHsEuFOxOWxk5EAnRhHrAJ8m/uqqFWnQn7+pVAI/VhJtZM8pLxgqTnnx76dV8j6a2Xtd/trM+EYvFxCq2JL4txfD11YwNxiZp0UmcGz069lqz11gKW0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by PAXPR04MB8942.eurprd04.prod.outlook.com (2603:10a6:102:20d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep 2023 15:49:32 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc%7]) with mapi id 15.20.6838.016; Wed, 27 Sep 2023 15:49:32 +0000 Message-ID: <829df523-3632-abd6-daaa-d42eaa82fe37@suse.com> Date: Wed, 27 Sep 2023 17:49:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 04/11] x86: don't use operand size override with NOP in 16-bit code Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <7ce54bc2-fef2-d2e4-21fd-202fdead0c20@suse.com> In-Reply-To: <7ce54bc2-fef2-d2e4-21fd-202fdead0c20@suse.com> X-ClientProxiedBy: FR4P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c8::6) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|PAXPR04MB8942:EE_ X-MS-Office365-Filtering-Correlation-Id: ab496f59-e2ca-4620-51c2-08dbbf715797 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BAXyqy1RI6uin5Q1TreXEUQ6iF6bxlrOxBDG3mL+XzPJA/30aSm8hOMnhInegq/GnKM0rAYwxAvHZxxRBpSiVZAUHgoK0/tgVUzFFQmYpPy3wqiVBbNP2zOZMiZZK8UbCqz6szSZDzAcjsF2DMPklttCHjfntB+fLYmxOXZNR4aTyUc4hT1mP8ZvGMAZOmuPsASg2RARoYJAUC+c7U0/PeQ0G9RJWeMa8NA/RNOvsFk8R4u/GPG9PoB9ey31p37StHeGIxLCXq6n1pcY/p0nh9wjUv5uUSe2hQiJ/OoXiZRF/6ehju11rNTBOW3tk0ToXZzMGQyTxw5p/i7S/Vd7Qgsj5//HMCMli6z/rFEELgQ7dK8iNicEgysWd97MGrNVgKEKEWBrFQyB7lgmkvih7/e8DVveyaUBRE7ExDvbODTEYexKd6rwPEoQqiM/8d3Z7lx/82EBkIW4Tqv6JmeeD2iRR1StzCPJL+Evb7Mh/9Tg0RSLkDA0GymTAigC1TKreZPFb34zzMGe8J0YqbGGWUjYaeGmOEzmpyf7Zz6lvs6XYdprKZ9mfTWitu4lYN74PhT5btV2wMI9PqTdRXHCbGmI8nuWyHIA8r1ywCQOuBwx5DW+363UctbuVdvG4QdSOBvS1ZGGMIWhpBqufpnF3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8788.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(346002)(376002)(136003)(366004)(230922051799003)(1800799009)(186009)(451199024)(36756003)(38100700002)(86362001)(31696002)(31686004)(4326008)(2616005)(2906002)(6916009)(66476007)(478600001)(41300700001)(66556008)(66946007)(5660300002)(6486002)(316002)(6506007)(6512007)(8676002)(26005)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?JeePZErMcO8SYmN+vGxnsHt9oGQR?= =?utf-8?q?0unmk5kNjEbt9poqKr/BY5YWNwaLJcXTFihohAqVHo4TZ0/rqZGi9kxusvMPAGNAu?= =?utf-8?q?3U//KMm2qHSUWnVSuRXrssx/ccH9FwzBpQYzZSDsgf+6eH4cpl7TXnBCW9rqJnt+X?= =?utf-8?q?yzeYd7mZfM99IGa4/2X4iDUWUI/E4KzcfNIb1nZ/DuBdEGOoFYSZ2YydGRgXg35kh?= =?utf-8?q?08iwAPfODzeeyE/iGa76YhvFAfNBJPtpSqK3iWgyt2ZvaF+iIbm5odaJYi+kjIUyD?= =?utf-8?q?37497FSuZbmVgleZTL+c2s2uCUtfSKNi4NAZMyeEfUQZiAHDo5XBT31kCKLEuRoYO?= =?utf-8?q?Au87LkP382DCDeHooriVJJqLR7IGkYSd6SVWMDiIjomk21AodhoYRlkeAXaQKyB1e?= =?utf-8?q?4CvsZ4NDziSrNqcNKfyb9RiWfVklyxttDWmSXiLg6jpNfLisJ/Am0lu+O+w5qB2sH?= =?utf-8?q?ZiLh1fOTnP3RrPqORS1/6sLL6FCeNLuAGvXralTe+4cJudifiligeff5MXECGLAeS?= =?utf-8?q?0c8TGPrPGvuhCZGAXY2CewrvJlIV1OprgbbV4aIBPvoDg7oHxLiAFOpoCuE5EaB2C?= =?utf-8?q?u8hHzdXjRtM6Or0E6GsnDcvGBzV5MxkWMNIXTVMRLlwSbh7zIrfmY8TLZq+0g8D/f?= =?utf-8?q?lx7qZSzakJ8W4gfSPBWJijkY5VWzR2iS2V0ziYSMNOB9NlZrhvmRiE1lGQUk/mHnU?= =?utf-8?q?U6VdWt66dNYaKVvXyUPicmOd/EyRnkMARIb+5S6Xbd4Jd4RsvumI5U2zppbhJ3SUP?= =?utf-8?q?iCMyLkgfNF1y2aLWvGQKKVnBZVp+DIV0A7jTnKokso5wsqSQHSIXS3tjU7YwOspXz?= =?utf-8?q?0jhxuvxGdWraV0eJ63Np7dYKNJGIMPkdezowqpegPrjrHyAxIyoQ0gRdalyGcx1Gw?= =?utf-8?q?TgSzpGmP03KTGwIXMP9WHUC5iB/X6AO1thUO1r7WyF23k07BBUjDNUPYRC7zTnIxG?= =?utf-8?q?WpzwtiEygWlnj2f3KQact+TEJV9kMgm38XDO+IqbqVgTdqgs5oAa2V8D86juBb6Vl?= =?utf-8?q?RKOrGN9bk3ld77gQ0C3Af6eDZ7LvMfWOmKB85pV+ZOUA07vsRLIGO6TaBCsoH2g/H?= =?utf-8?q?D0ancZV22mSv/u7//uEb+toS+fUPQX+ko4L4TXhQ6wtWfSdi3u3JwayCMXbHm7EKr?= =?utf-8?q?lcXy0XAfhYDYkv3jXhjeS9Ddb/Mhfh9iFpWoVIR0Kvy7WwoTkMR4y7iznIdyaI1jj?= =?utf-8?q?X5AnLoQt/ScA48qDp0BsAozNRYwDXA1N7wvE2hQ47Om674K88waoBgMMEOK2OoN2Y?= =?utf-8?q?bTmLi/0V48xfiX/idprlHIIHr3VQRrOVHmsTlRMrRK1+injEq0nIUjz5JBxiz6J6V?= =?utf-8?q?PAoXt3Nss7B1YVfCgZ1jjq2Zzp0uhR0iAB/ZBWEsQDYeU136fbdWcRGXS93pH93xS?= =?utf-8?q?seaSQa5iCeDkEeb6DNBduaYnp4az2KtQMJOJGTVTr1wkTOjCM0/LzE2y7RETA3REl?= =?utf-8?q?IwX+gJY6yVUUnWrrsTra44nUlf4/BMDao3rvoSviNV80K8CiPbUCpht3b/nHTFaa8?= =?utf-8?q?amkwNfL39WT5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab496f59-e2ca-4620-51c2-08dbbf715797 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 15:49:32.6143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3WVVE3Xzzroqwhf53/Ko1k2n8Pcy0JftaGY3J591LnQTm/Jp1iyg5rOIoYMkpw6J9w6rsLWeSQRjDyUiinaXDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8942 X-Spam-Status: No, score=-3026.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778206582040520112 X-GMAIL-MSGID: 1778206582040520112 Since we don't key the NOP selection to user-controlled properties, we may not use i386 features; otherwise we would violate a possible .arch directive restricting ISA to pre-386. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -1291,6 +1291,7 @@ static const unsigned char f64_7[] = #define f64_8 (f64_9 + 1) /* lea 0L(%rsi,%riz),%rsi */ static const unsigned char f64_9[] = {0x2e,0x48,0x8d,0xb4,0x26,0x00,0x00,0x00,0x00}; /* lea %cs:0L(%rsi,%riz),%rsi */ +#define f16_2 (f64_3 + 1) /* mov %si,%si */ static const unsigned char f16_3[] = {0x8d,0x74,0x00}; /* lea 0(%si),%si */ static const unsigned char f16_4[] = @@ -1311,7 +1312,7 @@ static const unsigned char *const f64_pa }; /* 16-bit NOPs patterns. */ static const unsigned char *const f16_patt[] = { - f32_1, f32_2, f16_3, f16_4 + f32_1, f16_2, f16_3, f16_4 }; /* nopl (%[re]ax) */ static const unsigned char alt_3[] = --- a/gas/testsuite/gas/i386/nop-2.d +++ b/gas/testsuite/gas/i386/nop-2.d @@ -26,7 +26,7 @@ Disassembly of section .text: +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si - +[a-f0-9]+: 66 90 xchg %eax,%eax + +[a-f0-9]+: 89 f6 mov %si,%si 0+26 : +[a-f0-9]+: eb 1c jmp 44 --- a/gas/testsuite/gas/i386/nops16-1.d +++ b/gas/testsuite/gas/i386/nops16-1.d @@ -55,7 +55,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+80 : [ ]*[a-f0-9]+: 90 nop @@ -118,7 +118,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+100 : [ ]*[a-f0-9]+: 90 nop @@ -193,7 +193,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+180 : [ ]*[a-f0-9]+: 90 nop @@ -280,7 +280,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+200 : [ ]*[a-f0-9]+: 90 nop @@ -315,7 +315,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: eb 0a jmp 240 [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+240 : [ ]*[a-f0-9]+: 90 nop @@ -336,7 +336,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 90 nop [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+260 : [ ]*[a-f0-9]+: 90 nop @@ -387,7 +387,7 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 90 nop [ ]*[a-f0-9]+: 90 nop [ ]*[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si 0+2a0 : [ ]*[a-f0-9]+: 90 nop @@ -450,5 +450,5 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 90 nop [ ]*[a-f0-9]+: 90 nop [ ]*[a-f0-9]+: 90 nop -[ ]*[a-f0-9]+: 66 90 xchg %eax,%eax +[ ]*[a-f0-9]+: 89 f6 mov %si,%si #pass --- a/gas/testsuite/gas/i386/x86-64-nop-2.d +++ b/gas/testsuite/gas/i386/x86-64-nop-2.d @@ -27,7 +27,7 @@ Disassembly of section .text: +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si +[a-f0-9]+: 8d b4 00 00 lea 0x0\(%si\),%si - +[a-f0-9]+: 66 90 xchg %eax,%eax + +[a-f0-9]+: 89 f6 mov %si,%si 0+26 : +[a-f0-9]+: eb 1c jmp 44