From patchwork Sat Oct 8 04:34:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 1831 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp608074wrs; Fri, 7 Oct 2022 21:35:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4edwliWo/Fm0aLVPEyC3T8wdwSd4C5JxlkRs5mwFTwGwWuO6T9fP8ebSUP5Rtl0QtwPagr X-Received: by 2002:a17:907:8688:b0:78b:eaa5:8a9d with SMTP id qa8-20020a170907868800b0078beaa58a9dmr6605251ejc.509.1665203730069; Fri, 07 Oct 2022 21:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665203730; cv=none; d=google.com; s=arc-20160816; b=FkNDhPG/NS1v6xOWU+yFrShYMq9QzDB1AWD7hHxHdEjh5P2zDp+spvJkUKHFbos03Z WHjjEj5wcYz4rMRxvtHAHswkDRU/dh0rMxSFPVZY2Hp2cLY9aY3uZyxTVwVAKCXXyLki Ew1/dnpbwyOgPNqmsDBOUmMA5ra+pajhIQ1PdKXcq/b+ODA0MiAnZANIxIOEmsIFFUHL eM4V+mrGA7Hq+GLMPGPjwObdxdGAfwt28frWhddA2qyQJeLOFrOFokX7ZP5DhPUUyouz uSvZV9YBkUY65biTS5aeaG41elp+dhws+rsn3PpOukXdDg1ClpoPNRW8P6RpNOawJJGP d8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=z6I+cWU1H2yp2dH2ZfkDKmoLtNptWcbRIWPdSaqbhRg=; b=HKQG6dT+26ZfPtObF8hZGAfJMCBs2rtrLn1U2ldWUslbL29S2/WXTBlYi1BFVlzSR2 DWR2UoBebBSM8VTMOi8rw4qLyzbSoz8/QKp0PQR5xSvAHf2qDNS7PBXTLQEI4BZr4rcO K4WPKcTsKnupxuPj4PW1iV0/F5eGntQld7DSLuTLs2ocEHOGs6RsQJ76rH/1mrYVkRxr Rg8k/8qRPBNNLA0/2s0jsQrqdkVkg8/VkifKUrQ2zamb3KI+dxOtZPeZrqON6tAeOWbK c3PW+hodesgZ2dL0TYVAYNwP7vCAn9TeV4r5EovjFDsc0qEqsIkh/PidWgAzLC/gLZyH 1blQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=HX8F8JZ2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m6-20020a50d7c6000000b004483a12fba9si3724835edj.210.2022.10.07.21.35.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 21:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=HX8F8JZ2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C144395B46B for ; Sat, 8 Oct 2022 04:35:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C144395B46B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665203710; bh=z6I+cWU1H2yp2dH2ZfkDKmoLtNptWcbRIWPdSaqbhRg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HX8F8JZ215Pxi5VTBNGFCqNKulDNgKDqMD61TQFjeAJfrmBP7UPTkFsN1GG337J0z KhyJT1cfkeDlpJywplaAX1A+C2dFzA3k5vVbi8jiygCYHO8+u05esanHbkta20cbbC Xt7fYelCCkmJblXNo8dx1sRlc1vuqrMSYrWH+wzw= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 7599B38A8161 for ; Sat, 8 Oct 2022 04:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7599B38A8161 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id CA578300089; Sat, 8 Oct 2022 04:35:00 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Subject: [PATCH 3/5] opcodes/riscv-dis.c: Use bool type whenever possible Date: Sat, 8 Oct 2022 04:34:25 +0000 Message-Id: <740bc5e2d2618d236519b39fedd1a1d7ae4e05da.1665203660.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746092666779641453?= X-GMAIL-MSGID: =?utf-8?q?1746092666779641453?= Before changing the core disassembler, we take care of minor code clarity issues and improve readability. This commit replaces uses of int with bool whenever possible. opcodes/ChangeLog: * riscv-dis.c (no_aliases) Change type to bool. (set_default_riscv_dis_options): Use boolean. (parse_riscv_dis_option_without_args): Likewise. (riscv_disassemble_insn): Use boolean keywords. --- opcodes/riscv-dis.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 088d0d91080..608670bed7f 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -71,7 +71,7 @@ static const char * const *riscv_gpr_names; static const char * const *riscv_fpr_names; /* If set, disassemble as most general instruction. */ -static int no_aliases; +static bool no_aliases = false; /* Set default RISC-V disassembler options. */ @@ -81,7 +81,7 @@ set_default_riscv_dis_options (void) { riscv_gpr_names = riscv_gpr_names_abi; riscv_fpr_names = riscv_fpr_names_abi; - no_aliases = 0; + no_aliases = false; } /* Parse RISC-V disassembler option (without arguments). */ @@ -90,7 +90,7 @@ static bool parse_riscv_dis_option_without_args (const char *option) { if (strcmp (option, "no-aliases") == 0) - no_aliases = 1; + no_aliases = true; else if (strcmp (option, "numeric") == 0) { riscv_gpr_names = riscv_gpr_names_numeric; @@ -645,7 +645,7 @@ static int riscv_disassemble_insn (bfd_vma memaddr, insn_t word, disassemble_info *info) { const struct riscv_opcode *op; - static bool init = 0; + static bool init = false; static const struct riscv_opcode *riscv_hash[OP_MASK_OP + 1]; struct riscv_private_data *pd; int insnlen; @@ -659,7 +659,7 @@ riscv_disassemble_insn (bfd_vma memaddr, insn_t word, disassemble_info *info) if (!riscv_hash[OP_HASH_IDX (op->match)]) riscv_hash[OP_HASH_IDX (op->match)] = op; - init = 1; + init = true; } if (info->private_data == NULL)