From patchwork Fri Mar 10 10:22:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 67326 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp789667wrd; Fri, 10 Mar 2023 02:24:27 -0800 (PST) X-Google-Smtp-Source: AK7set8LBixKxC7wnnrp6WNVqRCMM/95Nphj8quiOfEnu+AqttgWEjOqCdMYgwnKCiYBOH5XxiGR X-Received: by 2002:a17:907:c705:b0:8de:baf0:338c with SMTP id ty5-20020a170907c70500b008debaf0338cmr2031748ejc.14.1678443867345; Fri, 10 Mar 2023 02:24:27 -0800 (PST) Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ck16-20020a170906c45000b008b17e21e082si1784195ejb.295.2023.03.10.02.24.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 02:24:27 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rImhHKDP; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0B54384D194 for ; Fri, 10 Mar 2023 10:23:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0B54384D194 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678443829; bh=UurlsgKnFlZFyp/ANgn4Lw3kCdAH9F9I9a4hwiogL+o=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rImhHKDPtmxYKoLLt9f3hok7zU8UWFbS1ySfO3MxQ1XvgbFN17e0E0S0/Z57abCp5 DwtPrdxfY/d9l6RUZ0pK0acfk/t/4qRdvET76kf0SelJeDqpQ9ID4dq5EMca351JZj gpOobO20pE2U3eG7pEYeas5JdltawKBT44Ic/dr8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2085.outbound.protection.outlook.com [40.107.104.85]) by sourceware.org (Postfix) with ESMTPS id 5F8C23850221 for ; Fri, 10 Mar 2023 10:22:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F8C23850221 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5D3v3MNWIwR6B3ww1IpJMRGFFxzWjoscHdx+djfUodPB8Aqm5UAPi0x4+2oMZ4xTrtqg4zosVoM1/WVXKQVl2iVpML5EQZbGikKYcOnS6HjCMxfJEFnCQd9bW9fkg2VFfW4BMLv5wacy6rzTF6QwcXAUpKRU2X0lM23qehzqWPsCtj5Gy8clp6ho1L+YVqm8uKflC2tn7uDzpB3zcH03JpH0YyXAdJDQz/T/m5zztKh4spE5eLIO4JrNcfqUesQcxYQ6UH33B1IisPmk7Icn/xNCxHWOvCi+ydKYjEA/EzCtDRYLNtcQEWE5FmIulRXZeMWYBwYB079wNTyxtG4Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UurlsgKnFlZFyp/ANgn4Lw3kCdAH9F9I9a4hwiogL+o=; b=cNsLCC2q63j3wTs75aSeVU1kukFj3XdNcC2haPxDcZmJU9CLk1Qyxpbm0YIsaZ7n16zoFCxfV5xqvmEgH4XXrtk5BghlQi+OGfpmiG+cLUSbbQbnLCWYhXnwZmC624kDh6/1aiaqilXqTo7c/w6dgtS4b579Q4vwPyPJS3+26SWLVvlyO4wrjoZfflPMFyOOh5it2osq3fn8/771wYfZ35pNkZAgW4d7z11VlYFdQ5qcCx+suTNRkV1V0klBRy+T5ObnttbpK0nuHM6iSttshqx3vXT/jWYygztif2LUk5x6adTC57wv5O92hIi0eMh9oVSIoCB1Mg9vEYEk2X70vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8339.eurprd04.prod.outlook.com (2603:10a6:20b:3e6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 10:22:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 10:22:40 +0000 Message-ID: <667d9ad0-3165-08cf-dead-efd27a5d267e@suse.com> Date: Fri, 10 Mar 2023 11:22:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH v2 07/14] x86/AT&T: restrict recognition of the "absolute branch" prefix character Content-Language: en-US To: Binutils Cc: "H.J. Lu" , "Jiang, Haochen" References: In-Reply-To: X-ClientProxiedBy: FR3P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8339:EE_ X-MS-Office365-Filtering-Correlation-Id: 574915ae-6a89-4fdc-bf63-08db2151610b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nj0JEEYX9yilJedCw5N/eEk+njsciAqdH9mHH6qG/w7vfeTFXKB/USCr+Bc0B6LHfnhEaJf9CE0oL/40yybm/BbutuXnxpjoQziQeQHaHrnWIHez8WDx90YsqCZ3/aakq471bx93oOG9xFkqL4mAKhD6/OHpuUN6Sh3XMlQrK/KDVTlU8RmivwgR+9a6/bnKOXzTbGyEeDMdlp4DRIe/BVgJYZ5w+j7q3ugJENMeDdXkBy1ndIKtbY2hMvbUiyArR8J13VtWIJowxZizTpdPlKT9rDfJaYRM+6jTvw3QvfQGVEG4GiOTufCYL2J4C6oNemgIKIkbga1iN/aGM+Xh9c8bvB7PLw+I48a3L0G/inFqa7Jg6Wy/YhYOXpZj3Qdd7CS1XzQ5bMib7YWO8Aqc6YTvdL6wDhVaZT2yLFNUzCN4LCX+QorUw5KGKRwmRs3C+AzAolwp7me+Z+31yyxOjs+3VwKZj68jelMPIcUBIqGKSEjzOQvUapS6RQ8p2zlVKrezmlzP5JlXQEPnwjnPw9rlBWOF6sxi0qfn11+jzS2XHWrFkRTLstBN6SgIeBhwFHOifh7oblt+gGzg6rsJU4MEptPkKUK+xBlbpe1NH9vOHSxtC+dEAlEZrZvuLfYauTUcGxk5CDPsCCiNtOvNDyn5/SGnMcUKSqKsM2nBo0pFLfYVGBKKJ2ad/w7BaZvNVGAypH30TEZlMYR5i28OJ+gnrUPa53aEkc3Deh8vBAk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199018)(38100700002)(36756003)(54906003)(6916009)(478600001)(6486002)(316002)(5660300002)(66556008)(8936002)(2906002)(66476007)(8676002)(41300700001)(66946007)(4326008)(26005)(31696002)(86362001)(6506007)(186003)(2616005)(6512007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PbDfBzoAC1/NB4UjRqyoyZWLaYcY?= =?utf-8?q?GMQTJxjdxQZJGmr8miLdUdld5Qpyog7B6QgOjr1lCfDWTl1kkQnA+y1AbkubIEdpX?= =?utf-8?q?WcxfdB98WlsAuFCN0x1Nr300aOSWgnY5GWyIisdOqCR57pEhWE/uBw1V+NHqC2m80?= =?utf-8?q?rglRt2pBPKegcjNfmjvmVeeBPcVW0rJbJr4FV8BxdsLqbwFmCN9xoy5f8o2hdbWI8?= =?utf-8?q?BwuE1QO8jh0UY4IYG4ZBI+kJNQDREYsXikESk09daueXjUD/7rcaPbOXSsghQrzkm?= =?utf-8?q?dcq9tzAwbH93TU0gYnuIhCYyhR7VrbE72r7v8k/oh26Z3vekk/zBr3Wb8VF9stobM?= =?utf-8?q?HRyNhzlTnebJEwJTHjq0yhzAxm1g0KydE1iHGfjzJxTw4Li1gz9u0h56qPM4I7AHb?= =?utf-8?q?gpPQJ2yyr7d5Dv+g1Bk1dOJyuHo4FnyYRwoK/Si3jARlLhmx4bipFtriUlkK5csp+?= =?utf-8?q?CjWYUvb3AX3nS9+za+avpf9ySx61dvM6RxovBW7EAUFh4iJBWb1mKy/w6Q0b3iptO?= =?utf-8?q?A3Os+6bxVQR5ag1BNbuXsf84gE3ddcQ/ofIxO/v0Kz5R059rlnBerhusF8mMEbb3S?= =?utf-8?q?eQ7HPROxZZNZT+mqBUC0BXDPYoE70obFoXkLDwfEs9wwxLYHHBFXsgdRjFTycO0oS?= =?utf-8?q?4agHohin1+8Rt6ttek2WT5DmN7GV3vTm2FKTYk/559caoMxkBsUa+fwzU6UFoHCoH?= =?utf-8?q?713UPfckgYumzYbuVB5Ir8mMiIWhVL3ofO6rSM2pItmnrUQsAr2gIHeUhdHz0Kgcd?= =?utf-8?q?W0cVhMfLDogl7skqpD187NNt6Tf1xlc6bSZt/jXXgwIaEp0ovwcAhXmBvhG9U1oCF?= =?utf-8?q?eD3Ykc9u2ymzPv4KVdlhMmvG5wGqFH3tpHywmLlN6fBhoeUj0JI6qx3+Nn8I6pUGj?= =?utf-8?q?E04YqDuNURgee7D6CHNCNg5/8HUA7i7WQM526/35pbbQdoVGmqfA8OV0pDKtNz8zP?= =?utf-8?q?a+o2+p21AcuLzrChk/jR4ecoJg6bhhDTQ+09nUizeSWcN/5iXD0Xg5ad60Ro3Fylu?= =?utf-8?q?eMcuoXtU5uyOx19jsdIy2OU8ThNFYbTj0LFYvXpQw8pNik6UWryDComsxseLQdI5X?= =?utf-8?q?MouVfkUK9b13v5NmMUBB/HT0BLXVAdVZtDWLziOBfQhw2Gs99s7NIO+07P6HWZN5v?= =?utf-8?q?mrmQZlBpAejJvMzqKIlE4B7+6S700o3vukh54uB/7gWf/7v6+tzbkGVapmKQaFH3o?= =?utf-8?q?FDfMZuoEBnAGDfeeha8zK//NtzTwO57t4GnTjaEI2++BkYghHM6EJnVs8ApxZnKLZ?= =?utf-8?q?yHJtMBdT6wOv79yNDhGHBwxTAhvjUREuLiZbMZbP+xqiFJhasTDqFSAJnDqOg1jbF?= =?utf-8?q?ZXScT2HRXvmumylpq5iu4CDPx39fLt7x2r5mNm4RIA29bWMFQRc3fmtJRpd4+M0WN?= =?utf-8?q?Be8Biz8GmaCNXiN6e2XsYDwfxFJSeFAijDrf79SAce0ISTNrnaAdC1T7X0FOBt1gA?= =?utf-8?q?JExp22ywIq8P33e/t4DBPrB0K9MODbPss4OpKJ5upF6IsYj/zPHJYM13aemiNl5SQ?= =?utf-8?q?p2qKxRv/zRHs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 574915ae-6a89-4fdc-bf63-08db2151610b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 10:22:40.8846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: noKUOFHHXgC3F4PbbX7TodFVqArEyx52HMxoMdnsVsdHCJwnAv++FzGu8PPlKqUjXojWMiZPAakqqNPs8p0qUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8339 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759975956648881176?= X-GMAIL-MSGID: =?utf-8?q?1759975956648881176?= While in principle merely rejecting this for .insn would be sufficient for the purposes there, be more generic and reject it for anything that isn't going to be a branch: All elements of same-mnemonic template groups either are branches, or are not, and the few cases possibly requiring a 2nd parsing pass aren't affected either. This then also improves diagnostics for misuses like inc *%eax incl %fs:*(%eax) add *$1, %eax --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -11837,7 +11837,8 @@ i386_att_operand (char *operand_string) /* We check for an absolute prefix (differentiating, for example, 'jmp pc_relative_label' from 'jmp *absolute_label'. */ - if (*op_string == ABSOLUTE_PREFIX) + if (*op_string == ABSOLUTE_PREFIX + && current_templates->start->opcode_modifier.jump) { ++op_string; if (is_space_char (*op_string)) @@ -11868,7 +11869,8 @@ i386_att_operand (char *operand_string) ++op_string; /* Handle case of %es:*foo. */ - if (!i.jumpabsolute && *op_string == ABSOLUTE_PREFIX) + if (!i.jumpabsolute && *op_string == ABSOLUTE_PREFIX + && current_templates->start->opcode_modifier.jump) { ++op_string; if (is_space_char (*op_string))