From patchwork Fri Jun 16 10:16:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 109011 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1224309vqr; Fri, 16 Jun 2023 03:16:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4gnqrtkkbibxyi6W8xFSB65xAMIPKEbCeNZhLff3R07a+zLISJeRsm58LXhNnSpz8fZrSD X-Received: by 2002:aa7:d7c9:0:b0:514:91e5:d622 with SMTP id e9-20020aa7d7c9000000b0051491e5d622mr992034eds.36.1686910605617; Fri, 16 Jun 2023 03:16:45 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id s21-20020a056402165500b0051a070500e6si2651123edx.290.2023.06.16.03.16.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:16:45 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=SopElPTT; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 252883855587 for ; Fri, 16 Jun 2023 10:16:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 252883855587 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686910592; bh=xdsoZX5plqwzoWQpKRi5G8xHx6yJV1g/KLmTCKTTQvc=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SopElPTTn86DbEdcKmYGrAan1oO/3PQqiMR44KXkpO1kp91CopEa3ckRRZ7MvIPT3 E2duSfk2mXDuN2arhPASi2oqpvfUHbsMfr0fwx5nsPn7hijyGv7I3fIs0/oK1S7mRz OhGS623vvI1gj7gjR98pt37WsbIAPpoYresfWGqE= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2088.outbound.protection.outlook.com [40.107.21.88]) by sourceware.org (Postfix) with ESMTPS id 4484738555AF for ; Fri, 16 Jun 2023 10:16:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4484738555AF ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPR+CeWNXNg41YMerWT+K3FlUo8Tf4qhTy0swfJ9TpgJFNiVL9A0l+r71iEbJqgwf1QRtjxrARIk6YIBQ6B3oubwUjRwE2Pi4Qs/PQPyhR5xqCdlw33iUDCewWXmcrW2/s9nYGKIFi3sSDHSsjNOv6M25XwjdIxH3hJuEAg6Eh/1GsQpaboiAW6A24Uwqi9boY5hm7h1n59o9VZlJGLOvaXvqZPTCWIDxVDw44KJ9A+PhYU6FkcY1nlMJpnja9MdX/2uxN3RyIapEOkngxQ2ZaIdNbD5GKUeRiEwd8Sl8N2PjzRhJpi4W3PHf+z1oGLNi8s1sCF441Gswk2KV03sNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xdsoZX5plqwzoWQpKRi5G8xHx6yJV1g/KLmTCKTTQvc=; b=YK/tntzMqmf64y1UJv39SyIQA/L32F93nPxOcfoCzDDn5cXxwvpMkWgB0xjhcKoUjsLV3uLHzc307S3G5T2iXQwLhwqEV5mMj8v63GOKd7ILNy/UtG+jsc9x/fApHhxLMf2ANIXBBgcHZwKtGOuQ0eraPDwzDfJsc4iVTi7b3Qe42xZFJILU8YEa0g/UWt9md17U8h+qJ0J3NisAdsLZpRYjeTU79flRqP4dY30H/9SpDA6RQ6WQIzBHqSxkejenThaW6lMlssdkR7KvMMC5m3Ix40u9i3tQzyUQlAGPc9MSJb5A9nYAXjW2+Q5zwY3NqxJoy+EH3XNirf293e53Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9429.eurprd04.prod.outlook.com (2603:10a6:20b:4db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29; Fri, 16 Jun 2023 10:16:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Fri, 16 Jun 2023 10:16:22 +0000 Message-ID: <65872bf7-36c2-0a0a-8992-38a0843a897d@suse.com> Date: Fri, 16 Jun 2023 12:16:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 3/5] x86: flag EVEX.z set when destination is memory Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> In-Reply-To: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> X-ClientProxiedBy: FR3P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9429:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c13fdd2-c388-43f7-27fd-08db6e52bc13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z1FrxPkZI9vPJDu7VgKM62UTIndxDDbzdG+JC4nClORxOz1siA9FrdgQ57Gmn3DG+ky0h8MZ7ibnHVUob8+GJdVaGEHWjuyTP0byQATWC/cvnrTsxEu3guh0Lb9MVdp8rgC1UdXyV2RQ9jvpT9rMIelUNnF+PlTM1/YJaLR5WY7ZW4AUznVJVHpEddtxhfWGAZD+5ro1QVvO8wIc3b3hZf48uyscn176lOAg3V8AS9lBOgwE5So+R88ODGi9BnIGi6xiZ+1sA9YLv6A7flwjWkR5gC6QH9zEVGqEK72iGDn19pI1GMYU79/Yo86I2py8ZlzbUkodemolnqHTuy/c/32vsE1iYonPHRMSZG24fXh71TxSvPtZ0RvjDvokKncL4wG67YQA4czkZxpKHiAl5cvyS6QKoNamDthDsPJWivaR7jesJB6WLX5uPwGwAtiEvSykRtc7m7kAVCHhSTt9G/d+6Ye/xDc+kRmHtSFGJ5+2pN2A5WmU80N0jNwFe/7LyCUd7vDmdDZOTzPDgQYDlRS4pGYF6dSNB4i28xADpIl7z1GjoJZ3Ed7oTytrJEp+cf82mMo/XsJX3g00eKOrSZlRSxSw8y7maOhJYHryt4WuPLRvwG8VWl6SNV7SCbtU0CqcEDW4nyvdtWeY1eaT4g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199021)(478600001)(31696002)(86362001)(6486002)(316002)(41300700001)(38100700002)(66556008)(66946007)(4326008)(6916009)(66476007)(8676002)(8936002)(31686004)(2906002)(5660300002)(186003)(6512007)(66899021)(26005)(6506007)(2616005)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NlJ7GQYH6wXDhqjGnmpv91zSNgPt?= =?utf-8?q?1AcQCNboHh4YtdrXpdRzA3r/IXAXo4l8BzvZz88snc+jj+5IhKlEXseXnt9xu0QJQ?= =?utf-8?q?0p/ZZDDDqxlm8xp2AoTIDWS9ezKFGRb+eOL8rNSpY4NkAySkMQQErU2t98GgTamqc?= =?utf-8?q?J1wS0ZPVhzs1IY3pMJUr3UJStutPjSoro83hC7T/fF8mPeuBzgHfXlNLKAWXPL689?= =?utf-8?q?wVX8XM4jbENtNtCq/BgOgJnbRtYdFbgn5z4t3Oxidl+A+Yfyo1SnDEk7vCXBY48H4?= =?utf-8?q?QT7WBbDvtGFiDg4ebGME1SbhmRVyjQaWvfhdFJwS2ELvMXNC5T5KZYdFn7YvGX7oM?= =?utf-8?q?Sn4HoOSgKkpLRvA4SYpaRby8BOiBUnDgFUhQ9L73gkGux3s1UghuE0pSUtS0KESQH?= =?utf-8?q?dgLhNC38LoNlezvbxmkZMjVmXDifPyPq61lsIs5FNBw/6y0kCE/qOnRXKDRkbT16K?= =?utf-8?q?JupqFZobrMAEg2TUC6GAh1uh/82EFOqwZiUZte7vlstnK4m3Gdor+MJJeSMSsgAVE?= =?utf-8?q?zdAe768lAI8MlmPo6srSrOO+8Fg24ZqAqzGRWa3XxZkAZDCBWr1VbG2cVKyjcOdQS?= =?utf-8?q?nuBDT2Sf9Q/D68pwAZvQyTB0Ml05QnKGQWDHQHsguzLDiM7JtKEt1ZeNJCe773vT3?= =?utf-8?q?T/m6DHepS1SK+ltOBwfjhrtHnptNHKFI6VfVBkMcLx4yYSMnZKJ+DEiAL7S2HsWDc?= =?utf-8?q?D5YP47EnGl8qzlL/lkE/1Olmsl9pNZpc2UYpkJLRH/vE08dQiaZT3Ge51+PyIp/ba?= =?utf-8?q?Qrm2zLGvn9fDaL3+Z16KwSqt40wIpY66nRqohHA1dzaajueIJVCc0qfRsq7JHV8Ru?= =?utf-8?q?vRBBD3E83bPsOZBAa+XqfFzNsABlIk9NhU0sFOBqK9lPVkKIclTgZxostwjB9Yuuo?= =?utf-8?q?2k9CjLLFOr7nNHO2i2LpoPb1u0rWPIu0YqSfdIa7/i2BjhKe2QPihn0ncNgEqmSJn?= =?utf-8?q?DRqklj6sGRoFGvCStDvLi/H/5h50BrhdOFUvOfBsvbqRGc8GbGHbtKcBnrnfzLGDK?= =?utf-8?q?p0J34LdJMO32QQKgYUCmGE0qPB97AolUtmqQJgtw+s4CpjgRBnAkhOit+2HIbCsFw?= =?utf-8?q?ZBh6y/3nQP1ySFxqqclH3Pp0N/IJREuVWzTAFw+hVy+C7ytZsFXhAV7cbQbt4zIBY?= =?utf-8?q?r2STBD09pM3VKBYdDZiNmH5/pzhG7HxVIixjY9Rzk7e5xHrfwXwR0W1043GRP3YBQ?= =?utf-8?q?q2dahXaLzIAfRezST3BiEOsINMWmzdprkk2jWLvOzHtFvBj2br2s4WPz5KLuIfpL/?= =?utf-8?q?I5MixiBM9eHMIkk/L3+q4YjYsa3my4OlzGiGbeP7aKF1J/chKoFXsc5zUyQk/YZHS?= =?utf-8?q?JXkgCWX79+VtuJUeczaaahGuZzp9sYB+HIxgfCXjDIAsVzAWFMo782+23o4ORux0w?= =?utf-8?q?Mq61QrMZl5Xpl36tVZ9bi8wXSNz860rlCXrmRi6fHorsQnwPuJvZZ3zdrM6LwgKcw?= =?utf-8?q?29lImiSEae89+caFi5jS+S/s985ZCKD5Bx3cdBdXf+ei7TQ8Jd2OdMf1GBhyRU60e?= =?utf-8?q?QRWJyP7GtEPs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c13fdd2-c388-43f7-27fd-08db6e52bc13 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 10:16:22.6227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y+b4cNX2HLJui+b/tLJfgys3KuR4nucP8XfqSqrJLIhOSUPZasAo4jBLYaWJ4xO0xpeTgKh3Jn4U4dRgTbgejQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9429 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768853975029419451?= X-GMAIL-MSGID: =?utf-8?q?1768853975029419451?= Zeroing-masking is not permitted in this case. See the code comment for how this is being dealt with. --- a/gas/testsuite/gas/i386/avx512f-nondef.d +++ b/gas/testsuite/gas/i386/avx512f-nondef.d @@ -21,4 +21,5 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 62 f2 7d cf 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0\{%k7\}\{z\}/\(bad\) [ ]*[a-f0-9]+: 62 f2 7d 48 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0/\(bad\) [ ]*[a-f0-9]+: 62 f1 7c cf c2 c0 00 vcmpeqps %zmm0,%zmm0,%k0\{%k7\}\{z\}/\(bad\) +[ ]*[a-f0-9]+: 62 f1 7c cf 29 00 vmovaps %zmm0,\(%eax\)\{%k7\}\{z\}/\(bad\) #pass --- a/gas/testsuite/gas/i386/avx512f-nondef.s +++ b/gas/testsuite/gas/i386/avx512f-nondef.s @@ -29,3 +29,6 @@ # vcmpeqps %zmm0, %zmm0, %k0{%k7} with EVEX.z set .insn EVEX.0f 0xc2, $0, %zmm0, %zmm0, %k0{%k7}{z} + + # vmovaps %zmm0, (%eax){%k7} with EVEX.z set + .insn EVEX.0f 0x29, %zmm0, (%eax){%k7}{z} --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -11854,6 +11854,13 @@ OP_E_memory (instr_info *ins, int bytemo if (ins->vex.evex) { + + /* Zeroing-masking is invalid for memory destinations. Set the flag + uniformly, as the consumer will inspect it only for the destination + operand. */ + if (ins->vex.zeroing) + ins->illegal_masking = true; + switch (bytemode) { case dw_mode: