From patchwork Wed May 17 11:00:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 95160 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1039281vqo; Wed, 17 May 2023 04:00:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xCgG8M5/O0l4iBjXPpGycSqO0EJvl8tffhHa4FwjrmX8lb85tIKYNrkD2udDdnEvTsFp1 X-Received: by 2002:a17:907:1ca8:b0:96a:bfc:7342 with SMTP id nb40-20020a1709071ca800b0096a0bfc7342mr29041131ejc.62.1684321220706; Wed, 17 May 2023 04:00:20 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id s23-20020a170906285700b0096b0e07a50asi6102811ejc.655.2023.05.17.04.00.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:00:20 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=QhZKHjQX; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 57F1F3856DC7 for ; Wed, 17 May 2023 11:00:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57F1F3856DC7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684321219; bh=xUKPP59Lp5XeOKG1O6Uz7zl0QOjGFkaTkS2QpqNKQ+A=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=QhZKHjQX0tpb0U25+WCy/RfJx6BK174pRyJjzf9Ix9Hd2E0UasEhPwSKTcNlZ2nog 9LfGKLQdwDNfIreJvmvDuQ8bkc52oMpDqWqc/Or6JtoIm0dAj9mEekhIWY3YR+FwNa 6fWxBwMcll4ia6J20gyxMRaeUmWBKSkE602+ZaP0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by sourceware.org (Postfix) with ESMTPS id 90CA53858C2F for ; Wed, 17 May 2023 11:00:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90CA53858C2F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtZ6KWaA78jtTVtGzcm5SN+uaowFIjdt1Bb8sLDRdo2NwGHroquS9zppCg6K7paI5nuMgqMRn279Aza6E8rweeEjO7praJ0GZ7nfUZ0ZTjsOzrTrLYcCsOPbFB0r+1+Es+Utf3PMKwuGIyiVDcaKdXZASJpxlHF+vYF5jbhjtikkmHhCwLPiJ9sxaVDJossWMenBZVOj/dczGqVhXLJypdSrwGpItBcG8RaPnytVWYWQH4rgzFCl3RAwOnNTA8VRWSpJXP23M+3V7P1p5z5shblL/Dgxm/8754OEJGBSVCDcBRwrkUInrChgnpC2n6NfcWyWZH2biZSEDqsv9f3pHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xUKPP59Lp5XeOKG1O6Uz7zl0QOjGFkaTkS2QpqNKQ+A=; b=Nq3m0dQ1kQHCYb45wOmKjOSCOzqEA1gkTgRcvsJiDJffcBo7pa1dE2h0vF1fXbjQH65404b9clLItXw8ZgW+ruW8vAANu2gImqK9vwE+WzxQDKkB7e30PZ4fs2tepWfUHH9x20/iOkH397V5J6gAnvMcQqGGwpCj/tExPXh1JAX99nbJzYddDIH99ca6Hk59jP+b5IDml80V2ix6eeteKn9ILVwFxm7mAfvXuKXEVXCFE6veOW9TKvjbfhG0Gg/vwSVh65slwR2tcTdGKO4TCBbPodfNHrDmqtTajWyO7wBdjB52T1S0iaaHi4e0UMXBVGU5b8iwrppjpudZZf0DVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7978.eurprd04.prod.outlook.com (2603:10a6:10:1e9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 11:00:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%4]) with mapi id 15.20.6387.032; Wed, 17 May 2023 11:00:05 +0000 Message-ID: <61663a6c-a5a4-812a-1110-06e0122aabba@suse.com> Date: Wed, 17 May 2023 13:00:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Binutils Cc: "H.J. Lu" Subject: [PATCH] x86: permit all relational operators in insn operands X-ClientProxiedBy: FR2P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7978:EE_ X-MS-Office365-Filtering-Correlation-Id: c944c2d1-c3fa-4e5a-45c3-08db56c5df4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6lQXyv5zDYt6eIsXtqkkw8FHPI1OVH2SbT5Uz88FwKNWeBKPF/vNHyBDh9t3vhdTqXWwIp7XTu3IwvTsBdz6GjbvMVwHqn+EzlHt6odofJ9+NUg9ereM8A7a7Xi4KiEiuT0d7MWOwMj7dQLbS3Ot7NwR8Ig5lZpIHokN5o6X/5MNNyxRHPH8Ui2ysI78v7+ua/G4a0MezomcS8Se1FR6NG3Idd3eeZzkSBsFDsary3JWginrurqKDOci18W4iwcQhJ92NCbDGVqwGXdo/y9HKG6mOuO0ODvWzzX5UGbE+/LNnvg0q4h3m2x4KRMPsGzmrGXbhvRmKw2D9Oe4czGhiHy6iqLIQcvouxq4Zv69w4msUphy1rmxE4VF/qKPTDn21HfjBB447zSxYP5+Cd+RzmwgJQZpt3w6qsuSScbMCYpVVl5kXeG1UWAY3l9WvX3IlL8TPEzgcQCKex38cXxb4ttxRIEeIFXhVBu5MxrTlnr+JULAk+I7lG16QxItkruGq+f1vmhQFIN8Hqo6Fxxy80xk1ET1KsdnQIlwWv0+28ISNDzkprJpkcaBNfgtnLx6TCXFAhyes2+4pi1mK6QiVT8qM1hxl16Rk+StYgcLBtOtp9sjJV5QOGCrnovoXCWzdVxQb/jtwMbnXaQBlXZKag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199021)(36756003)(316002)(6486002)(66946007)(6916009)(66556008)(4326008)(66476007)(86362001)(478600001)(8676002)(5660300002)(8936002)(2906002)(38100700002)(31696002)(6512007)(6506007)(2616005)(186003)(26005)(41300700001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OkZOfXjDKdOkNuNwQ2HFRcMKtMk0?= =?utf-8?q?bpKrmL+5aEnGwSTkdnPaLCD+ch5ndQGmJ0YqR6JiP3XXKgZpZF3C3qrvDZeEU3Lfv?= =?utf-8?q?RGag5RzItd7+fsqJBCXTplWV9FqrrvD13erlWegdtF/joAzmqUbqvJfTW9quAzLan?= =?utf-8?q?oppderOJfXo39cptbU7rwl8AT5ACmyg55g9zVpf9K+Kh+N9KyNJZR//xhKtRDLFbg?= =?utf-8?q?4Xo+sha/MMkHAuScZ0jVzHPFwZ/1vCTgxEGyv3UQnpQ4SrZr5aVtmAYhQMKQh11TQ?= =?utf-8?q?KfO4TLHFa4zixvoe+kjWB+N3HT/HAEnaF4v4sFAcEdaDzRWemZMjQ951oD30DDgVc?= =?utf-8?q?HLGVAvyE82qic3sRhts/7nF6RDPXraIk//g1O518MGV0VyT1JqG3uOdaCEpHF5vhf?= =?utf-8?q?9PsBTlzAzCiVQ91GRPbnVXwt/y/OxnYMZukNZfr3eAYa39QMEAjXgxdYs6FK4bT4g?= =?utf-8?q?pTYq6uPjkSFDEhF4ZGB5mt+Ve6T6batnc0/UQ7uXjPIXdhXZdAxHzo6hfthdDaq4K?= =?utf-8?q?anP8kbVRv5EwmzEjFt0L8c2olZ3LK9bfcbEzso4wjxzr4HbwW0uahniMWQY9PR5r+?= =?utf-8?q?0qJi4m7/5UySnTIoAFxDyu5RyXWgH4XNBi8DkfA8kw8uGdYc+XqVfGxDTTaX7bl33?= =?utf-8?q?/a4gYH7LdNL+w8PgaPuBnTegsoFe6eWStZFYL+0yzeDwxXEjUZ5HGlaKGrdonv6RI?= =?utf-8?q?oZpWInizM1GwhxABtWUjrgcLsKhYnlvMnaUrM+Yj+qcKAjGBjBkL6npL3OmGJVfeW?= =?utf-8?q?DBw1NCd9OIcbYcGpg/0Q5zb1gJBZXGOhh+9mUMVwpPh8IvNoxkzk4WgdZbkPztEUr?= =?utf-8?q?OhIWrO+A+Me9d71ZeL2aHsSYs1YlL1hhR/aVNd+1mQPk17sPRYXgWdQRihQMktxM+?= =?utf-8?q?GNWKtl1G8d+Xorr/BKG/jBB0KWqTeRIxJQCgTagcZsq8+8ZadMVG2uNFWO+iUvCq6?= =?utf-8?q?XQ2tfeR5T0tD3N237d6bb85gTjr3xoTK/6LB9iDbnzbWojQvAIm4d6wgxy2sKbYsd?= =?utf-8?q?66xDrM38FRdE2VFQIBGdEFzYgmFJ9zmZfWdjDXifBNQelIO9pT50R1hrxaT61BfoU?= =?utf-8?q?znFZfSyk75dg6CJ2Ny7AGvA/6ZWCwp7IqMlzusnAfdRuJthQS6WRmZ4Gt84xzqTFK?= =?utf-8?q?URrv6C8BsCrn9s4OzptYTUjmzFxsI4yNDZY4XhmWkKfDZo7WzbR3ZcaVgcSn9YIEu?= =?utf-8?q?0W+oeqFa20v/Xo7R8GLbBf+lz6uRCusyh5xknSX+8bLjBL86tGIi1JmEbRI0cQ42B?= =?utf-8?q?xe+pk2NSCKEI8fnuujaFnjx85kS5seu+KkE8JZowz3mWdqkgK/zRtXKMTm6TLdGVg?= =?utf-8?q?LcTBi6wVPLszGNOw5+nPGPiC4krF6Jdb8uJAGDxfJU4kYuQV7rP4MZ3KR7pPWMrrv?= =?utf-8?q?8jcZ6aXDSCYRwAv8rE1TUv054nR9YRwwIOry4a6UvIKn/OkAfNugo8WhSpon9Cqlo?= =?utf-8?q?J7DzNn7UUdpLLhwUzwc7IH/0LLKL0uN/Pnv/Pp/LQqyQPCzPhUrkoFMb+RDaU03PN?= =?utf-8?q?EGKBUT41V8P+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c944c2d1-c3fa-4e5a-45c3-08db56c5df4b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 11:00:05.9126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: spEb5KyBJGOg5tlnD7VCLrNCYNeRi6F5ls58tr4JwZwCn3tUHeGt9NhE2U5GdCa0hGDJiKhFOtJ0J2r6g1QQtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7978 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766138808285806855?= X-GMAIL-MSGID: =?utf-8?q?1766138808285806855?= Oddly enough == and != were not permitted, because of '=' not having been listed in operand_special_chars[]. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -547,7 +547,7 @@ static char operand_chars[256]; #define is_space_char(x) ((x) == ' ') /* All non-digit non-letter characters that may occur in an operand. */ -static char operand_special_chars[] = "%$-+(,)*._~/<>|&^!:[@]"; +static char operand_special_chars[] = "%$-+(,)*._~/<>|&^!=:[@]"; /* md_assemble() always leaves the strings it's passed unaltered. To effect this we maintain a stack of saved characters that we've smashed --- /dev/null +++ b/gas/testsuite/gas/i386/cond.d @@ -0,0 +1,17 @@ +#objdump: -dw +#name: x86 conditional operators in insn operands + +.*: +file format .* + +Disassembly of section .text: + +0+ : + +[a-f0-9]+: b8 01 00 00 00 + mov +\$(0x)?1,%eax + +[a-f0-9]+: b9 ff ff ff ff + mov +\$0xffffffff,%ecx + +[a-f0-9]+: ba ff ff ff ff + mov +\$0xffffffff,%edx + +[a-f0-9]+: bb ff ff ff ff + mov +\$0xffffffff,%ebx + +[a-f0-9]+: bc ff ff ff ff + mov +\$0xffffffff,%esp + +[a-f0-9]+: bd ff ff ff ff + mov +\$0xffffffff,%ebp + +[a-f0-9]+: be ff ff ff ff + mov +\$0xffffffff,%esi + +[a-f0-9]+: bf ff ff ff ff + mov +\$0xffffffff,%edi +#pass --- /dev/null +++ b/gas/testsuite/gas/i386/cond.s @@ -0,0 +1,10 @@ + .text +cond: + mov $!0, %eax + mov $1 <> 0, %ecx + mov $1 != 0, %edx + mov $0 == 0, %ebx + mov $0 < 1, %esp + mov $0 <= 0, %ebp + mov $1 > 0, %esi + mov $0 >= 0, %edi --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -754,6 +754,7 @@ run_dump_test pr19498 run_list_test "nop-bad-1" "" run_list_test "unspec" "" run_dump_test "fp" +run_dump_test "cond" run_dump_test pr30248 if {[is_elf_format] || [istarget "*-*-vxworks*"]} then { run_list_test_stdin "list-1" "-al"