From patchwork Mon Oct 3 10:44:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 1648 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp886656wrs; Mon, 3 Oct 2022 03:48:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6NkSMOXhMUXTH7e9TavLa430ddkF7AqxBoN/0acQ30MMmuGcGg4i017omYEKGfJOF3t1xk X-Received: by 2002:a17:907:971c:b0:783:286f:152b with SMTP id jg28-20020a170907971c00b00783286f152bmr14807616ejc.479.1664794085361; Mon, 03 Oct 2022 03:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664794085; cv=none; d=google.com; s=arc-20160816; b=ppbN+jXD1B8J7GOWctR940KPSmky+YlGUO6+WPll/bz6Dm/Z5vO2szAbuDQrHSnalM QjMmMquF7cMNiY/IAWoMH5UWGiy1mu3hsKJVXOJcvnR5y62fA/E/NqSA+lDz09AkxYsU VKb3sCqknUS+ypONSbMQXmQ/7+S0VPHBh0xoHTB8XfvYbDBO2iDsRCxroU1wm8QakQw3 acYgsO8xXeRmoPUHIe0EHST33uHrkGdYvOEU7c29v29kGnysGqmz8X5GzUufvJnZ3XYJ AB8Iu4TFxMj+Lvu5di/j7Mj3nzoezAyEKft0V2oCEcSBBe+Ww2VxAJOT/2vtzOjI3vOE wVYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=bCHnXUqP57gpXEm2gWh52Az9tJul6rVte8okbk76V6A=; b=Xm5E+IXNIYgfTeK0PzrnA2Sb7AXZuoE6RpV2cb0fzSfKWOESIXJ5l/BwGb2wuT30GR J9K7NuVtzjHxwXoR0BKQZ9iGBOBHlVx0qbPL9Fw9jFDcFgx2m5TN5tmj7tnZBH6Vn9rw XR6JKMbyygs5R4wSIa7a9B/kRc7y/idyBaGL5oOohD4g+heBwLMd6WHb4fkacEqrgkG2 VZRD9wMaT3h5KjFI08b4MHHeTUeCNda+NSJseghmpIADv5U+hrDs+FDzCYgVzb9JA476 iuuxz7c9dKOuztVQWSklAhLkP7kX0OzHCEBZfwg92bYVtA0Ak1nfWu1VKnv2jHPSDpNi +/Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=aOUiiDGu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id fj3-20020a1709069c8300b0078849a014e9si8504132ejc.196.2022.10.03.03.48.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 03:48:05 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=aOUiiDGu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6689A384D159 for ; Mon, 3 Oct 2022 10:46:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6689A384D159 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664793990; bh=bCHnXUqP57gpXEm2gWh52Az9tJul6rVte8okbk76V6A=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aOUiiDGuKLTUc8ElyjmV62oM8FqBoD4EPHIdM93qk0QhDTGrRgaU2s0yvt4xpuQHX 2LvqlQbBwvlUht8KZFmdH+96tDnGtJxqdI4XXg8DXakxOllVYPwHlWflLs3ACzwoBd EZI97lZKlZmAaUSzYN3YlPAjsXXvKhcJ9fY6wRtY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id B8158385380A for ; Mon, 3 Oct 2022 10:45:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8158385380A Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 01F14300089; Mon, 3 Oct 2022 10:45:22 +0000 (UTC) To: Tsukasa OI , =?utf-8?q?Christoph_M=C3=BCll?= =?utf-8?q?ner?= , Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess Subject: [PATCH v3 5/6] RISC-V: Fix T-Head immediate types on printing Date: Mon, 3 Oct 2022 10:44:03 +0000 Message-Id: <5abe1d8a7694417b990e11d8f6cd6789573872e5.1664793840.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_MANYTO, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745659941148807472?= X-GMAIL-MSGID: =?utf-8?q?1745663122483912620?= This commit fixes two minor typing-related issues for T-Head immediate operands. 1. A signed type must be specified when printing with %i. 2. unsigned/signed int is not portable enough for max 32-bit immediates. Instead, we should use unsigned/signed long. The format string is changed accordingly. opcodes/ChangeLog: * riscv-dis.c (print_insn_args): Fix T-Head immediate types on printing. --- opcodes/riscv-dis.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 7f5ca4dcb85..c0edc4c7d6b 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -596,11 +596,11 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info oparg--; if (!sign) - print (info->stream, dis_style_immediate, "%u", - (unsigned)EXTRACT_U_IMM (n, s, l)); + print (info->stream, dis_style_immediate, "%lu", + (unsigned long)EXTRACT_U_IMM (n, s, l)); else - print (info->stream, dis_style_immediate, "%i", - (unsigned)EXTRACT_S_IMM (n, s, l)); + print (info->stream, dis_style_immediate, "%li", + (signed long)EXTRACT_S_IMM (n, s, l)); break; default: goto undefined_modifier;