Message ID | 433b1d03-2e38-8b3f-be46-c859e678959f@suse.com |
---|---|
State | Accepted |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp397331wrd; Fri, 3 Mar 2023 05:07:06 -0800 (PST) X-Google-Smtp-Source: AK7set+P/Ab9GRJYOCFWiWAC0pyDnFPhPNoIIesWzCiM0DDdjRZ04hFW3CdpWaXyE/gq0Mr6ji1s X-Received: by 2002:a50:ee92:0:b0:4c2:96d0:c0cb with SMTP id f18-20020a50ee92000000b004c296d0c0cbmr1840527edr.23.1677848826579; Fri, 03 Mar 2023 05:07:06 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id k21-20020a05640212d500b004ad12c250a7si2504475edx.111.2023.03.03.05.07.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 05:07:06 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Cxfoinur; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 041D33847816 for <ouuuleilei@gmail.com>; Fri, 3 Mar 2023 13:04:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 041D33847816 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677848685; bh=X8fdXjgVuX9HiovB3R7V1kaNDAQdF/e+ex5AhLjDSCk=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Cxfoinur3pOrUcCzt93bdMUs/u7YXxq3rQdO4pUHMy9FwB3obqYg+5XLEeXdhAU+E IWZMUhjQBXh7TlmKc1FQ8PFpktTvxEOs2LWHzdsGHWWveitatJUgioinOeyVnzlBmP iBvO37ElZzTRoypxhzebC76sZa9NVXR4h1/EyD5g= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2064.outbound.protection.outlook.com [40.107.21.64]) by sourceware.org (Postfix) with ESMTPS id 9E12B38582B7 for <binutils@sourceware.org>; Fri, 3 Mar 2023 13:04:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E12B38582B7 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSyB34Lxy20+o0iNOBJS4LfCvROzxXKmyOC8yQgIfuqEiSXHVICPskFgEH/7rbDGbN7Pz7Su+eC7vstbNrgn8EjUQFf95gmj/MBEYTPRsJ0j+tdZHdZlTks6BSKMskFHi0W6Awy78PjwqVO/PSkjp87UD9V2yjgkND+RGx5RmaIp5PiyJ2ixeyr863jFC8pRQCvGBQn9/EoSwLlHKMfnieeOs2phZegj573rNnT5seimJQGSy6w05we2zIrFpqbR9SblspgMVi8foU0HuKaOzR2Q++feJ1E2q1drWSW/fF8RzhnejBDlFhIjy8+Pmo5EwF22DTfIWs6vnyqO7KGzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8fdXjgVuX9HiovB3R7V1kaNDAQdF/e+ex5AhLjDSCk=; b=YaeUVptifIj3o5LNqZq+x8Akrgk1q6YJZ/+DVNN9EOf64lHOeYMhQ0g1W1bFHkdC7OxhhI2UchW0ZTJYJslwUTjeORoY2ap6PtSpM6YpZ0U/8qsfDZ9ErGn2x41BCXxPej4Nzje5XHeJ4r8jnc48g9nPT37UeQ4FUiDOCcXb0IrUWbEcWm0ABbqeyjRMcxt2LfDB+XWehYxnCtvvG1iKqI0IlEbKpdX8xcpAnjKMYjnee02vFXVu0FhRKnevtkavipuDtZmAe/sGMoPssmS0Cw6n6rSR/kyFGLGd2hUDBFMhVHMEmcOTYqcVnSiJaRUv6OLDhb2ouaDURegtI5SeLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7513.eurprd04.prod.outlook.com (2603:10a6:10:20a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.21; Fri, 3 Mar 2023 13:04:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6156.019; Fri, 3 Mar 2023 13:04:34 +0000 Message-ID: <433b1d03-2e38-8b3f-be46-c859e678959f@suse.com> Date: Fri, 3 Mar 2023 14:04:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH 14/18] x86: allow for multiple immediates in output_disp() Content-Language: en-US To: Binutils <binutils@sourceware.org> Cc: "H.J. Lu" <hjl.tools@gmail.com>, "Jiang, Haochen" <haochen.jiang@intel.com> References: <764b9e03-18bd-6945-692f-a250522196ca@suse.com> In-Reply-To: <764b9e03-18bd-6945-692f-a250522196ca@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7513:EE_ X-MS-Office365-Filtering-Correlation-Id: 31f079e7-83c1-4a8d-a69d-08db1be7d5dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KOIXN+YfMmmw+zpWIYyktqocSmzrxI4rJZM00lgtrKy5zk8dQYPyBWosYQqrbKrZupNoVk5G163wUFP/X6FwdQcmtxUZGrMDYJ1hAvz0UdYH1gSLinMNXJygJN6SwhaSP0JiK+ovAtVFlJ9nDUj2tTZXgKttXwGKb135huMfkRGjko/+SXKdopJOHPhF1tAO2ZTYn8SjGX3G5SfEKY4HX91W6SSN8qR1dKMqbHVGhEQW2QalDrryyDHg35h0Io3JMLmrUbAaAS46ntGoDYHlPNYpVBqH8nSgun9jCy+xVa4U1dpHuxrrqxe6vVzfD07cZwTAaKVoiltaHuVFqQHFeuV+31bURc2ADlZv5UMIz0c6TEiDJgcGpLXa04ZW6Z4sGWVASDSLbwNRtnEi3tm+zpSIX3uql5GZP2YnV3/NkZkk9BWusYDkulvHkeCyk6V3W6uTC0uByQqHLnN7J2kaRgcYAoLuUe2HyAWnNtxvrGtp26MjVbzHjHZ7ama9sIANiwyDJxPV4xAGiV9/yIRK4vJNNN+XZWplD53BCoa6hxsbvpYMvgNizn/mukByW3JZp+/Uejll1MUJyhN/VW2hXdgfXBvtww9w/3Bc1jOcJYHM/blCR8T9xMdM645dHmx/i9V+r8i0ns44UowjwrgHrQ6eHCBOLLLAWOy0BawOtu5jU8tT7fDSnUOA9cLmptW/cN9ljgp9OrCqppeRJ8nNSf3RV2X00SnXAcB044t3nNZ9Ey/qs+ux6IAinDEuVxto X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199018)(36756003)(31696002)(6506007)(6486002)(6512007)(2616005)(26005)(186003)(41300700001)(316002)(4326008)(54906003)(8676002)(4744005)(66556008)(66476007)(6916009)(2906002)(5660300002)(86362001)(478600001)(38100700002)(66946007)(83380400001)(31686004)(8936002)(14773001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?EmjHHUMdGD01lCDlMqMjIjd0Q3xP?= =?utf-8?q?oFob1Yzg4oQGSQCZ7HhSc3RXOWzX16kwOoy+JicGUhMhjqxf7FcdmlEKlyw0+7/Yw?= =?utf-8?q?DdvTF6tSKb5tgUglswUZ0Mn0bZz9wMssZ3BWsN0/oAMgQnh66nLqMCISOndx1tsnu?= =?utf-8?q?sk2X7L+Y03y4D43boE7QzJjxU8eUXZFHgSszMVXy0b3ZRx/ums4YnAy1JfhlCLHMZ?= =?utf-8?q?7TBt9Sp5XTuPein7PuuxQJynpYUYFP2ZwyvjS/WOWCrrxMVdUd9CSO95NkN9tO4lL?= =?utf-8?q?KNOjNNYhh3xv4NZExi52eIiiY1HA0ZMs/KnF+0ApvYgcYQc5pv/eKxgugI5G+npBG?= =?utf-8?q?omviVD3GQnhYNxZ9CFuHny+qEOBeuPyAtMcML0HjDT9yIHPoH6G/iee8rJ/yydyKu?= =?utf-8?q?rx9aAJEeIPAYu7lUVYsrOVHiWg6rVjk7cPAELNYC6dzj5SdDELRTK917IQQLBU1Jz?= =?utf-8?q?e5iStaeXeQ9Nw15r5Yn8Y9H1QJ/06+1LC//7NCjFZzpy8somMOC4bMZKRTvD1+vg1?= =?utf-8?q?2+07QoDS547lAy8M/AOfaiWCwgClO8anQQEoOjg+zuHiDXeiR/H6M3qvDSesrhkwl?= =?utf-8?q?BvYyUuj+k+2L3QzOdFG470/PeT2eJIOmec/G1R25XJjgDdyNZ9k31sjJFBeIMaczn?= =?utf-8?q?eBkONqZYBNFFMZG6liH2p+BUQbS9xlp6eRVrR+8wxozc6r5l2gi1cSP2yRgoN/UAB?= =?utf-8?q?LhpqgZ2CA026YEReUOolnVBCZQMtePon9YTy1d7CJxoJi0itdQwDo/q9/2QSgmQ01?= =?utf-8?q?3KA0Yh/h9dLkB5k13Sti8OJtvU35D1gYwB+Dt+300eYHK3qQZJgiVyJVjZF6sh5CK?= =?utf-8?q?on6Q9wg4A9Xi2x8GgtR/U0zNa17LibbH62TjtrhWWOnUUZiDOP9D0hmVz4UJOV+XW?= =?utf-8?q?KjGM6R1QgCC/Ldrzd4UC70zsYfKB1xacXvEXl3Q1gqEwcKMxTVmVftrmKKta0i+Ok?= =?utf-8?q?srOiqbxD+vkKa93qkhLYcBvYIkXEHkAIX9TxXtxjh68kfnpmxsKUZ+fPVuPBaOyOG?= =?utf-8?q?O7kHE6zDBkKFznIY8cC164aqZWd1zMKhtoOyM1GH29m37E0eOLxG6vPGXnSNYMaet?= =?utf-8?q?cN1YtYEMliVreqzsIssZd6SIzUYQfZ6SiBgCNXBC1d0FNObkKW7FCHWfSancYyDgK?= =?utf-8?q?YZ97XY3TvSuQX51PEZP6k7wGyF9p6I1z+kf2IjC88YIFOcZFLeVDe4wgOC70PpY8B?= =?utf-8?q?uNJShHFTut50gwI489HPHifZoCSjdmBJbd1Q1XZknT0w/3V8pLvd0oZUINdMxdoXG?= =?utf-8?q?b5fYzroLhIbXPIu/0/888QuQ6u5PS8xIfz8qb72I3nbSYjMHsfxMPZZkZ1eXFqiJ1?= =?utf-8?q?wA8L7Ho+kn+hM5ae0sCCIY5KLCil5pDNhSlmXlkc02ju4z6EkUfXHaYLWbJZwIEWr?= =?utf-8?q?8vTl1QW6cvHfqmbOQnp+uyv6NB7v2xJHvpThYy+vKWFoO7kvX/D/dp4j/hBQ9ps3+?= =?utf-8?q?RAbRJnNjr51YoFFe4gLcLz8Jsx6tiDJ98NeuZzi+D1d8XNu/KWyhsFdyWZSv9m+9R?= =?utf-8?q?txCmZg+LV7Oo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31f079e7-83c1-4a8d-a69d-08db1be7d5dc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 13:04:34.4334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: adVOe3Ty8DEBJ+XByMWPrGvqH2CVTBKwgb/tEN9PYNqhCN+A1teW38gy2lgw/fk4pO1LdDaTfRwMyRfzVH9WwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7513 X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> From: Jan Beulich via Binutils <binutils@sourceware.org> Reply-To: Jan Beulich <jbeulich@suse.com> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759352011204806158?= X-GMAIL-MSGID: =?utf-8?q?1759352011204806158?= |
Series |
x86: new .insn directive
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | success | Github commit url |
Commit Message
Jan Beulich
March 3, 2023, 1:04 p.m. UTC
.insn isn't going to have a constraint of only a single immediate when, in particular, RIP-relative addressing is used. --- Of course this could be folded into the relevant subsequent patch, but I'm wondering in particular whether limiting the new behavior to .insn is actually necessary (if not, this wouldn't be a good fit to merge into that later patch).
--- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -10065,13 +10065,13 @@ output_disp (fragS *insn_start_frag, off if (operand_type_check (i.types[n1], imm)) { /* Only one immediate is allowed for PC - relative address. */ - gas_assert (sz == 0); - sz = imm_size (n1); - i.op[n].disps->X_add_number -= sz; + relative address, except with .insn. */ + gas_assert (sz == 0 || dot_insn ()); + sz += imm_size (n1); } - /* We should find the immediate. */ + /* We should find at least one immediate. */ gas_assert (sz != 0); + i.op[n].disps->X_add_number -= sz; } p = frag_more (size);