From patchwork Fri Mar 3 13:01:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 63899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp395617wrd; Fri, 3 Mar 2023 05:03:58 -0800 (PST) X-Google-Smtp-Source: AK7set83WSW0gVSZodfOT/IG3LKVNliGrnAa1YILxdsjb2oOXr36nsJms3JWlfB+GYWc4bFdi29w X-Received: by 2002:aa7:d714:0:b0:4a2:5f73:d3d2 with SMTP id t20-20020aa7d714000000b004a25f73d3d2mr1423809edq.41.1677848638210; Fri, 03 Mar 2023 05:03:58 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q18-20020aa7d452000000b004acbe83b837si2717378edr.213.2023.03.03.05.03.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 05:03:58 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=n+pFiov+; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E31FA38493E3 for ; Fri, 3 Mar 2023 13:02:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E31FA38493E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677848543; bh=vXI4AKfcmS1hVO/djDct2anAyKN5Jqt2YsWluv6PJ/4=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=n+pFiov+7GF2KIrkyZKq57RK2NAAQaFhnxCDKidRZBwAZk4VH/JrB13o1hyFZluN4 5erAERwzgaPtOcxU94KvgeC/m5cDQa3iZMQiOTEd8IngpjtfAS2zOoXSmLPuChuZ20 ovSmLpHYaLRlqZp3uazEDRCZ5+dCbyIv6mvmjU7Y= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2067.outbound.protection.outlook.com [40.107.21.67]) by sourceware.org (Postfix) with ESMTPS id 2E16D384F495 for ; Fri, 3 Mar 2023 13:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E16D384F495 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mPREi+PRBupAYriP2T8tDyOZqgwi+i0mqdEUSMPEMUvw77DD7xb2flTxRVfvhhWpdrz2675PHQN8unznZcYzofuPGYFDV3Olb36UqMoBoSG0ndMmdE1ZgSF73i+LUIrQhZLSkrJfwURGKI50WMQeOLz11wvJxvZWIGG3X8fxM2Vg2NOS7Ei3wC6e+hYfFdsFHymTaVLEnjZMoJaXxtUrs7KnAgqMPbWQ3EfexpbfQEnQT0yzycjglVwXxkvlBrSQVsvSlJz4B38pa2dJX0Nnyrwkef3akaEeJ0XGT75XnSh3O44x2iekcEoWDu5ynAs70RKYPw7/KxaPAU6GC+cFgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vXI4AKfcmS1hVO/djDct2anAyKN5Jqt2YsWluv6PJ/4=; b=EkFc0T3IVHdnjiCuqNh/BWGDdqms2QEwvJq4GBZuzfsxsOerNI7pq9mfJlO08kHk0Y8LsH0jvpW35u/pLs/0j1xLpEzfddKxWpI8F7vPOdYKSl2gFZ2ob0+iZcSM7QZEoQVG5htMymXlr9d87cpXSPL9K/0+hncQf0iOAW9I6BEO84F+CQic45F55Az0OJaw4qRO70ZauH0AJRON3L1sQ2+xrn0dJqKwJiTsrZCFWVwQGoKkQRVx24PnkHCGDLPwsD2fdHQxYjNZtvB7Sutg2bYlV7ZY6Ta/v5fV0Q5Vq2uSjVHbij88YFamdhFoKkD2tuCRuz+OXqQhoh/1EuWfkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9222.eurprd04.prod.outlook.com (2603:10a6:102:2a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Fri, 3 Mar 2023 13:01:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6156.019; Fri, 3 Mar 2023 13:01:43 +0000 Message-ID: <42f27545-f571-c78f-415c-50817730faea@suse.com> Date: Fri, 3 Mar 2023 14:01:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH 10/18] x86/AT&T: restrict recognition of the "absolute branch" prefix character Content-Language: en-US To: Binutils Cc: "H.J. Lu" , "Jiang, Haochen" References: <764b9e03-18bd-6945-692f-a250522196ca@suse.com> In-Reply-To: <764b9e03-18bd-6945-692f-a250522196ca@suse.com> X-ClientProxiedBy: FR2P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9222:EE_ X-MS-Office365-Filtering-Correlation-Id: 1503a6f3-f1ab-4ca0-28f0-08db1be76ff4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lidPzUt02z1c1PihDJB0oGYfGb7dY4zEIstfbBCd4TjJLrS4mbJwZgV02dSDt0XVLiyUpbmd0UVhBZVDDhq+0Cjv472bTJif2Mqf04vpHy9qnEVhQl73al4Xw6Xw7hNqggOfV1tPmQtoh+b0/zAz+VHsrvTTwOgncYD1ND1mo3Ff640EbT3tUe0qLG3wTjU/fDIYKcXLHOkOGlyxBsWlU2Um5ZxxMOqTE7q/wIGKFVOexpwU32tqk308OWTsJLk3U9LvB/3oAA0Gah95DPNIt9AKZo+0vx7zqlK5WEKqxcc6XHowJXrhf9onFWn7wM2R33nlDRGsNwZqDFRQUC0De7/SWIIGI2RzAhJrUz+9eYYazLQNRU1bPo/EGLWbFukRBtr+RFb1Buw9el5AjbAEocJ9dAVIezMbgQfJlDLSaoY2nEb4m78RHo8wylafFk0C1MgiTUNGLBbMm0TaYAdRYKTKNhfIrUd2GDcv4DjvhQaf/kG+S6EfN+/VrFMbYwHTmkDx8zJNfni47/D9yyWtUL+YQNx8G4W/8k5RLm/cumjcLNvr5UutGwkuu5IBr51xG+hebcQtmCtP2uHcI5A65P6XgC/Pd5w9d9UtVUKLYZLSWcHYZeP1qmVkOfzEdk4Dvi+vm4H0lnb9XbZ1qI91vSTtnFXl2a6kF+kOiEfOjPGxeMmPlhnaQK/AcwgFVno2+wjrIKBcPu8t/wsjKbGakWLtLkqAN8Obv/c83NuIbnI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(376002)(136003)(346002)(366004)(396003)(451199018)(6486002)(31686004)(5660300002)(66476007)(4326008)(36756003)(8936002)(41300700001)(66946007)(2906002)(8676002)(66556008)(316002)(38100700002)(6916009)(26005)(6506007)(6512007)(186003)(2616005)(86362001)(478600001)(54906003)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0hxZb9h8BepuT9H/qD1gwo+IGQVF?= =?utf-8?q?97zo3NCo7pI1PPvcXUtZpdNqC4cCtm0e6n1Lh+mKfKwHwtg2pP5JAHtlcQc5WQZoh?= =?utf-8?q?izRc/oYpn7Q2kdlv9JGyA2wkk5/bS2de6n2+Ww47S00NeyC/bw7gS2Uh7wmYSLO0N?= =?utf-8?q?XlMJV92iHuo51aKI0tXhj12riibA0Wzqt6TBAmexusAfL7CAZ3DL1B1Znxdudc3a2?= =?utf-8?q?4eSdNDqk5+SRXPvOfu+cJfwOti7AWxTTpVxRqzEPeO+nntqesTBCSZ3FdN61QrCO4?= =?utf-8?q?EKH3+FTTFokbUvTFiTTPrRIOQcyuuWHqWRTo/OeTqhIMuXu2ls0cFxMC3iHWjewr8?= =?utf-8?q?dH/oWz8ammIJ+oNgl0oCHIoSe+tmAffYJb9CVuRhImj4FxDICLqSnNLfD3ocgSu/p?= =?utf-8?q?pZZCleL6w09KAI51m9c6CKa14wmAgOJP1Q9Yr6lUlUBtbLBY9XzRbfLoyIYBTV2tO?= =?utf-8?q?9tmjocAYS32PYXs4Gi+VxCyX4HTpRj66UlsPeh0VS43If4885ds3UCx1ZgyLXEZ6x?= =?utf-8?q?jdl1mZTLAeaJlTGEvnW546JzLgkAZnHQRchBX+n7rA1Do3PhzLbhHwMxafq8eBUQ8?= =?utf-8?q?G2tZ6z1YWBG0W52pmZv9axUjgHOULNl6WVZSzo/iFic14rGicJBYO5j3dnYKtNN3b?= =?utf-8?q?tMSwrrRHGJdn4u0W+Tj9fCQetCLBCeLZy41rk1gWoEGasvgKTAbvsVl5NMy8HVuR1?= =?utf-8?q?dYkAX26PWl2Boq9EwH7qoOP6ou/ggnJ9uL7YtS/X8e+SLlgek2806Ei02suWWgma4?= =?utf-8?q?DrVi8suJX1UThHLYOLR8HSz96biaGizSA6W3hgdHb5sF3BH9IzUFBK8XqmlhBM+Wk?= =?utf-8?q?eE3SvdfD/NqSLGeXON9yQnLFcXIg0/eycaMRyLpywzIGTx2ey2rBph1Ds6amNMFaB?= =?utf-8?q?9yVpYwAjb3dINATV0y38g/htx/wtYKaqpEJc4j8Yrti2jaFx74cCk4oscoIW9CvCl?= =?utf-8?q?tnZ3T2FhMY4B8G16QahogJWr+/pYV947Hd7L5OQq9fmXTWNiaA8Wsv4auUikjckeO?= =?utf-8?q?/9JhpmqXyQUDOHK+xdFPg05FWONQEC65voM7kVbXpPN4q9zKkqN+0x4Woimwgy9Q4?= =?utf-8?q?YYpXfVFl43BVsqwVhGG/GfSFA783XIUKcmDbU/tKlBKNcdHfsaS85IPmHfmwBoV6f?= =?utf-8?q?4xhyhRBdd/xjNvpFGuA7fSrWJb52D4dom5daKvH3NhHjrT7l+g/62lmJU8xn2FevW?= =?utf-8?q?MIIDHnoXTGeWRa6HlsJOrCW0hsjpyRDWyVLSEmX+ca5wqXQzodqKEfEvs41Z9ftwv?= =?utf-8?q?TuAaory5+F4f1dR/b2oVwsJljipLIZsieMlNpXdxBo4q1JxmYOoOwwUsycla6y0Xo?= =?utf-8?q?vZd8t15HX0/zxssrbUUPMch2DhD/+AoPfRYhqRmRZ5B7gTSnGVpLfyjvgSPrvcwji?= =?utf-8?q?f+FzunLpVF2ixJ63AkvG9VYe/rfqf/feaMjXM7t4BRCUNjEGjyOYr7bQGepMSaK8/?= =?utf-8?q?nvByzsLU9FW49V8nrFwDOggIuEcZkmTZiitPWbNSlHwjiXftS56QSdq5TgbzqQX/o?= =?utf-8?q?TOGD5TnZdkJu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1503a6f3-f1ab-4ca0-28f0-08db1be76ff4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 13:01:43.4130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A2SH+43X+BSW4Rt942waA4vVMlMjKIXKatqJ0utJt6TwNV3GlpKk06uY8QEAQGh7HCEZQ1dAVsnjCL89n2sm0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9222 X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759351813560186871?= X-GMAIL-MSGID: =?utf-8?q?1759351813560186871?= While in principle merely rejecting this for .insn would be sufficient for the purposes there, be more generic and reject it for anything that isn't going to be a branch: All elements of same-mnemonic template groups either are branches, or are not, and the few cases possibly requiring a 2nd parsing pass aren't affected either. This then improves diagnostics for misuses like inc *%eax incl %fs:*(%eax) add *$1, %eax --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -11836,7 +11836,8 @@ i386_att_operand (char *operand_string) /* We check for an absolute prefix (differentiating, for example, 'jmp pc_relative_label' from 'jmp *absolute_label'. */ - if (*op_string == ABSOLUTE_PREFIX) + if (*op_string == ABSOLUTE_PREFIX + && current_templates->start->opcode_modifier.jump) { ++op_string; if (is_space_char (*op_string)) @@ -11867,7 +11868,8 @@ i386_att_operand (char *operand_string) ++op_string; /* Handle case of %es:*foo. */ - if (!i.jumpabsolute && *op_string == ABSOLUTE_PREFIX) + if (!i.jumpabsolute && *op_string == ABSOLUTE_PREFIX + && current_templates->start->opcode_modifier.jump) { ++op_string; if (is_space_char (*op_string))