Message ID | 40ab94c5-d0c4-ee01-a53b-dbc6e5f3f9d2@suse.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2391279vqm; Fri, 14 Jul 2023 03:02:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlENRKw/KJNi2nezHE7Sz1My2++YbIBzpDs3TYYrq2en39q5+zDSBbYjc6tglCBEX7g+wO15 X-Received: by 2002:aa7:c387:0:b0:51e:26dc:b35e with SMTP id k7-20020aa7c387000000b0051e26dcb35emr3159660edq.21.1689328952195; Fri, 14 Jul 2023 03:02:32 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id f14-20020aa7d84e000000b0051a3fb6c050si8614099eds.187.2023.07.14.03.02.31 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 03:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="cLpi/B4M"; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7EBE23858418 for <ouuuleilei@gmail.com>; Fri, 14 Jul 2023 10:02:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7EBE23858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1689328949; bh=Xp7E2XTnZ+FNysXaKgSi++eGyfSgSsr0KixLdfmmF9A=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cLpi/B4Mc5yfCzD47lLz0VqZifqwndxisA8DAK4ygYZsVGJJPGL9oHPxkKFV5Qvh7 wYu7aA23l9IE0tz29x+2PffIW6nbopibIg3C2zXuUXpYbir4Cm1/u3ZMG5SdHr5bLl uRorxrBFqYHKPZ80AJakrAFa6eHdvVix8PKFOg68= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by sourceware.org (Postfix) with ESMTPS id BB18D3858417 for <binutils@sourceware.org>; Fri, 14 Jul 2023 10:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB18D3858417 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktASOjJjiPo8VbWoXXW2gsj7oP5IXGAPfztMB++QIbk/kzXg36BDnqUficVDXCNEtQqbWQnN6li1uMX2wwlmKXcbWzWA9VfG6j7VARRCpsqjJXYdOaeTvJFKNxrCVblZChmXncN/GgxubtGl7D3QEtv5wTZd57g/et5TAqa4Ikrzs1TvzIUdLEObdhjaYRTGE4HLk/TkJAN8dNtfCHZWRlA62tk3bC5UhfmXB/j9egWFQWU2Kc4NBUFCT5Wn2mlrh3pLWGAcd9Oo81xcvdp31A+dF58NLxfEHMotG7HBE5RWqgTO6Zw77Q0GS3gFWxG6TM6sRRFqNFgwaTC689BOYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xp7E2XTnZ+FNysXaKgSi++eGyfSgSsr0KixLdfmmF9A=; b=F0ZhHw6LRTUMO9WXXW0VaVYcjMOXvHNJOTHnyoueFdRq3sZDlYINfvfCoYlxPEdHSgzcWP75DAVK6i8xR1RyM9cRNQhY8UmmBuRHO5Kqg9ohanU9uVf3duyS0Hb9KLPkIOi8WSuzNExp0ZwdKQMkagEEaSbvY2M/Ml7Mp6SITdY1P+baunsvSYJEH70m2KLHg4YdouBJeoCOUsnvxwIMBWgCGsMeZg89jwnZzFLJhwh9P8k8sIgZe3lv2Bi7A5ceTUgCA75vWpCT3fhSyq+WB0KHuHtsHkxmWebsrnQgI7Yh0IjeZE+1Jqza/2ndNBRmfV+NMFRfk1AHpWi9Rd4+Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by AM9PR04MB8177.eurprd04.prod.outlook.com (2603:10a6:20b:3b7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 10:02:19 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Fri, 14 Jul 2023 10:02:19 +0000 Message-ID: <40ab94c5-d0c4-ee01-a53b-dbc6e5f3f9d2@suse.com> Date: Fri, 14 Jul 2023 12:02:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: [PATCH 1/2] x86: simplify disassembly of LAR/LSL Content-Language: en-US To: Binutils <binutils@sourceware.org> Cc: "H.J. Lu" <hjl.tools@gmail.com> References: <3f44f9a7-2f4c-d92d-ec19-5023f317357a@suse.com> In-Reply-To: <3f44f9a7-2f4c-d92d-ec19-5023f317357a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::11) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|AM9PR04MB8177:EE_ X-MS-Office365-Filtering-Correlation-Id: d395599c-b20f-4444-e935-08db845168eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g5mIwVw8hI8WQHKS/GVNv/kItWG1kGqLp+12kco8rEVwExp/5B6V9P16qZiWRdznkNMzkmwwkMfro0TKQqv3J/px1cMAmDcCSFeIOFQGED9pIKs+eenc0C22vZBYBAAb0EseJNAXvNGAN/o3HXYFGhuCdoYAmpWgqfLq5MVchTBp9hRNPyCBYEN/XPJtRBNmUOOoLgA9XiCBko6m4ZeKIAxOzCVopnGP3wcOpG+SJswW/p2Ds7f2coOkFJRvY3PgIfjDFTN0gecMCJClxgbCBBC29kvNYDkWWfJBPXuBvKVeoeAkEJXDubOkGsKuIk27DflC4efc2yyt4kw68rFa6K8cn0E1k4viPGtFnogdPydhnOlJP8KCLjeSI0DM2UuijAMDsbyXZwCKufrVxP2eRREIEs4DH4T3kVZE3U2dYqQVzuT9FfPavBMxzXdCz5SfCBdgYLF1c+OH5R1m2iJqvnImYdjtTgeI8eac5/7NEcWhndZxt+eadR6glBfIuGWqr8f7CM1wEFqA77H359QUqzxsTnfuvBqyHhV7wrb2Y30cORHxKb9SRd8w0anlLYpFYpX1hVRRbz/kZLVsnOPvyGUICljzkl/xrAE7CFsjidEz0tguGKBoqJgxH/AsejAK+IrqVWnDrScRzDmRXgS1Ew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8788.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199021)(38100700002)(36756003)(31696002)(86362001)(478600001)(6512007)(6486002)(8676002)(5660300002)(8936002)(2906002)(316002)(41300700001)(66476007)(4326008)(6916009)(66946007)(66556008)(31686004)(2616005)(186003)(26005)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?P2IhlR2RnFvLlhhcfeeb05XOzwUT?= =?utf-8?q?zL745vp5TMW22ziTQmA0rtcgVvNYwdwEICF50bSJOcCCgn5FKMI7ZxjD9Mx9vbL7F?= =?utf-8?q?5eiLMzT6bhyY0ZBR2itpQeAxD3D8jkJEp99VcdIiR8gmepYqGFKSY6y7bpbt45d1c?= =?utf-8?q?CyfyWKb4v6YRsIGkECxvICj5XjMEQ8kKY5bhEPfn9ljSPQVbnZZ8FQ0AuV7jtASdg?= =?utf-8?q?da7/Gm7LL1klsrph1V8/sY/gWFzAQPcvATL0v0xvGfFk/ZgV/zoKK2/BITIu1GO45?= =?utf-8?q?Qo1zl6L3TCDNtE/985XVPLFmejkTkzofI4iBbCMF1WCMQloSq4+6yXYIh4qhozYYc?= =?utf-8?q?uxcLglHL+bv00tcrB0lMq12aF0lEwKWrlRg5F0B4OodXz1pkqXVdNAoGN1otl2EFt?= =?utf-8?q?HqMotSKnmpegfU8EGH+/r/uwVOBaEGicmlaDuawvXBAsWKpUblfBlUP0fa1T+Crvm?= =?utf-8?q?aSJE49Pe7Y2+DoJNVFzesM2VosF/4717c4qt/JaiOJ9Gb4/2tePP7aM3vijomH3RH?= =?utf-8?q?qbwJhZONBdZJxAC+UywPpDFKd+RFLG4Kp+BXp6Bbissam9k9/Ka1jNQTiXvra5fla?= =?utf-8?q?U/0j29Ly+Fxa6XlpjPwRc1WdYtyKYkO9zYDOoI/kslhK7EKl7zlHqPZ/K5jwDhqTu?= =?utf-8?q?5VsLa5oVc4Orsmq/VJgmk/19JoosNqV/SnKaMasPOksuxThkOIsgIZdAykrmt2cmp?= =?utf-8?q?U9pveuu/DxIwvIXnLnQJishA2WRbI42qOhsXr8mqkctSmYEiA/ZGBJYGbjbjX774J?= =?utf-8?q?quNZHVDvwNQhwT/5eGWrtd3qwoClmKI55XaruvfLfBdmm5yfV4WmpSivzta6plkRa?= =?utf-8?q?dfi6NCW0t+8My0xTYkj8W7XuIctGYlAP40DGKNIjIESFToBV0PZYjHR80jpgDhh9Y?= =?utf-8?q?2qop7IM6N3xjlz94gIcP0gUJQk+WIV/bak1G2vswJtt0L4x49oAhsCOm404Y9x5FR?= =?utf-8?q?XK7Bmra1QRwfFoi9bPPx1MxS8WFIEQIsyIMMlbK0e94tQYGtuhX9huWyEZjBWHKt/?= =?utf-8?q?0/3AfSRHnqKgxcjrgygSn8Lq6YZnjI0QlacpEW68QNG4vl7qkfDzHy7SsV2/9rqXD?= =?utf-8?q?wj4GqcrbR0XD/MWX1ZKEVFGVsY3mB77+R0B2NDga7CoisKfJkQrw/jUMhTnP5Lq4e?= =?utf-8?q?oJsJEMbppipe/TBnjFu6LlcmYvMSaDgRA8Tnfadr3s/93xb1OJFYwW9uTx+PvsjEk?= =?utf-8?q?tFSrv5Gxw+DWe68v+U9u/b30OwODagOdn772XQk9TkuL7COZqtIZ7xZVuDecOiPW4?= =?utf-8?q?VXLpxoGyV8DgGz8DOfbKgWg4+JqEuwz3VnO9bbayPZpqDOYa9/cpUWrNT8z1yrrm4?= =?utf-8?q?G3URLEdYizybXJRsiFDllEOhIayU51jQ9aIvq9PqGf9kpVQAf/suzfHSHqlUOi3fj?= =?utf-8?q?SaJAXJUr2QmWrkEKrEPqDkzuDnh6IMC1eZ5rcHdRTqp+hvYNYXfrf9SQunhDQIVF2?= =?utf-8?q?DO4V74SZ4SOkaRQcpQV2v2ArG19Sn84UfDl1YElBQHZgjL3JE4GOQd2zuETPi0mlg?= =?utf-8?q?lUO93eDmZGOc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d395599c-b20f-4444-e935-08db845168eb X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 10:02:19.2271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wSgWleawhsHj7Ra0gK2VUOZsXlZ0YTOvQ6ll9NyEmwXddGyGs0O0JVskvaxRToCG03b6RZVnaK7ArxmUakWGvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8177 X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> From: Jan Beulich via Binutils <binutils@sourceware.org> Reply-To: Jan Beulich <jbeulich@suse.com> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771389795140645439 X-GMAIL-MSGID: 1771389795140645439 |
Series |
x86: adjust disassembling of selector-access insns
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | warning | Git am fail log |
Commit Message
Jan Beulich
July 14, 2023, 10:02 a.m. UTC
For whatever reason in c9f5b96bdab0 ("x86: correct handling of LAR and LSL") I didn't realize that we can easily use Sv instead of going through mod_table[]. Redo this aspect of that change.
--- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -867,8 +867,6 @@ enum MOD_0F01_REG_3, MOD_0F01_REG_5, MOD_0F01_REG_7, - MOD_0F02, - MOD_0F03, MOD_0F12_PREFIX_0, MOD_0F16_PREFIX_0, MOD_0F18_REG_0, @@ -2018,8 +2016,8 @@ static const struct dis386 dis386_twobyt /* 00 */ { REG_TABLE (REG_0F00 ) }, { REG_TABLE (REG_0F01 ) }, - { MOD_TABLE (MOD_0F02) }, - { MOD_TABLE (MOD_0F03) }, + { "larS", { Gv, Sv }, 0 }, + { "lslS", { Gv, Sv }, 0 }, { Bad_Opcode }, { "syscall", { XX }, 0 }, { "clts", { XX }, 0 }, @@ -7895,16 +7893,6 @@ static const struct dis386 mod_table[][2 { RM_TABLE (RM_0F01_REG_7_MOD_3) }, }, { - /* MOD_0F02 */ - { "larS", { Gv, Mw }, 0 }, - { "larS", { Gv, Ev }, 0 }, - }, - { - /* MOD_0F03 */ - { "lslS", { Gv, Mw }, 0 }, - { "lslS", { Gv, Ev }, 0 }, - }, - { /* MOD_0F12_PREFIX_0 */ { "%XEVmovlpYX", { XM, Vex, EXq }, 0 }, { "%XEVmovhlpY%XS", { XM, Vex, EXq }, 0 },