From patchwork Fri Jan 19 10:51:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 189513 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp924374dyb; Fri, 19 Jan 2024 02:52:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCEai9oflmIc7EVUGZfKc2E8jGDzCSIJdu+T2VG2Q/jA1wDqI10cQRElX+NYoE1/GcT+Ff X-Received: by 2002:a81:9301:0:b0:5e8:f44:b8d with SMTP id k1-20020a819301000000b005e80f440b8dmr2126247ywg.36.1705661522255; Fri, 19 Jan 2024 02:52:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705661522; cv=pass; d=google.com; s=arc-20160816; b=A3s+PQix7pyMOtT0dYEN/kOdG0XHRGpMxL6iXWBD97DuRwwc96USxz9qF0ziikZMvp RbF8pnJZDKddq6V9P6rTXXp3dzPA3ibDIWmgzJ/P0TQJRtXQzNjgw6A2yLM49CaVl0VJ jRCW/8TMaCUHVdPU8psDs+kRLLGErALgkiqmN1C4FPDG/DCBQxbvPOIRJVZ59lrW8aZ6 D/qtYTxRezCi6jApoeKjOZTXNA5vUnRQRC0ALEK0yHg7ozMYXYfP0aZgMzEOOwFWgbpv rKhVyIb5KHXQIgzzEWi56026n3RFBZn+cFYcZ3WjkyQILVaqf2iLDuq71quT+4GNDqEo Ws8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :autocrypt:content-language:cc:to:subject:from:user-agent :mime-version:date:message-id:dkim-signature:arc-filter:dmarc-filter :delivered-to; bh=ew0mdlBX5knyxbvSWCYf9vYEVScNl4+OOyCgcmGIlRk=; fh=Plzit+QOfT4w9lMb6sCEH7MLCHiIRZ4B4v+R+r5+YtY=; b=G7ur3sxTPDeGtCamylEj3JBLJIN7JVdtdDqGndsmHAxxvuHWiCfGmuPH2PV08BvD2y ipcrC4pG3HkbdlqWzeWiKE3eqDwCoJBxOlfs7RHPPe1I1yYDCPs0NFzTfZM4Mv4lcwrI vKQMhTcOEU4JHZGy03P1EUYzytfudV4wTB44XD4LrtLaz/wLndynNRfjokQb9NhI3IB8 njjAIfonkMhaSxsS37H0uFEgJry/zD9lzJ2TWEti8z0YAMQuGCJ+jvZjSPIEL6/uLDue DErMOxSXT0PFZGZt8w6PoLHyCPzZaPJalmYBT13J6CNGRYW1Iyjb8OYQpAvK1jhOB/Cd 6a8w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Q3FYKiQL; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id p20-20020a05622a00d400b0042a0ece12c4si5464940qtw.247.2024.01.19.02.52.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 02:52:02 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Q3FYKiQL; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D8B43858010 for ; Fri, 19 Jan 2024 10:52:01 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 634893858013 for ; Fri, 19 Jan 2024 10:51:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 634893858013 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 634893858013 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705661511; cv=none; b=M/4zPXtrsX8Ge+102dMDUHpkeMnqRTBoPj4vQ8AyyQ8lE8s9g82Y9rSkD1/u2QXEm7p1enKN7dXSTaLPa2h4TmC8+iEKmOSJmLFn9zhzdB7mNSHj4id+QSjE+xQ864M/UxooDvz0lfSzwI0FdWKeXqP+zIu1Z3nyYZdrNprwr8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705661511; c=relaxed/simple; bh=hLLWFPSIVvXIVwSpqUiBiPFhIoovLyk6m6eAYzTJ3iE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=RUBHe/aTEcyIu7fXsfIEPMDIUHFEgucPcrjX+QUGBzFV07/7oSmE3g51gPpAopfLYxAj2hOsmHLEMPjoNhORcQ6Q8TP4TjRkxJhImtoSKFsskfbwgSy8Opd3bSbM/MJuhjjF9ZgzwSrPNgLua9irKLVNlMjSATQgVtukQJj6BSk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cddb2c2b54so6739541fa.1 for ; Fri, 19 Jan 2024 02:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1705661506; x=1706266306; darn=sourceware.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ew0mdlBX5knyxbvSWCYf9vYEVScNl4+OOyCgcmGIlRk=; b=Q3FYKiQL28TcGmOZg03RJm6KJroEjfdzjq4idGvD6fr4U67uKzjvNwV/4gBnwuRcwt jHE5395L4QY2H5I2gcxMjTi/VmDeDMVzwxyoICY2jH8JSC+dCe2RhXLQAkMC/7zftCVd bRJFVY47ZT9eLSWmqXe6RfV/KVzBrLxg9xuxkcDWWdjNF8ho8qUd1dPsli1nb4WhQd3J rIIN1YdSVx6Yr+ye7nQioisAEQdcospGq+n+XAdd5XM7X//PFlAMT6SiBcdpnYUjm1/b erWA3wa8A52Sbx9mDR8CGFskErVP1ivZGeX6IKgYVyf5H+faItN7kosxFYlYrhpY+YQn KbQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705661506; x=1706266306; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ew0mdlBX5knyxbvSWCYf9vYEVScNl4+OOyCgcmGIlRk=; b=B4QKFKYPp2s5j5wzmNF3qqIK79EJTg8AptLx8KoTI1HTtXeZ9NzfYPTpeDpmFT5dbX BZl1J77v6kDQsxJ8WgP2L4/PQLS3BIeaA8RjQVnttC2xv1hjflsDNO2/tW8NaOfbOgpi TVTFCWEmgdT4Lt4yR1i3+HMS3gfx9TyiSEGj2pg3y5TGTa8n+leOmfIakzc0Qkm0Zgi9 ll8XUHFXUTvkRd9ikSc9UbVNpvEiBG4xs5Pj8kGP4+5Gt3KQqVKOvhYhENtLSbvNcPds pJGjDEYZ2v8EdgJNcrIAoHkm1U7UefIcNvaGpp0Ukc8KhFi7VdhHkVkXYpLMk47pEgf7 OElA== X-Gm-Message-State: AOJu0Yxxp0H4ak4oZFTuHu5VvoXiOtRmdKkeiP3ZHFFDl0i5NPFrDQIN ex7dli6fljil9y7lh84pT4BphwRpyybXbz+B1wyfXc6qWz0QS7Q/2eB+oY1PyDbMgVL1kAOF4vg = X-Received: by 2002:a05:6512:1328:b0:50f:5e1:58db with SMTP id x40-20020a056512132800b0050f05e158dbmr726956lfu.111.1705661505787; Fri, 19 Jan 2024 02:51:45 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id v3-20020a5d5903000000b00336c43b366fsm6199720wrd.12.2024.01.19.02.51.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jan 2024 02:51:45 -0800 (PST) Message-ID: <2831b090-2787-4b5c-b5ab-2197bed110dd@suse.com> Date: Fri, 19 Jan 2024 11:51:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2] x86/APX: optimize MOVBE To: Binutils Cc: "H.J. Lu" , "Hu, Lin1" Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788515736447580825 X-GMAIL-MSGID: 1788515736447580825 With identical source and destination it can be covered by the NDD-to- legacy conversion logic as well, even if in this case the original insn doesn't use an NDD encoding. The size savings are even better here, for the replacement (BSWAP) not having a ModR/M byte. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -7858,10 +7858,11 @@ match_template (char mnem_suffix) if (optimize && !i.no_optimize && i.vec_encoding != vex_encoding_evex - && t + 1 < current_templates.end - && !t[1].opcode_modifier.evex - && t[1].opcode_space <= SPACE_0F38 - && t->opcode_modifier.vexvvvv == VexVVVV_DST + && ((t + 1 < current_templates.end + && !t[1].opcode_modifier.evex + && t[1].opcode_space <= SPACE_0F38 + && t->opcode_modifier.vexvvvv == VexVVVV_DST) + || t->mnem_off == MN_movbe) && (i.types[i.operands - 1].bitfield.dword || i.types[i.operands - 1].bitfield.qword)) { @@ -7898,6 +7899,12 @@ match_template (char mnem_suffix) --i.operands; --i.reg_operands; + if (t->mnem_off == MN_movbe) + { + gas_assert (t[1].mnem_off == MN_bswap); + ++current_templates.end; + } + specific_error = progress (internal_error); continue; } --- a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d +++ b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d @@ -118,6 +118,9 @@ Disassembly of section .text: \s*[a-f0-9]+:\s*67 0f 4d 90 90 90 90 90 cmovge -0x6f6f6f70\(%eax\),%edx \s*[a-f0-9]+:\s*67 0f 4e 90 90 90 90 90 cmovle -0x6f6f6f70\(%eax\),%edx \s*[a-f0-9]+:\s*67 0f 4f 90 90 90 90 90 cmovg -0x6f6f6f70\(%eax\),%edx +\s*[a-f0-9]+:\s*62 f4 7d 08 60 c0 movbe %ax,%ax +\s*[a-f0-9]+:\s*49 0f c8 bswap %r8 +\s*[a-f0-9]+:\s*d5 98 c8 bswap %r16 \s*[a-f0-9]+:\s*66 0f 38 f6 c3 adcx %ebx,%eax \s*[a-f0-9]+:\s*66 0f 38 f6 c3 adcx %ebx,%eax \s*[a-f0-9]+:\s*62 f4 fd 18 66 c3 adcx %rbx,%rax,%rax --- a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.s +++ b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.s @@ -111,6 +111,9 @@ cmovl 0x90909090(%eax),%edx,%edx cmovge 0x90909090(%eax),%edx,%edx cmovle 0x90909090(%eax),%edx,%edx cmovg 0x90909090(%eax),%edx,%edx +movbe %ax,%ax +movbe %r8,%r8 +movbe %r16,%r16 adcx %ebx,%eax,%eax adcx %eax,%ebx,%eax adcx %rbx,%rax,%rax --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -210,6 +210,9 @@ mov, 0xf24, i386&No64, D|RegMem|IgnoreSi // Move after swapping the bytes movbe, 0x0f38f0, Movbe, D|Modrm|CheckOperandSize|No_bSuf|No_sSuf, { Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } movbe, 0x60, Movbe&APX_F, D|Modrm|CheckOperandSize|No_bSuf|No_sSuf|EVexMap4, { Reg16|Reg32|Reg64|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } +// This needs to live here for easy EVEX -> REX2 conversion, which wants to +// restart with the next sequential template. +bswap, 0xfc8, i486, No_bSuf|No_wSuf|No_sSuf, { Reg32|Reg64 } // Move with sign extend. movsb, 0xfbe, i386, Modrm|No_bSuf|No_sSuf, { Reg8|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } @@ -980,9 +983,8 @@ rex.wrxb, 0x4f, x64, NoSuf|IsPrefix, {} {}, PSEUDO_PREFIX/Prefix_, , NoSuf|IsPrefix, {} -// 486 extensions. +// 486 extensions (BSWAP moved elsewhere). -bswap, 0xfc8, i486, No_bSuf|No_wSuf|No_sSuf, { Reg32|Reg64 } xadd, 0xfc0, i486, W|CheckOperandSize|Modrm|No_sSuf|HLEPrefixLock, { Reg8|Reg16|Reg32|Reg64, Reg8|Reg16|Reg32|Reg64|Unspecified|BaseIndex } cmpxchg, 0xfb0, i486, W|CheckOperandSize|Modrm|No_sSuf|HLEPrefixLock, { Reg8|Reg16|Reg32|Reg64, Reg8|Reg16|Reg32|Reg64|Unspecified|BaseIndex } invd, 0xf08, i486, NoSuf, {}