From patchwork Fri Feb 10 10:37:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 55383 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp876467wrn; Fri, 10 Feb 2023 02:37:44 -0800 (PST) X-Google-Smtp-Source: AK7set+MTYiqZElZr0yATyFrySpcD1JHQiUCZXoF/lzBl4IFnHkcGPKwaEeClchGEr1usyFhzGUZ X-Received: by 2002:a17:906:ce3b:b0:88a:cbd1:e657 with SMTP id sd27-20020a170906ce3b00b0088acbd1e657mr14478500ejb.5.1676025464832; Fri, 10 Feb 2023 02:37:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676025464; cv=none; d=google.com; s=arc-20160816; b=KW3T7lmHhW1o0ZGvzc3697cL+EQxbTF/AvoyULxxDht9ll7PqFirFNd6kI28ZHt7KM GqHbl98MZn4LBYlWpJGM+8tAYhYB1TaJXbHM47TgxWbm1+1S/jrHE8aBRLCo+92S7pLu llaych2ByKsCPHdSz8i/Nzv17sTcw+rWlUpv40p8AfDj8F66UewEPI08F0jgwNzXQ2AP rIggWcW++ynM1WG0TnfkZ524kEzwaB2OdDS2UZTdAkDwv8BeeTMowQulHSV8yDobqYsu bNpk30ebk57+foTe7T301uU6roA0HaMEn1gqB4fFEqV96XglbOmmdZGzan/X5goySF8k /RBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=cXm7u/03ZtHJu0j4NUaTmV0lGp7DctDXvkbz6XsrSHc=; b=qw4rzZysUsLCxLN7VwSN1zBIavN8Wjwmj3atHnNF7w3qqQhkqurqwL8gsV4Jg//w6q fOAQkH4GBPVxMZjcbTSIATreE+fvtuymOZy/86TntAkF7L4gkDaHQZdNn5ltyqTgM78W 2REdmUnkeH127j/iA94xcgy+mFJGk63ND5+h7zSQQAqIiwGZKlNS+DHmBdXsBcASOtIo zMhPXVysUsO8/XCwW0g3sG4BVqDDy5vMwG5HxcvNUnPZdcRIJQif/PGWxCuFNEx5OVcV Xfxqora3XY/zI0s+URXR9i7f1HjDfWoUr00t50WPhWVxtZ0VMQN+xXOaUXtpqN8hWpRp iHzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=uI6mRjs3; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ca2-20020aa7cd62000000b004aaa653a74asi5484731edb.596.2023.02.10.02.37.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 02:37:44 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=uI6mRjs3; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0DBF385B508 for ; Fri, 10 Feb 2023 10:37:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0DBF385B508 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676025463; bh=cXm7u/03ZtHJu0j4NUaTmV0lGp7DctDXvkbz6XsrSHc=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=uI6mRjs3xdJyXCWVtTVWZCYH7bJ8WfQIYCqe/F5UjSQXgvOknyc5hbvXt8so4Xiqy M9y8k7cMmoL2mCqbP4M5K3Jcn+ak4i1yl7DvOLK8fAfeNkaaIG0zT3cBuWWYZDN2ig EjtDYFjWNUw9cfGnyFckXPX4XQVFmDBdSMpyBRZk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 92C3B385B512 for ; Fri, 10 Feb 2023 10:37:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92C3B385B512 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 764FC300089; Fri, 10 Feb 2023 10:37:29 +0000 (UTC) To: Nelson Chu , Kito Cheng , Palmer Dabbelt , Jim Wilson Cc: Tsukasa OI , binutils@sourceware.org Subject: [PATCH] RISC-V: Reduce effective linker relaxation passses Date: Fri, 10 Feb 2023 10:37:22 +0000 Message-Id: <26a512cf3d23fca9a71d4328d554f640d080e8a8.1676025351.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757440077418545689?= X-GMAIL-MSGID: =?utf-8?q?1757440077418545689?= From: Tsukasa OI Commit 43025f01a0c9 ("RISC-V: Improve link time complexity.") reduced the time complexity of the linker relaxation but some code portions did not reflect this change. This commit fixes a comment describing each relaxation pass and reduces actual number of passes for the RISC-V linker relaxation from 3 to 2. Though it does not change the functionality, it marginally improves the performance while linking large programs (with many relocations). bfd/ChangeLog: * elfnn-riscv.c (_bfd_riscv_relax_section): Fix a comment to reflect current roles of each relaxation pass. ld/ChangeLog: * emultempl/riscvelf.em: Reduce the number of linker relaxation from 3 to 2. --- bfd/elfnn-riscv.c | 6 +++--- ld/emultempl/riscvelf.em | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) base-commit: fe8cdc8ec145a166414fc375cf2cb65d9a8085a1 diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index 4a5da7df3fe9..c2604de0050d 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -4754,9 +4754,9 @@ bfd_elfNN_riscv_set_data_segment_info (struct bfd_link_info *info, /* Relax a section. - Pass 0: Shortens code sequences for LUI/CALL/TPREL/PCREL relocs. - Pass 1: Deletes the bytes that PCREL relaxation in pass 0 made obsolete. - Pass 2: Which cannot be disabled, handles code alignment directives. */ + Pass 0: Shortens code sequences for LUI/CALL/TPREL/PCREL relocs and + deletes the obsolete bytes. + Pass 1: Which cannot be disabled, handles code alignment directives. */ static bool _bfd_riscv_relax_section (bfd *abfd, asection *sec, diff --git a/ld/emultempl/riscvelf.em b/ld/emultempl/riscvelf.em index b7435d6fb620..b12d15065c4d 100644 --- a/ld/emultempl/riscvelf.em +++ b/ld/emultempl/riscvelf.em @@ -42,7 +42,7 @@ riscv_elf_before_allocation (void) ENABLE_RELAXATION; } - link_info.relax_pass = 3; + link_info.relax_pass = 2; } static void