From patchwork Fri Jun 16 10:16:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 109013 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1224749vqr; Fri, 16 Jun 2023 03:17:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xoRs5cG2lQwwkFpMpc9Ay5Gdi02pYk/TOKA/dV/EnQkPfdZ+8dFSU7xOeAxA7D2sC1CH1 X-Received: by 2002:a17:907:cca0:b0:978:82fd:758b with SMTP id up32-20020a170907cca000b0097882fd758bmr963119ejc.29.1686910645695; Fri, 16 Jun 2023 03:17:25 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id lr20-20020a170906fb9400b0098287baecc2si2888492ejb.50.2023.06.16.03.17.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:17:25 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="naq/AEaY"; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25962385662D for ; Fri, 16 Jun 2023 10:16:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25962385662D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686910617; bh=B1Y7UXQm+HDlczfSkEpWTl59UMhsrppjIgNuxmiymTo=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=naq/AEaYmZi9JO14jEjGdPv9oHfM/gptqRDK6CWtvPyXZBAfGjwZ1szgss/SoNHCw ka5kBQy7giUZ9pSZkS2WXjfvwT4ophU4OEhMf9UTkLPqKMFvpRnzxtlJsUE8nxYIwS CZxV3IYtemVG0MewhfEOIjPrtXwt5nAu1K6ZCIcc= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2061.outbound.protection.outlook.com [40.107.105.61]) by sourceware.org (Postfix) with ESMTPS id 4771C386F821 for ; Fri, 16 Jun 2023 10:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4771C386F821 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IiTG/N1myvennitp3dx7ZNr9EB190/pjeKs6vGLn0cZ2Nh9wjSIhKcOJOZexDRn//hzBreefY6G/H4vxZEwtPikOBn2TwJ8GXUKkyb+fOr/npp9hTXAZegFeKKQ2RJRt0tgplHbKeifzZ5Cd6RyjQzD3f1iOpuW8VniDVuyUCX3qyJng3aEicBSXN3Zm1T90/JWHl0V6ZNwjmaMW7IYKR/8d4B6ft4Sro6xJTUaMAH+Kmc3Nbe7LdZDrmrIHh5Y0oQqt8Q06V42/2+R+84teGjQSVY20uAeslXLcU+2sI7lkSwpo+gSf5buyOgoR6Iapsv12HziIeXgoHOZXS1ERhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1Y7UXQm+HDlczfSkEpWTl59UMhsrppjIgNuxmiymTo=; b=Jc0Z1niOcwwjQc2Z10E1l153VD8gbQM1IR3f+pekgoJgT9nzbWy1sRRhjeC8u2+sChr+zpZ2owNmVBERskN1jifnWdpPDkALRDumlcyjMmnq02jbzXW7Cbq5h5bI1m5d0+AnYqQ3xVmnT6LlAACtoAAcbqORC033xw+AqbRsFaTVWWbPrMGUzT0lpdD+M3+XLJZDeJjfaDHRbZhWsx60HhSyw9BY1WfhR5dI5/JgosVwHCvRqN6PSyPuk9rJlB/9S6myonJfiDkL72Un2FvIQ9sSchnZuUxqSb5zpISzRR0nvsnRauJUv4l7DcHqMNN6GTsoB2fa5Sgv9g+RsH/vaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Fri, 16 Jun 2023 10:16:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Fri, 16 Jun 2023 10:16:45 +0000 Message-ID: <2574a7d2-68aa-70e3-c5da-fc726c952c22@suse.com> Date: Fri, 16 Jun 2023 12:16:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 4/5] x86: flag EVEX masking when destination is GPR(-like) Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> In-Reply-To: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> X-ClientProxiedBy: FR2P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: 02c2be26-7834-4cce-fc2e-08db6e52c9f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxp5SG2TXQ5FIIbeh7Vv3QkZeAWnfNM4OPMhdYSVyA2lhhVmyCEa1qVeRTqqLabuE7eKHfKm1d68kTu9b07KfwGWGmXRrywjnrLGjChMSecv9xCy/RlNJJU5cZOO4g6HidlAbl9nY5BCAwl0HkRLscjtZP95FZvvZtRdwGh/zjsbnGo+j7otXXFJ0fJxyem9e37BOPDrfWS4bOaxgmzkCIQ5dxMtg9lHk66LC5DFM6WY3gNOQOjTS8bJu0FOcvMiC1zDFWMQvIF1T6VbYI4vuDXG0onv6Mdz0c1G9XoznFW0PInBAtzDsCSbKhWV/l1q+RpmH8rBDINYqMYvgx7Awxf7dQxZ2AkS2sHNH+fSJy4Q56Ig5CwhcybbiGUrjRaRVbtjoJZ9bM45uj8k/A+pbA74IS1xqOJ0JdHx5fRB6v+S8cTqJ9Qdpddh/WsYxSKPSCBxC2TBcUGXIuKosfTgLuG4gzcFmdM7vZeMLqMOUntRxZV7plGs4QsDKe7vv5tjYYJA0Jd5Eo5s+Cw6nj3aEOEJMK2WrSnb/+XNPbZvIx827d1jOjYvDjvIe8GndDxQDJv1iYSPqJzRBqraFTgK/LlLUVTaiyfOPvqYaA8mVr0go7gGzYxWFTnpEyXADgzA6wy4GRc2sBd6pHkS+t/0ZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(396003)(136003)(346002)(39860400002)(451199021)(186003)(26005)(6506007)(478600001)(6512007)(31696002)(86362001)(6486002)(6916009)(31686004)(4326008)(66556008)(66476007)(66946007)(316002)(2906002)(8676002)(8936002)(5660300002)(38100700002)(2616005)(66899021)(41300700001)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QgHGcdW7StXY0tCgbMVHBcyxp8a5?= =?utf-8?q?GP2N8+bF9a0MGcTJd3G9f2eOmztInN4ZezZNDmejBWMVWumee9wQIEFxxWPwRssDS?= =?utf-8?q?cecdx4BsBRDRyZb6RUcIWF2QLh7mN7C4WKUD1nE5Jt55XR8+e2L1jljDY6D2eo/Uc?= =?utf-8?q?cxOFngsLx04MmswDU1eK5BIjxX9Cq5T1b2bNV9+EAXWMEsbBd5T3SQ97zR3tCsp+u?= =?utf-8?q?eiByGR4tOettsxHky6g4eKfJBSnCA+5M5kOXrQ1rzPDYTauh3Z0aBfacb/M8siDPy?= =?utf-8?q?TR7BpCpYknv/2GVCV2inT6sZE1dUByrUiRtbtnHGtGySQpXKP71wxY8BLJy4QReB/?= =?utf-8?q?jZDZLUMf5qMu1F+MeU+IUtELov5Xezo1FWkten3GXMn44s4POLgrsaan5yd25Is1t?= =?utf-8?q?X+V9csReZBCTMuZeWSRbvy+VFXf7UY7y3Ebt5DP16C5XOi00M9mkAGWVFXeb6fhQJ?= =?utf-8?q?UL4xcM855NadGLnYOiRGvo6jdy+Cll5esII4sE0Pg6Iz6U+x1dpUp0ULV0IPwANTm?= =?utf-8?q?5h0zhpDkK0+aIlmlujKm387917NKEiO1SOvc026siLjVVRd4vZMbZ1ZJudYMn/XAn?= =?utf-8?q?AMPDCRhR2a6OlxIq/ItoOK8TySflkjAiozyhlcL5ULLqJSZt9kyq0KpGoQWbYGM+e?= =?utf-8?q?ijglCcfS1LrPxJLzEw5ePye2/R8jBimN3aOv0kXx/DcyUeCD5rgFYMA1q9f0+kdvW?= =?utf-8?q?Y4Pe78FEXRGpbm7EWMPoUBmaLd2aIokvto/VBme84aBok8msd66N3gBi/yBi1x2Dj?= =?utf-8?q?v+/1712ljPJ6P4W/0IvyXHblNM40o18t2OU9OumKTNUCMQ3MIlnFxK70Yrp6JWUmV?= =?utf-8?q?0lD/Xy8QNCNTHFh5dgN1XMv/KhrFINLaUwIIYinXe7FTTqwUk4D/Ef2ceAqQ3mJdG?= =?utf-8?q?pS6cSHx5ltL7sFX9Khj+QstMCgHkkR/8gkJinhlGzTohJiu3sHJW+QuoRvn8x8Nz9?= =?utf-8?q?8Nyw18kTYKSGiaZtF384oaVzTbrWIvNdtuG7CdLVNikcMcAEaftFXGfMXBdbyK3gc?= =?utf-8?q?Yzx7KJzHxVyE/n/PuPuYAkg12yO3150fU8mv11s8SHL8k1C7NCTAiOVv4BEWYC1vu?= =?utf-8?q?LHJCV9cPkqo1PZJmiv5bbLMlu4pClwIC4POAApTWWt/aHXxmFzXnpSUh6GBfGv7ld?= =?utf-8?q?tA79V64Lpkl5wVKTXngO2nIs6b+Dn1Ylmu2DFoXjBJcgPRCfp5+PARsNMWCfYZHsF?= =?utf-8?q?0vwn+Ad2fHzlFjB8HbewSYtOwfd/zDQjZFINqVWlDMYBGFXRg71WAiDFOjZEoNZ0w?= =?utf-8?q?ydwQcDRsbutYsgBnLll0tYrYIec3SicvXWczvav1/6FSj8tNSJOD/k85P3BKK2ODB?= =?utf-8?q?Ux69XsO/fNSbeMEKN636TH9QHp1pt9zKfUdDykYOb+KvyZVLENm8TTpMPo0RyZtob?= =?utf-8?q?QywAPixGuTZjlqXEp69k8PKuJFWQjoQHaWTLI72t86jYmEF6bnzqCsVAO2+0/gLAq?= =?utf-8?q?RxZXRNAFqvDrVbabBSxT4HKEsLNblfrmg80pQBjzcrmQauF0u9qUZWWcEkSMdn86a?= =?utf-8?q?PhK248zGI7/j?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02c2be26-7834-4cce-fc2e-08db6e52c9f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 10:16:45.8687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ou/CVsVUXAtJcSpNTtI7oEKzdEPBDNDfedjVjusvTqQP85IRpjMolxRZNExCvnxQBXzkIU7UhOYD8z7OK+zFQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768854017202954535?= X-GMAIL-MSGID: =?utf-8?q?1768854017202954535?= Masking is not permitted in this case. See the code comment for how this is being dealt with. To avoid excess special casing of modes, have OP_M() call OP_E_memory() directly. --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -11640,6 +11640,11 @@ print_register (instr_info *ins, unsigne { const char (*names)[8]; + /* Masking is invalid for insns with GPR destination. Set the flag uniformly, + as the consumer will inspect it only for the destination operand. */ + if (bytemode != mask_mode && ins->vex.mask_register_specifier) + ins->illegal_masking = true; + USED_REX (rexmask); if (ins->rex & rexmask) reg += 8; @@ -12374,6 +12379,12 @@ OP_E (instr_info *ins, int bytemode, int return true; } + /* Masking is invalid for insns with GPR-like memory destination. Set the + flag uniformly, as the consumer will inspect it only for the destination + operand. */ + if (ins->vex.mask_register_specifier) + ins->illegal_masking = true; + return OP_E_memory (ins, bytemode, sizeflag); } @@ -13156,10 +13167,14 @@ OP_XS (instr_info *ins, int bytemode, in static bool OP_M (instr_info *ins, int bytemode, int sizeflag) { + /* Skip mod/rm byte. */ + MODRM_CHECK; + ins->codep++; + if (ins->modrm.mod == 3) /* bad bound,lea,lds,les,lfs,lgs,lss,cmpxchg8b,vmptrst modrm */ return BadOp (ins); - return OP_E (ins, bytemode, sizeflag); + return OP_E_memory (ins, bytemode, sizeflag); } static bool --- a/gas/testsuite/gas/i386/avx512f-nondef.d +++ b/gas/testsuite/gas/i386/avx512f-nondef.d @@ -22,4 +22,6 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 62 f2 7d 48 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0/\(bad\) [ ]*[a-f0-9]+: 62 f1 7c cf c2 c0 00 vcmpeqps %zmm0,%zmm0,%k0\{%k7\}\{z\}/\(bad\) [ ]*[a-f0-9]+: 62 f1 7c cf 29 00 vmovaps %zmm0,\(%eax\)\{%k7\}\{z\}/\(bad\) +[ ]*[a-f0-9]+: 62 f1 7d 0a c5 c8 00 vpextrw \$(0x)?0,%xmm0,%ecx\{%k2\}/\(bad\) +[ ]*[a-f0-9]+: 62 f3 7d 0a 16 01 00 vpextrd \$(0x)?0,%xmm0,\(%ecx\)\{%k2\}/\(bad\) #pass --- a/gas/testsuite/gas/i386/avx512f-nondef.s +++ b/gas/testsuite/gas/i386/avx512f-nondef.s @@ -32,3 +32,9 @@ # vmovaps %zmm0, (%eax){%k7} with EVEX.z set .insn EVEX.0f 0x29, %zmm0, (%eax){%k7}{z} + + # vpextrw $0, %xmm0, %ecx with non-zero EVEX.aaa + .insn EVEX.66.0f 0xc5, $0, %xmm0, %ecx{%k2} + + # vpextrd $0, %xmm0, (%ecx) with non-zero EVEX.aaa + .insn EVEX.66.0f3a 0x16, $0, %xmm0, (%ecx){%k2}