From patchwork Mon Jul 31 13:44:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 128692 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2024210vqg; Mon, 31 Jul 2023 06:44:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlFO3VxztYRNTm3+Oh94NzMKWyfZHMqffUP21cZlUVKIfQiX7Ei5P2LgN4c4N7MzUF0OW3pw X-Received: by 2002:a19:6917:0:b0:4f8:4216:e91f with SMTP id e23-20020a196917000000b004f84216e91fmr4540951lfc.63.1690811090387; Mon, 31 Jul 2023 06:44:50 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id kf7-20020a17090776c700b0099b4147a2aasi6711653ejc.188.2023.07.31.06.44.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 06:44:50 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=JXrRxte7; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 510543858C2F for ; Mon, 31 Jul 2023 13:44:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 510543858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690811080; bh=Nn120Px4CH+uHS4bn/HwsTshfFy65DMA+0e4z1W8zNQ=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=JXrRxte7DGxIzRvOjBhwnONMvvhMWEVpt5qIakEAnQ8SFvk3v/Sxi2q0WLweoNlbh 21d5AH/5HjY+KKlo+b3s9ftNcewKrq/u/HsF03pHoR/4bSKs58OIdJFwmf+ydkGNHb kgfSqdKxaAOTA8Lt8udgZj4fwH9UJ2fPcgUCJDG0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2048.outbound.protection.outlook.com [40.107.8.48]) by sourceware.org (Postfix) with ESMTPS id 7797A385771C for ; Mon, 31 Jul 2023 13:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7797A385771C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ok28Rd/rEe4/zgOZ1woRaUT7rtQqRzlmmQUtsyl0Ll5nN8ERkDj0EhKnFtlPjdiRABK6DvfY7g2AjQcEH7VM+DiXlnSS64i9koBXFwd7xr+NRlKEpFzpU+Ijt4gxlIzdypFV3pJ2c9bADASx71srW91VnonVTRcdA1B6nGpYbCne+tCYL3ZLtB6npOxScjWDgxRm+Ji2JvjoiemVeQRotEeqDEhqz5saDvhc43jCJ49qXd4C8l2fOT89nUURgQ7rrYBmgdMyvHIgZ/PKRzfIPzGvJdW1YEm93vJeyA+I5GHj4W+xS37H22NM/2fdV5Gy0fC1wnsakNtC0v2b5qoWyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nn120Px4CH+uHS4bn/HwsTshfFy65DMA+0e4z1W8zNQ=; b=W4p2oaAHGFagWp+7YjaBCMUsXjsU/Z4AroM5ojE34JTlJsQcfn9rgGys/IrC9VDCMN+/DU0zaI2/SaV6yv0ytJPok+ICMC7Y4U7ip3QC4nYPYuJcbHK19huL7vHCcjrDxhi/VW34NHrIAIoH8/iLL9XLE+pwTtSCMJsleOZ7y2h2CJJ8YIjjWOWYYEVCmwTOzJDMV9eYQ/8eYn+thMs+rfYzW8TqzDnyYhPUn3aEEfLeTDex1mSVGeox5TFcE1+qMx/QYlh86vi20s7QWySMsSFQ8qlEmlam3QEB8ltM3YltQOrWfxBA3dpneBo+wwGHvVgmT/XwqmJlC7wscncNMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8467.eurprd04.prod.outlook.com (2603:10a6:20b:34a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 13:44:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Mon, 31 Jul 2023 13:44:22 +0000 Message-ID: <20b1a608-1102-d462-eb99-c18e0b7d2f83@suse.com> Date: Mon, 31 Jul 2023 15:44:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: Binutils Cc: Nick Clifton , Benson Muite Subject: [PATCH] gas: rework timestamp preservation on doc/asconfig.texi X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8467:EE_ X-MS-Office365-Filtering-Correlation-Id: 227db2bc-9d80-4622-40fb-08db91cc3f1a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0au5wg0jmTRfnkbuY8QKnYmO8Qp/+EHgno2spo/klM+WrzceJr8HXsk+zwhLCt0R+9BwYLYfjYkE68hqfVCmXe5oFAGrXTmED1HY3LZHdoIBaFrjxH7eYyc/HqPEEEFyg8+kqw/f70w4p/z/m9Vuxt557mhQOo/rYiBe7caqhQm4Bg0l+8vuf9eSI2pRjVW7HgyijY7gW/9IAOd4F9/9zUuI8t5aKGYHhWaGLszk3eJOeobqeFHny4k34cy0ZQZOw57j86OD0To4+yIaIhPGLy9Ho6z/+NWuSMT5UVRpcO+rAoU8j3G9mCjCI0VBv7UQ1ZtfpahBDoiy8/06fYNodxvX+Nt7Dw83vBOARmey/S7zaI/INRvXy7x4d5GrlBur/bag5KsdHjyGppMx+o307Goy1e+eX0nipAwsAT8pRY+/y4SaqwnbeGpy2mZCudPkv/rawiiefz6LHi6NvofYw9ib22oMlRPj4C3gmHbsuGzuMPny3eDIuIS6vkTRTPqDDLE7dqtYVKo8x/R8yMMOhpHZWS7pbC67w9MaQ2vYpyoekM3DqbTTtDINCxJpvzS7mx9Y2hvpfERmW9F8HUOBKiVCUcqL2PeyYqDduw9qYytJosGAtPntjU/poBUfU98E9WgB634n4mbotzxR17iPFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(41300700001)(5660300002)(31686004)(6916009)(66946007)(8676002)(8936002)(54906003)(4326008)(478600001)(316002)(66556008)(66476007)(2906002)(66899021)(6486002)(6512007)(38100700002)(6506007)(26005)(186003)(36756003)(2616005)(86362001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?i+/DK3lfjcRyIfyn61zBzGuIyxEv?= =?utf-8?q?allvL8sldqydJ+ySX64RH69AVMOWfjv2xrzp/E1C5hPglTWqXvo6hluSab9NkIyXP?= =?utf-8?q?S7nfMqeDFDT1JkYxLlAo8q4EHhYsSoukUCv/4HElviWNvAUNSrvn1ycNmz5wB8OKv?= =?utf-8?q?i1pzhWimOnngRmbfybL1kFwcSGO44RjzoLIdO19rfZZPBWhrcDFPAEc1Vw3C9tS92?= =?utf-8?q?h8T3rg/gSClw1uui1DPT4U4O7sG4ez5gNDJNFL0up4aYVnHie9hegjzC2XUwic1LN?= =?utf-8?q?5Q0GiaEFVNCANzOxEHnnSmP29ZrZnaHBd1WHzR5HrTdOs/5Wb/gfZmTHxXYYcInnm?= =?utf-8?q?Gb4eGBaCn1u1G7jHsyFTLCYfzkru9PkV47aZdMb0PEyTx2Ahwey7fW5e7/UfX3Zm5?= =?utf-8?q?Gg8jp4QnE77iu+kQl4eWBIqmpbHMjDCIhuZgJgtf267nXxCoGmAYRalMNVox3UjJx?= =?utf-8?q?wvxGGWoegzJI9kWCA1lwU+ZF8odt8ECBNMdPzZnnV0XzJ8yJlo9q725E9V65mAIqQ?= =?utf-8?q?V5tvCq4TN8evqyczROsfrK+o4LJcYj4arkDYXcqs8ktGha7z+7tVNAy1UltibyqDU?= =?utf-8?q?cpzX+zUAZIWro9aZxQP50fHzR74+o6DQ999oAXyb7KcRt2SB/2kmhB0EHQxO+S3/W?= =?utf-8?q?w9Lvz0iRm9azgNHFgFPvq4nX7K9fhj6tjRtJWj2Dq4wDFLuD1zNFb9PIahDhPcQLN?= =?utf-8?q?cAgxWZcg5+c9891WWn8cVuUrTZrCiIaNZITtPJxgjBD3SzaBtoDb9sLhPV2ta85Hn?= =?utf-8?q?q6Lcz0+Z7IWqYJlijC1lyOO7rFfwcc8YGZL+x4p8jgGc5yZaIgZxV2XNoqpQrO/SW?= =?utf-8?q?DZWp00aa6LXzUVPaTuyTqs3iIB+lbNIQJmicOKd7yCtvZbgEswGoyvrxDbF6M64iA?= =?utf-8?q?kIBtR5EbzRpKtM84Sc0Tfz1ynENB+VfkYah3/DOBITJULZIT/nALmriYSQfYLT657?= =?utf-8?q?RqKQ37Gsu/VHVNhs1zVrBYdWcvjKhkzrCIupVilUzxKTmz3lUOyU0k5l1c/j2faDA?= =?utf-8?q?hgWHltfft4PNM0DHV1b5dWVXDrPLex5oWCE0zYTsbflX5NRcL6jF95Xfk+ngKDLxd?= =?utf-8?q?dZgczgOjXZh5LA3lEdivNUQ+r7enatdrmIG3Zib7vyxUBFyeMxz00oSB3ozviULt6?= =?utf-8?q?ypNwxRfhgiNzcwguQltOlelDBsjMf3BRWCEjoaNgGyN4Kl7vfZlk1syEn76kS8411?= =?utf-8?q?2VdZ6ozZAySsXsq3f8TzCqJMCzzrZvjPtumWAztpWNYJ1k7tIDmC7asl0dBmXegWy?= =?utf-8?q?9jA2arfQC5WVAHQ5qD7OKN8i5wkb7w19lJqQtWLE4tp35pxP4NH84rFwSW/9mVGzZ?= =?utf-8?q?61a5wv4gCnOP0p1LmYR9BnIn7WDlusIsMRdYZqNzkKdk/bp4/fb5spebo+/zFxdzV?= =?utf-8?q?OOsbfIL4LxWNAUv7TFB9ukowQgZkWgyaD5OWtjtSdXmP0cGCbK37aIbh0d+Ya9+VN?= =?utf-8?q?R8d8zz7IASw8Lp1mmR2kuZoLWF84cx5ypuPFfSEB9cJCK0UzSnt3ebgnrvX3hV56g?= =?utf-8?q?f6meUqMH6ppw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 227db2bc-9d80-4622-40fb-08db91cc3f1a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 13:44:22.1927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TYCodCrJ3XVkKg9bPxHEwsEn6dbgjNuMupgj3C1SP2pXLJ0tKaQJpaya+KSCCreQLp5SJ2inmncsQRK2yFRNHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8467 X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772943929610374590 X-GMAIL-MSGID: 1772943929610374590 PR 28909 Sadly "cp -p", doing more than just preserving the time stamp, can fail e.g. upon trying to preserve ownership (which we don't care about), as can be observed on e.g. Cygwin. Replace the use of -p by a use of touch, this way also only preserving modification time. --- Interestingly that earlier commit (8034b0baeac1) looks to also be the reason of there now being "GEN doc/asconfig.texi" on every (incremental) rebuild. Would be nice if that could be avoided. How important is it to actually retain the timestamp? Said commit said nothing on the "Why" aspect ... The issue described in the bug doesn't look like it wants dealing with by using "cp -p" (or alike). --- a/gas/Makefile.in +++ b/gas/Makefile.in @@ -2230,7 +2230,7 @@ de-stage3: doc/asconfig.texi: doc/$(CONFIG).texi doc/$(am__dirstamp) $(AM_V_at)rm -f doc/asconfig.texi - $(AM_V_GEN)cp -p $(srcdir)/doc/$(CONFIG).texi doc/asconfig.texi + $(AM_V_GEN)cp $(srcdir)/doc/$(CONFIG).texi doc/asconfig.texi && touch -m -r $(srcdir)/doc/$(CONFIG).texi doc/asconfig.texi $(AM_V_at)chmod u+w doc/asconfig.texi # Maintenance --- a/gas/doc/local.mk +++ b/gas/doc/local.mk @@ -41,7 +41,7 @@ TEXI2DVI = texi2dvi -I "$(srcdir)/%D%" - %D%/asconfig.texi: %D%/$(CONFIG).texi %D%/$(am__dirstamp) $(AM_V_at)rm -f %D%/asconfig.texi - $(AM_V_GEN)cp -p $(srcdir)/%D%/$(CONFIG).texi %D%/asconfig.texi + $(AM_V_GEN)cp $(srcdir)/%D%/$(CONFIG).texi %D%/asconfig.texi && touch -m -r $(srcdir)/%D%/$(CONFIG).texi %D%/asconfig.texi $(AM_V_at)chmod u+w %D%/asconfig.texi CPU_DOCS = \