From patchwork Mon Feb 13 14:54:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 56326 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2388151wrn; Mon, 13 Feb 2023 06:54:15 -0800 (PST) X-Google-Smtp-Source: AK7set9SWGxc5F1crzLnosQT4Rs0Gf/MN9a2oWmw727VpnhgNH6Ocw4V4NxozE0fL2S1oyOz5gV4 X-Received: by 2002:a17:906:86d6:b0:885:9ce9:dc79 with SMTP id j22-20020a17090686d600b008859ce9dc79mr26021570ejy.77.1676300055416; Mon, 13 Feb 2023 06:54:15 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id bf19-20020a170906c51300b007a087ccd275si14669398ejb.384.2023.02.13.06.54.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:54:15 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OYZ8DjDJ; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DC7C385840A for ; Mon, 13 Feb 2023 14:54:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DC7C385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676300054; bh=JuZ0ydg5WlgmbQvkQEHQL3wBjr/0bqf+XcPl2Q/kaSM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OYZ8DjDJyCrjQJzwS+TVBqe2mvxcAphVniwLDCRdPsfVJi/tJcy9NFRrsHoBPfla2 CAlB422DeA0AdUsgsO+QmMhawTpptjTeDv4qKrW2nbDlDDQUsiQ6TMqCcVLNfJtUlu +T6+F9nynLsXoJOA1Jr7BuhUhjFddHoJAT/iENvE= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2088.outbound.protection.outlook.com [40.107.105.88]) by sourceware.org (Postfix) with ESMTPS id D8B3D385842C for ; Mon, 13 Feb 2023 14:54:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8B3D385842C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aLSTGA0kv9zktRamzqysX69TvnfYdNubLCk28J54ebQymq7wa6Ymbqqqo+bM80rAmRtTWq/yB3I13feLAeQZ+bgzV9xW4wba5p1MmwSdUEccKdRH0nsnTVZL2tHbw5oRrJ5iPGxZnB1a9HToM5a+lmH78jhkX+IUDaw9UziVtu6s+jv86gjqcu4KmlZ4bUoxywbZ+mSn/1PctIIKXo/Sg7UZvErLa0ynNzAL3hpkHc/5hyDRuc8la/BxCJMCI5l1/UC4R3RYqX+4pbu68jhse78Yb0c558jSmF7UDpTlWoswvrYJwJ9ozhCwx9auVQ9lAcpoYxbKFN5MacfJ1JNqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JuZ0ydg5WlgmbQvkQEHQL3wBjr/0bqf+XcPl2Q/kaSM=; b=YR+N49k/Y3gyK+DOEFIV9oGkUhHLWLWkdizIl5A9gy/Nv09IBD29z9How+tu9/XiypYNKmxsx4gUia0ScrT2yACa6lxA6567FLX0KwHaNkcQUMDOfyy0j57evjWwvloFtPUzlh//pK5fD8QxOhQiJgEdP80Ac0Dk5tcy0G1pRKj9pi4HaspUFcj2DIqOdv0iB7/Awz7DHK66xoMmvFNn+lUqU0k1riMBsc5/IHKx74mMIu35EGzNvHfaaPcVOS0ue+Q1+tw10dOe1E+9zNAMheeiKe2Fq8nDyyQKXTrERGUqDts2Bk+FMlOl76ZuLfOzh8e/HfA9jVlyCwS2a/IW7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7626.eurprd04.prod.outlook.com (2603:10a6:10:201::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:54:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 14:54:01 +0000 Message-ID: <2096ddec-287a-de42-a2f6-58293af2fd48@suse.com> Date: Mon, 13 Feb 2023 15:54:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Binutils Subject: [PATCH] gas: correct symbol name comparison in .startof./.sizeof. handling X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7626:EE_ X-MS-Office365-Filtering-Correlation-Id: 79d850c5-866b-4fc4-178d-08db0dd224ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J3zIYjiVCOooCWT9b4DqeA5JHW3rPnA4pHT+oO4mDCtmKEN0QtWLR9v/RGEQWB6OFLjHdusuwF8fT3lmsS9Ug7N1Z85F72PhzHON7gHH/LYHmuBYvbyu1gk81llFwct3UAtsCwNka8QHc1XAgDhCvXjEWfgK2MY/wnC8T9hDi49uGeQ4Sg9JvLGBxWycEwqWdW3qHjZDjhvU+2CzO3/SkJKaDSxWbQvG5ydHF1bOeTuku+dOQ9PTEDIkGTLjiYCVUXUPsECDOfiniXnmXJJ9/dPcznoh6Q6yLGNB43qfNECjuFgcmk0zO4yvfbzNBJTOQyihDzaNJW+3SiVFWREG2pvSlzgySIe/3dwGnFgLWezIrT56ukkwg44zoZ3S6KQeWFCYD1w9PKvtaNm6TtZX6jfIW5ZjEmJl8h9TWd0CYWK+6JwsNMxwu0sDnk2kv8sFUpM0x28ICYLlzZX2HwYvUZSInO/yE01mp52XIYmKp++8um4HkSK1kDF2ijDmsa7uPsZqbAfJJmE8dAfR9KJtgICSbchWZLpQbFQnPKlyMuDAR7G2yiJS/Z+fdvjqybvtEEfHoeiM20+3nkD0T815iuX4a64O2PqBbVsk6y6bi0qqzxlszVOGJuiD8tzuODZdz3dmfmjE3adGNkOwEnrS0eCMT5im1gRoRDZHt8kzntRG4SBDrqqKu9jbPhBvf0QViXDW84NPH3ai2cMENZ13lIMDqw9lqbjbdZytyGPScJ2F/kXA7CdXh11QGxpwmdHU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(346002)(39860400002)(366004)(396003)(136003)(451199018)(31696002)(36756003)(86362001)(316002)(66946007)(8676002)(6486002)(478600001)(2906002)(6916009)(41300700001)(66556008)(8936002)(5660300002)(66476007)(38100700002)(2616005)(26005)(186003)(6506007)(6512007)(66574015)(31686004)(142923001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?StXCIduB2lzWStysZqgtJQ9JHMcd?= =?utf-8?q?DfBU34FgmAB1gCh6W8Wg0X5tOM0LUUvTJfYZraDr0dSS+MsoNyXgNIZT6ITabkd62?= =?utf-8?q?yPPsZ/ce6IDY4M305vmBiAYTDXVWy5ACas5P5aZ4cZWn6ntKa//XeI8w6NoggX1BU?= =?utf-8?q?G7QwDTemymfGuO+l1fzXXdpwohLLXsFi2ApK4tk/4XN/15PBxdZptD2P7eZ4f5ODm?= =?utf-8?q?3fuU2R4u/boFETKlsgAkFtFhaN9quiuiGrsT06SfrSSLR5n/7y57IU5rglp9ey7jp?= =?utf-8?q?jci6cTvtu6LZKOneHy/v+ZMmEVrZMwN2pMKBhHB+CD8WyO7pi4s3JnTEWIffAJDQO?= =?utf-8?q?SIWBl/XWhxPtCXjVPr9epzRvvsXm9CGn76uKsRBY3ZkzCuTKgiFh/MV/zS0xCj+OQ?= =?utf-8?q?xSpmsMsygy65lqbMqTp2j7Fm0WaRp+8rkk9JMUr6t6AkpjOzCGX04wPWcYDNAMtaC?= =?utf-8?q?vOMCLmbtMCQMb9wD65G8wszVjX7xU5C8sH7nyRw5LAuaAz6baCUl1hFjkKmP45mF/?= =?utf-8?q?rjjdn6tr5kxNonkr8MIOKegvHvqdn05WxJmu8x9pQ0zATHygTNUhA69y2JJ/rQQvk?= =?utf-8?q?kEDxUbgQXz/SMAbVv65xXgp3AVFMV6R4uJSS78tuVwuLl6yYB1YXowFzsTflMOEDT?= =?utf-8?q?7+Gag3zPZCUnQrMyzQMBAAknrScjVsqpk9R8cMjPeiCmehfLo9ZYBo3rrVYBDazuT?= =?utf-8?q?fCcX+Xf0tbUw+//qoMvDQyETqy54nq1kbqx1YFb8WHaScVi6lGYmiY26Z1nxd8N2r?= =?utf-8?q?Dqa0+VzBv9prg3FEl48mp19LyxMjDM9K2ZXP0aM7hZMaJ6vW7qmoTSt612Ul6KVd0?= =?utf-8?q?Ye0XVeYcUjk/FSIZWJdN00X16ngGnWXSPVKbpk1ulgwfSvf+nviMmvdddKnpU8551?= =?utf-8?q?PV8tn+HZ3vfh+hHgIT7hAP7TPIYk8m7+beSJbuT9xzT2Ub4bobYvVYYu+7VHVSdwz?= =?utf-8?q?cVa5+vQQvdRPbsyQ86Zq7wluJd7G0JsoqhNjpRoQ9JENudA2zJWvNea0juDwU1jBy?= =?utf-8?q?8FZtcmkurYYQNPxOeLG2m2LmEhuUFkVi3vPwNzbIGDv/4kdeQEOFduA/Z8adsjAfG?= =?utf-8?q?z3VEKJSEE61Yn8ZCyLrxp1bGNaomHKCcUWZBmE3V8khn8LOsMpvcoqY4lWcHGwhuB?= =?utf-8?q?34n+RxEdFQtJj/dEJe7dewdHdlbQk3tjykveHTDDixoS5Re9hey+0e5qx1LWuUML5?= =?utf-8?q?IldVXhkh83DWngN7hY9EAftduvfG9cTvNHkaLHJhdJ3YyST4zZ9GgyJ44Is6WlZQC?= =?utf-8?q?QrlAwk63a6p1jWg2fblWVE/DZmo8jTExjE1g7htlGwz1mGcFu5bedaj9iVPXlHhEt?= =?utf-8?q?+ydeJ9dHzybq3EQjOzfnTwFmGLb1jnzv/1Q5ZK3w3ERR+nJeQtHvP33q9OL+jOZqg?= =?utf-8?q?5Z/9LiB62PykpZ4SUMvBCPFRSLbMAykxuLaRcirSjKJQXngIx7Z3wkY88m+BoZDI8?= =?utf-8?q?SFAl1p4ucJ5JU88UYfKZ8ceRq2UqTCLDG10G8i2JP+kc+fparw1l/kz/6magTQYNJ?= =?utf-8?q?LlvPZpHN20EJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79d850c5-866b-4fc4-178d-08db0dd224ba X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:54:01.6181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /1Z4uEtQTeuIjUI+E5Us4prcIq3Bwj3Daytcbh8l7X6y81QBv1lsXbr68Vi3LHkHL+4h+RlU3O6dZA8bSu+WGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7626 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757728006934467351?= X-GMAIL-MSGID: =?utf-8?q?1757728006934467351?= In 162c6aef1f3a ("gas: fold symbol table entries generated for .startof.() / .sizeof.()") I screwed up quite badly, inverting the case sensitive and case insensitive comparison functions. --- While there were no reports of this breakage, I'm still inclined to also put this on the 2.40 branch. --- a/gas/expr.c +++ b/gas/expr.c @@ -149,8 +149,8 @@ symbol_lookup_or_make (const char *name, name = S_GET_NAME (symbolP); if ((symbols_case_sensitive - ? strcasecmp (buf, name) - : strcmp (buf, name)) == 0) + ? strcmp (buf, name) + : strcasecmp (buf, name)) == 0) { free (buf); return symbolP; --- a/gas/testsuite/gas/elf/startof.d +++ b/gas/testsuite/gas/elf/startof.d @@ -7,4 +7,6 @@ Symbol table .* #... [1-8]: 0+ .* UND \.startof\.\.text [2-9]: 0+ .* UND \.sizeof\.\.text + +[1-9][0-9]*: 0+ .* UND \.startof\.\.Text + +[1-9][0-9]*: 0+ .* UND \.sizeof\.\.TEXT #pass --- a/gas/testsuite/gas/elf/startof.s +++ b/gas/testsuite/gas/elf/startof.s @@ -4,3 +4,6 @@ .dc.a 0 .dc.a .sizeof.(.text) .dc.a .startof.(.text) + .dc.a 0 + .dc.a .startof.(.Text) + .dc.a .sizeof.(.TEXT)