diff mbox series

[v2] LoongArch: Modify inconsistent behavior of ld with --unresolved-symbols=ignore-all

Message ID 20240226031135.841416-1-fanpeng@loongson.cn
State Accepted
Headers
Series [v2] LoongArch: Modify inconsistent behavior of ld with --unresolved-symbols=ignore-all |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

ticat_fp Feb. 26, 2024, 3:11 a.m. UTC 
  Remove duplicated check when producing executable files that reference external symbols
defined in other files. RELOC_FOR_GLOBAL_SYMBOL will check it.

Testcase is:
resolv.c:
int main(int argc, char *argv[]) {
    return argc;
}

t.c:

extern const struct my_struct ms1;
static const struct my_struct *ms = &ms1;

t.h:
typedef struct my_struct {
    char *str;
    int i;
} my_struct;

Compiling and linking command with:
gcc t.c -c ; gcc resolv.c -c
gcc resolv.o t.o -o resolv -Wl,--unresolved-symbols=ignore-all

Got error as:
~/install/usr/bin/ld: t.o:(.data.rel+0x0): undefined reference to `ms1'
collect2: error: ld returned 1 exit status

---
 bfd/elfnn-loongarch.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

mengqinggang Feb. 27, 2024, 8:41 a.m. UTC | #1 
Thank you very much, this patch has been applied.


在 2024/2/26 上午11:11, ticat_fp 写道:
> Remove duplicated check when producing executable files that reference external symbols
> defined in other files. RELOC_FOR_GLOBAL_SYMBOL will check it.
>
> Testcase is:
> resolv.c:
> int main(int argc, char *argv[]) {
>      return argc;
> }
>
> t.c:
>
> extern const struct my_struct ms1;
> static const struct my_struct *ms = &ms1;
>
> t.h:
> typedef struct my_struct {
>      char *str;
>      int i;
> } my_struct;
>
> Compiling and linking command with:
> gcc t.c -c ; gcc resolv.c -c
> gcc resolv.o t.o -o resolv -Wl,--unresolved-symbols=ignore-all
>
> Got error as:
> ~/install/usr/bin/ld: t.o:(.data.rel+0x0): undefined reference to `ms1'
> collect2: error: ld returned 1 exit status
>
> ---
>   bfd/elfnn-loongarch.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 1895699af06..e475f2b5e64 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -2866,14 +2866,7 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
>   	      else if (resolved_dynly)
>   		{
>   		  if (h->dynindx == -1)
> -		    {
> -		      if (h->root.type == bfd_link_hash_undefined)
> -			(*info->callbacks->undefined_symbol)
> -			  (info, name, input_bfd, input_section,
> -			   rel->r_offset, true);
> -
> -		      outrel.r_info = ELFNN_R_INFO (0, r_type);
> -		    }
> +            outrel.r_info = ELFNN_R_INFO (0, r_type);
>   		  else
>   		    outrel.r_info = ELFNN_R_INFO (h->dynindx, r_type);
>
diff mbox series

Patch

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index 1895699af06..e475f2b5e64 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -2866,14 +2866,7 @@  loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
 	      else if (resolved_dynly)
 		{
 		  if (h->dynindx == -1)
-		    {
-		      if (h->root.type == bfd_link_hash_undefined)
-			(*info->callbacks->undefined_symbol)
-			  (info, name, input_bfd, input_section,
-			   rel->r_offset, true);
-
-		      outrel.r_info = ELFNN_R_INFO (0, r_type);
-		    }
+            outrel.r_info = ELFNN_R_INFO (0, r_type);
 		  else
 		    outrel.r_info = ELFNN_R_INFO (h->dynindx, r_type);