From patchwork Fri Feb 23 17:07:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 205525 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp718923dyb; Fri, 23 Feb 2024 09:08:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXzLf0yP5UM+QLkQl9u5Q68nf4KoEHBIqOTuUMo4C3trUzUPlJe6FKDRKvDDV+BXetQFNJGFBdvgq2Fk6LDVhzOjFEp3A== X-Google-Smtp-Source: AGHT+IHGIiJtPm6ZAiaRESnPiQwxqviYCeW2emSexSdjs/WR7yEfT9c4ORl23WZLk/QzxdSK26ea X-Received: by 2002:a05:6214:418d:b0:68f:8927:ac6c with SMTP id ld13-20020a056214418d00b0068f8927ac6cmr570373qvb.20.1708708112354; Fri, 23 Feb 2024 09:08:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708708112; cv=pass; d=google.com; s=arc-20160816; b=gFmoScVYTFY9eHbaoSwPhcOrbaEo/EBbiwROr4lxn1xczNTEGA0h/8UmYtJO+FACIv jovceOqDfmfqAQ6gFu7ckl602s3EdCWTqzSvvkWmMnY+rhHsHPIx0X6KFc7QfXHenf2v ip3uH1HHbFEdKrkbyjK//3MraN1Z26z7FjZEdq2TW+q++iVfoRAAzMattYjaHI+lgWWS +AjOOoqd6kF3Gpshyz95GR3VyINLclm7NCV1A1BuCQAb+I7vryZY7NaHLKlf4vTics3W 7ucF6q1CWt1EO9AmNaRGEA1/QRHcO/P2iRuqNWvXb8wDH8LaiVP48Udc9RVsOeWQIPIo xjXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=pjLkNurtuZqK3UmzRB4cPL+fRNrhdZbHUtXdPgVxhbE=; fh=vTbGg4wY0rLaolKO+EtTu7rlJzNAP3iHbUH+MVoijcQ=; b=LiE16kggJ4uoA3A5TYBgGGZfker6WJzWKzbg2qvR6u0LoSC8E8ts+1tWt6p7Etj/oR gqSi6WhuyZjz1Lmwgk2OcofMV9OGntBHDGgXerQ7GEU+eJC2sS30mjB6eCal87A26QT3 +tSbzs3Flh1civwNrVNBMBkyj+eGnxWOrc65xKOhZsrQBP/yJ9t81gvEg6vLDrkCFJET A87c6pRTtD0iYzQCVUb+zah32QRi2CWkIqGwydZyR7WcYedo9P54ofaQzVXsAUiVOMw4 32RYuD8R/rd4RrUnyl+JkVRN/J6Hx7fP8cgy+HOdLZkysuLTWTxzff34O8bQO4S+ICnT Vlag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=hw6FPgEM; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q7-20020a056214194700b0068f8cc14838si9452142qvk.218.2024.02.23.09.08.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 09:08:32 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=hw6FPgEM; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C51FF3858429 for ; Fri, 23 Feb 2024 17:08:31 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 63D1E3858C53 for ; Fri, 23 Feb 2024 17:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63D1E3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 63D1E3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708708095; cv=none; b=ECIl3T05sRVjlo4qD4UGQj7z6afQ7ygc3kNUQNvOC0VjMRX+qmxPKrqDlsduIWUTQy2I7SP9Jse3Ghmeh80qDidlianZKp1wYKHcJ95PikLZlGwmXUqNWf+lsKZWK6Prt//+RDoPNryeLnbxwgSwZkVLdwZEbPJL0RClG9owb9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708708095; c=relaxed/simple; bh=sw5Q0zk7GL31r+s4mEWOZTYgquU4J1c58tZJrJB6sy4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=crACPzd9y7wnL3qc/qyjPujOHWg4n3ObOIy3EEZR8cb5zz/WY5AanehBORL+If3CxYNHhAj6gag6Z656pHqiSr+jTxwiG+idylxr7BHTJ6csySH+O4J3NlRcz4i69XRcb7PZiu6EvoW6bspENugI+trV3DRyAYiwn7QqqUm/nao= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41NGk3qJ003947; Fri, 23 Feb 2024 17:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=pjLkNurtuZqK3UmzRB4cPL+fRNrhdZbHUtXdPgVxhbE=; b=hw6FPgEME04lQGH2MqheMw8U2ZFJ/7LTstYNRuSph8c3qzJDnjdai/yfYYxJbq/ABWfc 8MZqxiIOVuPrQgVjFComRs9hhAkaNiaqYrS1cnNpGhiLylj/GygnV1pCd5h6cWIGf35B 6e3fm7YxRIpCKV0JGDevI+0eQXzL6G90rGJ7hvxcrEJwEMyH9yQpOT9GH4XkQzS0P0Dp 7w8lxWLe9j2bqLr+P1gS65sMq9h+spX7sjVuKynY/ikzfJwUqxwIioT5yohHlHG1r6Gj dwW5j9EXCWPmuTq1j7gPQ8eUg4hw6L45ryYEFvxHhZjdqgKYDiKzBGuVGnapk5xwoToB Ew== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wexyu0s4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Feb 2024 17:08:10 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41NGEH53003615; Fri, 23 Feb 2024 17:08:09 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb74u71x3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Feb 2024 17:08:09 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41NH84DL24838752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Feb 2024 17:08:06 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49ECB2006A; Fri, 23 Feb 2024 17:08:04 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1DECD20069; Fri, 23 Feb 2024 17:08:04 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 Feb 2024 17:08:04 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org, Indu Bhagat Cc: Jens Remus , Andreas Krebbel Subject: [PATCH v2 8/9] gas: User readable warnings if SFrame FDE is not generated Date: Fri, 23 Feb 2024 18:07:59 +0100 Message-Id: <20240223170800.3993092-9-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240223170800.3993092-1-jremus@linux.ibm.com> References: <20240223170800.3993092-1-jremus@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: lNYOScEoeSf3n5mlTv9V5zfWyskkMcWC X-Proofpoint-ORIG-GUID: lNYOScEoeSf3n5mlTv9V5zfWyskkMcWC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-23_03,2024-02-23_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402230124 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791710317650062502 X-GMAIL-MSGID: 1791710317650062502 The following generic warning message, which is printed whenever the assembler skips generation of SFrame FDE, is not very helpful for the user: skipping SFrame FDE due to DWARF CFI op (0x) Whenever possible print meaningful warning messages, when the assembler skips generation of SFrame FDE: - skipping SFrame FDE due to .cfi_def_cfa specifying CFA base register other than SP or FP ( instead of or ) - skipping SFrame FDE due to .cfi_def_cfa_register specifying CFA base register other than SP or FP ( instead of or ) - skipping SFrame FDE due to .cfi_def_cfa_offset without CFA base register in effect - skipping SFrame FDE due to .cfi_def_cfa_offset while CFA base register other than SP or FP in effect ( instead of or ) - skipping SFrame FDE due to .cfi_val_offset specifying {FP|RA} register () - skipping SFrame FDE due to .cfi_remember_state without SFrame FRE state - skipping SFrame FDE due to .cfi_register specifying {SP|FP|RA} register () - skipping SFrame FDE due to non-default DWARF return column ( instead of ) gas/ * gen-sframe.h (SFRAME_FRE_BASE_REG_INVAL): New macro for invalid SFrame FRE CFA base register value of -1. * gen-sframe.c: User readable warnings if SFrame FDE is not generated. Reviewed-by: Andreas Krebbel Signed-off-by: Jens Remus --- gas/gen-sframe.c | 96 ++++++++++++++----- gas/gen-sframe.h | 2 + gas/testsuite/gas/cfi-sframe/common-empty-1.d | 2 +- gas/testsuite/gas/cfi-sframe/common-empty-2.d | 2 +- gas/testsuite/gas/cfi-sframe/common-empty-3.d | 2 +- 5 files changed, 79 insertions(+), 25 deletions(-) diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c index 28b49a2a8425..339f4412ca05 100644 --- a/gas/gen-sframe.c +++ b/gas/gen-sframe.c @@ -867,7 +867,7 @@ sframe_row_entry_new (void) struct sframe_row_entry *fre = XCNEW (struct sframe_row_entry); /* Reset cfa_base_reg to -1. A value of 0 will imply some valid register for the supported arches. */ - fre->cfa_base_reg = -1; + fre->cfa_base_reg = SFRAME_FRE_BASE_REG_INVAL; fre->merge_candidate = true; /* Reset the mangled RA status bit to zero by default. We will initialize it in sframe_row_entry_initialize () with the sticky bit if set. */ @@ -922,6 +922,24 @@ sframe_row_entry_initialize (struct sframe_row_entry *cur_fre, cur_fre->mangled_ra_p = prev_fre->mangled_ra_p; } +/* Return SFrame register name for SP, FP, and RA, or NULL if other. */ + +static const char * +sframe_register_name (unsigned int reg) +{ + if (reg == SFRAME_CFA_SP_REG) + return "SP"; + else if (reg == SFRAME_CFA_FP_REG) + return "FP"; +#ifdef SFRAME_FRE_RA_TRACKING + else if (sframe_ra_tracking_p () + && (reg == SFRAME_CFA_RA_REG)) + return "RA"; +#endif + else + return NULL; +} + /* Translate DW_CFA_advance_loc into SFrame context. Return SFRAME_XLATE_OK if success. */ @@ -990,7 +1008,12 @@ sframe_xlate_do_def_cfa (struct sframe_xlate_ctx *xlate_ctx, SFrame stack trace info for the function. */ if (cfi_insn->u.r != SFRAME_CFA_SP_REG && cfi_insn->u.r != SFRAME_CFA_FP_REG) - return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + { + as_warn (_("skipping SFrame FDE due to .cfi_def_cfa specifying CFA base " + "register other than SP or FP (%u instead of %u or %u)"), + cfi_insn->u.r, SFRAME_CFA_SP_REG, SFRAME_CFA_FP_REG); + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + } sframe_fre_set_cfa_base_reg (cur_fre, cfi_insn->u.ri.reg); sframe_fre_set_cfa_offset (cur_fre, cfi_insn->u.ri.offset); cur_fre->merge_candidate = false; @@ -1015,7 +1038,12 @@ sframe_xlate_do_def_cfa_register (struct sframe_xlate_ctx *xlate_ctx, skip creating SFrame stack trace info for the function. */ if (cfi_insn->u.r != SFRAME_CFA_SP_REG && cfi_insn->u.r != SFRAME_CFA_FP_REG) - return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + { + as_warn (_("skipping SFrame FDE due to .cfi_def_cfa_register specifying " + "CFA base register other than SP or FP (%u instead of %u or %u)"), + cfi_insn->u.r, SFRAME_CFA_SP_REG, SFRAME_CFA_FP_REG); + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + } sframe_fre_set_cfa_base_reg (cur_fre, cfi_insn->u.ri.reg); sframe_fre_set_cfa_offset (cur_fre, last_fre->cfa_offset); cur_fre->merge_candidate = false; @@ -1046,7 +1074,16 @@ sframe_xlate_do_def_cfa_offset (struct sframe_xlate_ctx *xlate_ctx, cur_fre->merge_candidate = false; } else - return SFRAME_XLATE_ERR_NOTREPRESENTED; + { + if (cur_fre->cfa_base_reg == SFRAME_FRE_BASE_REG_INVAL) + as_warn (_("skipping SFrame FDE due to .cfi_def_cfa_offset without CFA " + "base register in effect")); + else + as_warn (_("skipping SFrame FDE due to .cfi_def_cfa_offset while CFA " + "base register other than SP or FP in effect (%u instead of %u or %u)"), + cur_fre->cfa_base_reg, SFRAME_CFA_SP_REG, SFRAME_CFA_FP_REG); + return SFRAME_XLATE_ERR_NOTREPRESENTED; + } return SFRAME_XLATE_OK; } @@ -1097,11 +1134,19 @@ sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, instruction can be safely skipped without sacrificing the asynchronicity of stack trace information. */ if (cfi_insn->u.r == SFRAME_CFA_FP_REG) - return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + { + as_warn (_("skipping SFrame FDE due to .cfi_val_offset specifying FP register (%u)"), + SFRAME_CFA_FP_REG); + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + } #ifdef SFRAME_FRE_RA_TRACKING else if (sframe_ra_tracking_p () && cfi_insn->u.r == SFRAME_CFA_RA_REG) - return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + { + as_warn (_("skipping SFrame FDE due to .cfi_val_offset specifying RA register (%u)"), + SFRAME_CFA_RA_REG); + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ + } #endif /* Safe to skip. */ @@ -1120,7 +1165,10 @@ sframe_xlate_do_remember_state (struct sframe_xlate_ctx *xlate_ctx) early with non-zero error code, this will cause no SFrame stack trace info for the function involved. */ if (!last_fre) - return SFRAME_XLATE_ERR_INVAL; + { + as_warn (_("skipping SFrame FDE due to .cfi_remember_state without SFrame FRE state")); + return SFRAME_XLATE_ERR_INVAL; + } if (!xlate_ctx->remember_fre) xlate_ctx->remember_fre = sframe_row_entry_new (); @@ -1307,7 +1355,12 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx, || cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG #endif || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG) - err = SFRAME_XLATE_ERR_NOTREPRESENTED; + { + as_warn (_("skipping SFrame FDE due to .cfi_register specifying %s register (%u)"), + sframe_register_name (cfi_insn->u.rr.reg1), + cfi_insn->u.rr.reg1); + err = SFRAME_XLATE_ERR_NOTREPRESENTED; + } break; case DW_CFA_undefined: case DW_CFA_same_value: @@ -1315,21 +1368,19 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx, default: /* Following skipped operations do, however, impact the asynchronicity: - CFI_escape. */ - err = SFRAME_XLATE_ERR_NOTREPRESENTED; - } - - /* An error here will cause no SFrame FDE later. Warn the user because this - will affect the overall coverage and hence, asynchronicity. */ - if (err) - { - const char *cfi_name = sframe_get_cfi_name (op); - - if (!cfi_name) - cfi_name = _("(unknown)"); - as_warn (_("skipping SFrame FDE due to DWARF CFI op %s (%#x)"), - cfi_name, op); + { + const char *cfi_name = sframe_get_cfi_name (op); + + if (!cfi_name) + cfi_name = _("(unknown)"); + as_warn (_("skipping SFrame FDE due to DWARF CFI op %s (%#x)"), + cfi_name, op); + err = SFRAME_XLATE_ERR_NOTREPRESENTED; + } } + /* Any error will cause no SFrame FDE later. The user has already been + warned. */ return err; } @@ -1346,7 +1397,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, /* If the return column is not RIP, SFrame format cannot represent it. */ if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) { - as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); + as_warn (_("skipping SFrame FDE due to non-default DWARF return column (%u instead of %u)"), + xlate_ctx->dw_fde->return_column, DWARF2_DEFAULT_RETURN_COLUMN); return SFRAME_XLATE_ERR_NOTREPRESENTED; } diff --git a/gas/gen-sframe.h b/gas/gen-sframe.h index fbe2fd5d9368..8ed46dbb087b 100644 --- a/gas/gen-sframe.h +++ b/gas/gen-sframe.h @@ -24,6 +24,8 @@ #define SFRAME_FRE_ELEM_LOC_REG 0 #define SFRAME_FRE_ELEM_LOC_STACK 1 +#define SFRAME_FRE_BASE_REG_INVAL ((unsigned int)-1) + /* SFrame Frame Row Entry (FRE). A frame row entry is a slice of the frame and can be valid for a set of diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-1.d b/gas/testsuite/gas/cfi-sframe/common-empty-1.d index d7756302b559..08731b069229 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-1.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-1.d @@ -1,5 +1,5 @@ #as: --gsframe -#warning: skipping SFrame FDE due to DWARF CFI op DW_CFA_remember_state \(0xa\) +#warning: skipping SFrame FDE due to \.cfi_remember_state without SFrame FRE state #objdump: --sframe=.sframe #name: Uninteresting cfi directives generate an empty SFrame section #... diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-2.d b/gas/testsuite/gas/cfi-sframe/common-empty-2.d index 20282c7854e8..e759cddfcc20 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-2.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-2.d @@ -1,5 +1,5 @@ #as: --gsframe -#warning: skipping SFrame FDE due to DWARF CFI op DW_CFA_def_cfa_offset \(0xe\) +#warning: skipping SFrame FDE due to \.cfi_def_cfa_offset without CFA base register in effect #objdump: --sframe=.sframe #name: SFrame supports only FP/SP based CFA #... diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d index d17521dd88ea..9a46b016a9ba 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d @@ -1,5 +1,5 @@ #as: --gsframe -#warning: skipping SFrame FDE due to non-default DWARF return column +#warning: skipping SFrame FDE due to non-default DWARF return column \(0 instead of \d+\) #objdump: --sframe=.sframe #name: SFrame supports only default return column #...