From patchwork Thu Feb 22 16:01:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 204847 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp38552dyb; Thu, 22 Feb 2024 08:05:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXa+j1qi2Jq0JRxCj61cUzrcpAbVNwzQKXsCBV1BqY33ov7bD6op7AnY9ApW/qNt8RY4vzFqlNujSNF6XnEOvsc6g02SA== X-Google-Smtp-Source: AGHT+IF6DPy+ZM1j8vrScJ14K9suG/0QuUOXCkQVzBeDP1zZsEzSpnaWkUI9Bd7YSOrJnTn0Jt4V X-Received: by 2002:a05:620a:12fc:b0:787:a7d6:7f17 with SMTP id f28-20020a05620a12fc00b00787a7d67f17mr916655qkl.20.1708617939776; Thu, 22 Feb 2024 08:05:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708617939; cv=pass; d=google.com; s=arc-20160816; b=yLO6VVxJIUs6WlLQDC/bVhn2eRzGK6rhbGplWFqaBitLQGG2oCxzmDIJ8KkvScxhFf bWJFezPB3xWuKLUWHJG5UXmh4wzleGq3A57pa/gPk1aiYMRqWF9k0+quGQDoxiF9GHlG 84CUZAMw8eWvtZArdumK6KdDWnMnwFH78nLD4ROCVMvTFsYnVNO0tCPB9PL+sHAUZrLe oiBKKh4C46WqQDogROUtO6XwkqendP+LOKukA+2/MC/+yGIsnU1UI2P2G+C3j4OCzJJd wArbRX1fVTgYSgxTVg1WfSWEymb4KfxecIVT0ZicKIKcd/4iB696JbnfGh0xoKvzZQ6P XyBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=xc0ac9H02FAYFCeJ/bKpc3sW7Bi4+/xiIRQP/uN96/Y=; fh=vTbGg4wY0rLaolKO+EtTu7rlJzNAP3iHbUH+MVoijcQ=; b=iSBlR4lI8zjDViQx/kv3FRXlEh3bok0IbANyykxEy+ON+k9UAUr+GAZ1fLqeeFeBxz fVeJCocwWItMST/BnDQ9/oiJWzYeu9MKyAvtuEdergGcaokBo9ZYJEyRkiZdliaNPnlY h+XjnN3VhSNqJbMPgbLTxNGkjWb2t+HAwisBUHVh5vl6dEzF5DFrkM1pY8tQYx7+9Vl+ 8KuslJ6vXRqLGPRvqGL2zXhupsx9eAjAZn0Par2YHUG4G5YU1gkjqvdZCl2uUU03nO0T 3+LWjvC5c7iE2iC3Fapyz1MXnL2d2j2P8rgAL1vhtZk8FKovlftXw5FX72VOSDDb34m+ kvow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HMBS69cw; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a21-20020a05620a02f500b007878d8964bfsi1442571qko.316.2024.02.22.08.05.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 08:05:39 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HMBS69cw; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 704D0385841A for ; Thu, 22 Feb 2024 16:05:39 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 5B9DA3858420 for ; Thu, 22 Feb 2024 16:01:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B9DA3858420 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B9DA3858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708617724; cv=none; b=p1PbM3Wwb0jUc7GynZEs6oyKvgfH3aXsOLvsqvitj7nDpWK/CSXvJZrsMepBJBr4z+DEhGIpINrTG65cbgSMOPyMhfl/YP/05JNJHKmMprqWU0zzM8QybUBK3KtRekIaJEGIvH7vA+ZoGFw8GY9xotdebT/KXEkb1qkMWhzs3Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708617724; c=relaxed/simple; bh=8wXT1CTqqwfOVlzLDmsKJiYjkWRNBXZlnhJUrQQWVFg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=JkcWJYJ7+myGTwPWq8IL/9p5mWaAwS49NsB+Cye4YlJZi07Vzyy+Tdt76xd7NitzY6jxZMwgeeF37zPW7OEXp/wTA4mitIG+HAk522gu1+QYVMEulIgURIkTEg6CJXHMeaCPlwZ3feUR3oSUtbyGQtaKNfbU671OwUFiT5DomDQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41MG1Cdp022064; Thu, 22 Feb 2024 16:01:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=xc0ac9H02FAYFCeJ/bKpc3sW7Bi4+/xiIRQP/uN96/Y=; b=HMBS69cw/G7WTz/N5InpA93/R91aF30bGorvqm6HasXRge1Q2idRG94t00JG7iXGXz6o nFclGtYJlEBMKq1B3DhosYJCjfKVPSZ1vYAFjiVVBP46F4Nzm0PI5nlVGdAepFalP5bf gsczuwTzUaqbsVgu3VBTL/OA0pZNmWaTruLmH1Qmet9L9wZee338tK3Y9/0BtNhJsLHt 2iGH3iXVshvgbsbEJsM5QwyDbntATK9FT7At5e0mZoQx3wdNRm+7XtfhrumzakPV2C8F UXE6VFz4x6/cHUVrAia/wq5HdzLYVZwB/r2msSFh8y+yg7hh8OMJbRgJdBEsRXzjEPKE eg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3we8b424n8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Feb 2024 16:01:33 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41MFVd0E031138; Thu, 22 Feb 2024 16:01:32 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb9bm6ske-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Feb 2024 16:01:32 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41MG1Rb726345798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Feb 2024 16:01:29 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C1A120070; Thu, 22 Feb 2024 16:01:27 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C38F2006B; Thu, 22 Feb 2024 16:01:27 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Feb 2024 16:01:26 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org, Indu Bhagat Cc: Jens Remus , Andreas Krebbel Subject: [PATCH 7/9] gas: Warn if SFrame FDE is skipped due to non-default return column Date: Thu, 22 Feb 2024 17:01:21 +0100 Message-Id: <20240222160123.2554459-8-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240222160123.2554459-1-jremus@linux.ibm.com> References: <20240222160123.2554459-1-jremus@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: IjuSEPi5mQwZ_qe72TfkQL5RIDyfDqHm X-Proofpoint-ORIG-GUID: IjuSEPi5mQwZ_qe72TfkQL5RIDyfDqHm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-22_11,2024-02-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402220127 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791615764573508028 X-GMAIL-MSGID: 1791615764573508028 Print a warning message if SFrame FDE is skipped due to a non-default DWARF return column (i.e. return address (RA) register number). This may be caused by the use of CFI directive .cfi_return_column with a non-default return address (RA) register number in the processed assembler source code. Warning: skipping SFrame FDE due to non-default DWARF return column gas/ * gen-sframe.c: Warn if SFrame FDE is skipped due to non-default DWARF return column. gas/testsuite/ * gas/cfi-sframe/common-empty-3.d: Update test case to expect for new warning message when SFrame FDE is skipped due to a non-default DWARF return column. Reviewed-by: Andreas Krebbel Signed-off-by: Jens Remus --- Notes (jremus): Without this patch the assembler would erroneously generate bad SFrame information for the s390-specific SFrame error test case 4, that gets introduced by patch "s390: Initial support to generate .sframe from CFI directives in assembler". gas/gen-sframe.c | 8 ++++++-- gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c index 1269b2b77c54..28b49a2a8425 100644 --- a/gas/gen-sframe.c +++ b/gas/gen-sframe.c @@ -1345,7 +1345,10 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, /* If the return column is not RIP, SFrame format cannot represent it. */ if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) - return SFRAME_XLATE_ERR_NOTREPRESENTED; + { + as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); + return SFRAME_XLATE_ERR_NOTREPRESENTED; + } /* Iterate over the CFIs and create SFrame FREs. */ for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) @@ -1355,7 +1358,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, if (err != SFRAME_XLATE_OK) { /* Skip generating SFrame stack trace info for the function if any - offending CFI is encountered by sframe_do_cfi_insn (). */ + offending CFI is encountered by sframe_do_cfi_insn (). Warning + message already printed by sframe_do_cfi_insn (). */ return err; /* Return the error code. */ } } diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d index 5914c620760d..d17521dd88ea 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d @@ -1,4 +1,5 @@ #as: --gsframe +#warning: skipping SFrame FDE due to non-default DWARF return column #objdump: --sframe=.sframe #name: SFrame supports only default return column #...