From patchwork Thu Feb 15 15:58:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 201600 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp495616dyb; Thu, 15 Feb 2024 08:00:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVpJgbz6EDP5Ys6UnRKJFNpgwpvwonv7nLqyl8qw/AQwxqtLU1hfyMdDtaUE3kTAI6exIlp5CME5FKD4AEi+6wU0J8Ecg== X-Google-Smtp-Source: AGHT+IGci0UMHHck/VoPH7SgwKUbAVWwgn4boV1Z/CEpNuO4uqlMGKX6xYCem4sOOB79gdTAE406 X-Received: by 2002:a05:620a:81d:b0:787:2262:aa7f with SMTP id s29-20020a05620a081d00b007872262aa7fmr8237395qks.31.1708012830300; Thu, 15 Feb 2024 08:00:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708012830; cv=pass; d=google.com; s=arc-20160816; b=oZ+21YHrP9qT9Jk44rCZEkTUXLGltZC/xLpGwOriqRXGqoHY/JiXRDzvkEET8Q5+6F pW3CsemffJokb34x+nxWV5J7MsD9mBKI3KgrMXbXZCTq1AsoPOwogKtoHwkpIiu9kee+ gDNEQDqQ4vVait4qtdat9MqEAYv5Oh7VKYvD37kKfDV0Dc7g5PNF/WQqFkCVhIN1Z5A8 r3wxj4v+bEkTlekMUM3sNmqqR/Cq4L2gwLYN5sFOZnKLXWrqP6MEET4VYLqEuYhE+JIQ beMTFsTVXDYZ75+kg9dcitrJRGKHMiCVeMxtLtYhrgWO8D41BEZ5eXKuBGBOjlfeZr9L sqwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=lmBrIPAsOi8m/3HLgAbvRtEkU/Np73Lh149Oi8jVOnw=; fh=6sWHPsCQUoLz5ZcbqIohOjwdU7jjRT/citiAJwaEf0c=; b=FcbPV9sI29BwAupdf0njhKdGftqxtqvWhkJtJHgy2KRY7UsiUPEy0HedlKfS3JWngj GSkJz1WYGhK9mORGh8oI+i6he3lzDlQAxFN6RQ4A04TztIQh5r6Rl5KaMdAWYjss2gkD qSTk260hmWQAiYix5z6YP8JG0Hq5zlmyZaLBCpl4FAtVG+PtAJl4h8cZqwbd5zEzSOTZ lr2wYR19AXsGrRdIfvZm+1bKGSUbr0BZDah3XhXbffpt+jAxGYjso+YLtNraMIYzcCaA sCYO5yRXT2YCHVY9MtQxhZXJ7yIPf3d2UXv94sLK4caPmCErQS2H58kmzbgx5ilDhEQb r8bw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=J5XdXKh2; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qf8-20020a05620a660800b0078738447127si1235667qkn.58.2024.02.15.08.00.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 08:00:30 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=J5XdXKh2; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00875384DEFD for ; Thu, 15 Feb 2024 16:00:20 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D5BB9384DEE4 for ; Thu, 15 Feb 2024 15:58:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5BB9384DEE4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5BB9384DEE4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708012718; cv=none; b=Va9vFGtNg7UKMyWZbGHqTpJVlccYU2BEstUmAV6IfD6cYpEWMnYR0r6QO1Ep6mgYB8uck2grAhHDy8wYFkYd5+rLqAwATW6ms3Tye6R1y5K3aOkpdtPLqVFiTAWZCkiXHzfjF/HpynSxqzMDwdStijC63mF8w8ANRInJ10zfgXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708012718; c=relaxed/simple; bh=arKG4G+aa61yzz6bgy3vm2SuUx/S0W9awc7uALOUa3g=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SQrKaSfhh4JZeFzmEZTOtztyZscchZ2aNnFje0fPLP1KbpNqfM+gAnS83i9EAVsDmVeB93c2SCDxucgOjAqTd/BLL5xjTqWSVZKtIv1ZEuBwgJERXtI1uPFUcqp7ZFFssFLmcEb0qRvtOEs34J3ha1HJDv40p5lL3h63t1KdoqI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FFashH003985 for ; Thu, 15 Feb 2024 15:58:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=lmBrIPAsOi8m/3HLgAbvRtEkU/Np73Lh149Oi8jVOnw=; b=J5XdXKh2yvUD7jp1N+Y8+N9Dla7bnKHqEjBJX8147dUUIAqXHXUJn9Tpr4kzPhTSjnD0 rAzAp+1p03XQ6IlZWQUhs8WKliWRlwpW/yOnJzRKBdgh6WwKxGSxRiYfqj6NsGC0N3TO kMgKC7dCy5iwki3nKORDGB3uZAFhLO+cZSnDRcAlQxj959iVUaemLAKCQNa5SQiB3JQA ga7JMkw8fENIkv9QZXipAGqDxvTJqMNHwK4VhOTYkcKWcs56Ejlg5dSWwqWlI2cwLzik UE1NmwWMRFjWY8BZNvR1Jg9VvDcOf0BXf8eaD8M+eeOtdpzxteAEHWnjVkaQLaxG4VF3 PQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w9ndkrg6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Feb 2024 15:58:34 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41FDEldh004254 for ; Thu, 15 Feb 2024 15:58:33 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w6kv0nx35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Feb 2024 15:58:33 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41FFwSid26215076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 15:58:30 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34EC220040; Thu, 15 Feb 2024 15:58:28 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1595A2004D; Thu, 15 Feb 2024 15:58:28 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2024 15:58:28 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org Cc: Jens Remus , Andreas Krebbel Subject: [PATCH 01/14] s390: Lower severity of assembler syntax errors from fatal to error Date: Thu, 15 Feb 2024 16:58:08 +0100 Message-Id: <20240215155821.4065623-2-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240215155821.4065623-1-jremus@linux.ibm.com> References: <20240215155821.4065623-1-jremus@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BLREV9FBOYg7Rk-xABLZh17BPzA2nAsi X-Proofpoint-ORIG-GUID: BLREV9FBOYg7Rk-xABLZh17BPzA2nAsi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_14,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 mlxscore=0 spamscore=0 mlxlogscore=396 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150129 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790981261970572404 X-GMAIL-MSGID: 1790981261970572404 Report s390 assembler syntax errors as error instead of fatal error. This allows the assembler to continue and potentially report further syntax errors in the source. This should not cause syntax errors to be erroneously accepted, as both error and fatal error cause the assembler to return with a non-zero return code. The following syntax errors are changed from fatal to error: - invalid length field specified - odd numbered general purpose register specified as register pair - invalid floating point register pair. Valid fp register pair operands are 0, 1, 4, 5, 8, 9, 12 or 13. gas/ * config/tc-s390.c: Lower severity of assembler syntax errors from fatal to error. * testsuite/gas/s390/zarch-z9-109-err.l: Likewise. Reviewed-by: Andreas Krebbel Signed-off-by: Jens Remus --- gas/config/tc-s390.c | 12 ++++++------ gas/testsuite/gas/s390/zarch-z9-109-err.l | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gas/config/tc-s390.c b/gas/config/tc-s390.c index 09a903aea2db..1b7935a848d0 100644 --- a/gas/config/tc-s390.c +++ b/gas/config/tc-s390.c @@ -1346,7 +1346,7 @@ md_gather_operands (char *str, { if ((operand->flags & S390_OPERAND_LENGTH) && ex.X_op != O_constant) - as_fatal (_("invalid length field specified")); + as_bad (_("invalid length field specified")); if ((operand->flags & S390_OPERAND_INDEX) && ex.X_add_number == 0 && warn_areg_zero) @@ -1358,17 +1358,17 @@ md_gather_operands (char *str, if ((operand->flags & S390_OPERAND_GPR) && (operand->flags & S390_OPERAND_REG_PAIR) && (ex.X_add_number & 1)) - as_fatal (_("odd numbered general purpose register specified as " - "register pair")); + as_bad (_("odd numbered general purpose register specified as " + "register pair")); if ((operand->flags & S390_OPERAND_FPR) && (operand->flags & S390_OPERAND_REG_PAIR) && ex.X_add_number != 0 && ex.X_add_number != 1 && ex.X_add_number != 4 && ex.X_add_number != 5 && ex.X_add_number != 8 && ex.X_add_number != 9 && ex.X_add_number != 12 && ex.X_add_number != 13) - as_fatal (_("invalid floating point register pair. Valid fp " - "register pair operands are 0, 1, 4, 5, 8, 9, " - "12 or 13.")); + as_bad (_("invalid floating point register pair. Valid fp " + "register pair operands are 0, 1, 4, 5, 8, 9, " + "12 or 13.")); s390_insert_operand (insn, operand, ex.X_add_number, NULL, 0); } } diff --git a/gas/testsuite/gas/s390/zarch-z9-109-err.l b/gas/testsuite/gas/s390/zarch-z9-109-err.l index 1b06f93441a0..84d294de960a 100644 --- a/gas/testsuite/gas/s390/zarch-z9-109-err.l +++ b/gas/testsuite/gas/s390/zarch-z9-109-err.l @@ -1,2 +1,2 @@ .*: Assembler messages: -.*:3: Fatal error: odd numbered general purpose register specified as register pair +.*:3: Error: odd numbered general purpose register specified as register pair