From patchwork Wed Feb 7 17:31:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 197996 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2388484dyb; Wed, 7 Feb 2024 09:31:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5DoN7yXKRKnpS/Aoxxhpt/JW5ut6tyr3Xmgi6tAL9P905iYntEzMr4D6n4qzBz0XrR7sN X-Received: by 2002:a9d:7b4d:0:b0:6dc:5995:7232 with SMTP id f13-20020a9d7b4d000000b006dc59957232mr5896429oto.32.1707327090928; Wed, 07 Feb 2024 09:31:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707327090; cv=pass; d=google.com; s=arc-20160816; b=OOL7JZPDKCmPvgbRCMAwT+6UBAGMsbpDkgkjvKNJzUcfm010ZijjsXBPE3hNjUyp7k 69I8/w31bFpiweY8NgVm5yh+Ab5p7oWXxPwpTfwieg+3CI4mPmXZIIHqyLc4AyoPd+8Q rsqX2xzXkh5OBfcPPvmqrlq5g2MohBw6gn0ilWjlLXPXLmQT/Javxb3qU/SHXJGFIyEj q2qu4kKkr2nrxFbRe/XV7dWjMd/3LidWk5Cdf9Mv9aoHo61LSzRSZjdOOxHqBnU7V27J WZQ+RM5cofPFoapXFEdbQYsIomcHZWO4zr4QMnO8nY6+UG+F6yypKpK0w6QZlIb9uisX Naqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:arc-filter :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=vqsNZNtl8lN+YcMHA5myRln6lVk8XbdmrlEmAXQuxXo=; fh=Q+taBGn/wbIAzEM0frQrfL9030RSi7cgXjIMs0T0TYY=; b=DA8HCeqYdnm31hvT7ZYws9aLYCK3L0gbTk0PemFsmDpUUaQ+lDSqhSjQQSoWUSxTBt jAcSs8HqNOiz3E4V6V5+Zb/G7ZWlRa6MnOpykEiFMOpiiHZYYuHvcieJNg8Wm26pvbcb 7lYW+6z1gtsLcn0ccTyK4MkyjvQhGCAFVGXg6NMi1BiMykqajjtwz8uGxnUvJ79qB1pe pPRq3SstjyQLqkjOK8/hQV+0aQJPtc841zABmEHvCH/U/RNAsO8e2//8iQy1xJ4GLcEf f3Yh8vduRoXoUpAxsD0kJ/7qpW7r5OP1AIdC1ChtAXKjgWv86Ckr3NVwt4VzF0m4d/6y bZ3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=B+cwoh7b; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org X-Forwarded-Encrypted: i=2; AJvYcCXIAqXfZ1lLeHwM4ITWJrFzWPHAiR/LBD/sqN7M4kZ1zIYiQiXsw5qkenSV20CDgH3wFfwmd6iG6jPfRV8JEMf1ciEbOw== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z10-20020ac87f8a000000b0042c3ed8f29bsi1481586qtj.391.2024.02.07.09.31.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 09:31:30 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=B+cwoh7b; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91DF53857C4A for ; Wed, 7 Feb 2024 17:31:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91DF53857C4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1707327090; bh=vqsNZNtl8lN+YcMHA5myRln6lVk8XbdmrlEmAXQuxXo=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=B+cwoh7beInbWdASb2OfuERp1w62P4vWTDPEfYCkOl4ReD+SFrbQwU6M43go6ltMn CFC1gz+UAJf91imeFbBg3MnKfaIe5z4JHZ37Ds3HshVT+TbdRiiWCpNZFQFsht/a0n 6QiAC+vUJZSuzuT+8KhWIO43gQidlqkNfh6oY5eg= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by sourceware.org (Postfix) with ESMTPS id 84A9438582A1 for ; Wed, 7 Feb 2024 17:31:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84A9438582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84A9438582A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707327079; cv=none; b=sVBR5PelNDtg1VdL4fhjW34ZV6vn7+ijrBggKhU/zdZxBm9TMhzZ785yzDo15PhoS6gNWJelxMIdmPTneyvYEUUtA8m6WEK9Wv6NUyO5caClpxsJbk3ar//uK9sC2gSawE2NPcC2uRVCGAB/MjwXQPQpVo+2Ic/rN0yEbIHvIjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707327079; c=relaxed/simple; bh=xcNOFWeOE/6hC7NAG1u6Bj0nqGXxV8fbDtJjFb3kt8A=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Qvg+SS/ZcI/9u9v5VjtNAatL4JngrHxjhYkxtd4i99M1hk/Z1jcAg060BoCBVjLAEICqaK4jJZvG0WjfNYWSbgucR7BJglp7HYyKasbjjP5MiEKv6PXEbxCK68lTqOz1gMb9GQG5CjYUw4DOyG7hCquP+DEx520pfG00ML3yulU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d73066880eso8101885ad.3 for ; Wed, 07 Feb 2024 09:31:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707327075; x=1707931875; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vqsNZNtl8lN+YcMHA5myRln6lVk8XbdmrlEmAXQuxXo=; b=QF3j/sZVf/PES7KWQw5NUbtQ+4Y9LO+lumHbP/nufTvovbF+BauvUl77iKB34u0ckx KJZcm2RehxverC4cenM0BIcdUxN9dZO6VZT+D2OtXO32OQu44udvAj9j/mQtGDbLY/sl F0ib6/e8jLdCXFnEY8OcqkroRU0MsfnhCoEVwMqCSDHkduwps7lqh3k5CpdCTKQ0lfUw nkG9PyKG89nIVZkAllUMJENwgYgOWW3ubAMB/82SJFW4blBsNc5k3qxgB51l4HFl5MFE ug/LUxyNL5nkbdjislwNaTqFrRvMjlHok17t8IWrli5xXcP5CRFYC6zG7FeRm4/7b/pG oaxw== X-Gm-Message-State: AOJu0YxOw/uK2kFBnyb0+ESbkhUj3f9GrgeU5WZCuVVh/RfjRfeOeE/L wKqo7TVv/uyslKNDgj6lIaxxsgVDIXdtZW0Xt1Acnlc3Dvqd+CsQEakxZ0qh15U= X-Received: by 2002:a17:902:c947:b0:1d9:8082:4573 with SMTP id i7-20020a170902c94700b001d980824573mr7083167pla.2.1707327075375; Wed, 07 Feb 2024 09:31:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUGiREk6C9zAf4y9osLNFBJlxy4lEAqt9DMbGVwNdEnqG9owqFz00APmTgS10JLvJO0n42dzme1VwuU65bC85lkkHoUTpsJVNA9xktci5PdCTEXa0Oj Received: from localhost.localdomain ([149.248.38.156]) by smtp.gmail.com with ESMTPSA id li8-20020a170903294800b001d9a44617b3sm1722548plb.52.2024.02.07.09.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 09:31:14 -0800 (PST) From: YunQiang Su To: nickc@redhat.com Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site Subject: [PATCH v5] MIPS: Reject branch absolute relocs for PIC for linking Date: Thu, 8 Feb 2024 01:31:02 +0800 Message-Id: <20240207173102.2989195-1-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790262211706403148 X-GMAIL-MSGID: 1790262211706403148 The asm code like: b (8) will emit absolute relocs like: R_MIPS_PC16 *ABS* If they are included into PIC shared objects or PIE executables, the branch target will be like 0x12340000, which will make the programs crash. --- bfd/elfxx-mips.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index 69dd71419ff..9542250dec4 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -9258,6 +9258,15 @@ _bfd_mips_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, (h) ? h->root.root.string : "a local symbol"); break; default: + if (branch_reloc_p (r_type) && r_symndx == STN_UNDEF) + { + howto = MIPS_ELF_RTYPE_TO_HOWTO (abfd, r_type, NEWABI_P (abfd)); + info->callbacks->einfo + /* xgettext:c-format */ + (_("%X%H: relocation %s against `*ABS*' cannot be used" + " when making a PIC/PIE object\n"), + abfd, sec, rel->r_offset, howto->name); + } break; } }