From patchwork Sun Jan 21 23:16:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 189855 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2275219dyb; Sun, 21 Jan 2024 15:16:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IECQVsDL3gElLXHptETCjjIWVCgvK3LHVvDpSZOT72+Rbnrm4xByl/fg1xnNlwkCnCh6Lmo X-Received: by 2002:ac8:5a44:0:b0:42a:3b6f:45f9 with SMTP id o4-20020ac85a44000000b0042a3b6f45f9mr1255816qta.6.1705879001961; Sun, 21 Jan 2024 15:16:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705879001; cv=pass; d=google.com; s=arc-20160816; b=sTN9SoARHptJE1n7LwysdJiXj7xRdLZ2IPnlzNZMbjhv+MyTFdItTHwaVLK3V37TWd rkIDM+ut4475XB9IOd0J4ZI9KfdWZ80ORIpB5KqpY7eUfmrEvB25Pof+13GB/PzjceEV RTzFEdWeZRIWkAj2Ynk8K3+sAs28QVu2XyfePVUFa7uT8wk//p9Ckbb0JEyg+iI4GmPG 6TqyemWyPpaLnMlgCeNXPlluz4fBXe7eCsDGhUf2nmmoOQjoOZtz3Fka4wr8YD44MAkm ksknw7+0l7/6ZmfR2jOByctvoIPIIjjXfZo3GMc1flPr6jlhIpBvCfDqhhB+pbV1xVda LaaA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:arc-filter :dmarc-filter:delivered-to; bh=LtLqB797lxzKV9m/cIO2phUvNvn++iB8f8pMz6K405k=; fh=qQgnx8Mzsg+6vWD9I4zyL4sFV7Oadfy083csqHfiKLc=; b=x8WPbb7C1UyhZhMKSI5/BncEG77CJQzINOAxQqJcYb1IuDjvPNeeErqvyyGUzu1VFq amybON2FkcAxAf7YarWuJRVHqBs+YryrL65qGTG6JdGzsZkyqmO6WhQj9HYCdXOW25pq cSIeuJeGp077pTAImTcviAVLSmr64uRVs92YBGpy3z2KvbI6yxQcdahjkKNzPUMp0C3n Xbb/d86KlMhfP0pz2oFyZY0dsC2jmU/ixoPbCAsQGeJ4wrhPX9TI0MItEA5IQrhdZPQ7 i8dhmrM1qrzKXma67i5Cz1L45q6R5AZDvxhQQFEiECNrBuB57+zzMsbcHXmuvl5hGW1f yWDA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id g9-20020ac85809000000b0042a428378a5si177797qtg.196.2024.01.21.15.16.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 15:16:41 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A842E385E000 for ; Sun, 21 Jan 2024 23:16:41 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id C69163858D3C for ; Sun, 21 Jan 2024 23:16:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C69163858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C69163858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705878992; cv=none; b=J219aw1emXNWsFoQ6tq72NujMPvcK9okyyqfu9kl8xYgyNkjSxzegxazwGUFsVOzp+LTm8kaGD0Qf/9ZfVvzRStq9eaaQKX3HMLtLgCLnCm4rZdgOAWmMQQTymAV8x0MnWhaTyVmzSMMphuzySalVNCzEIAv7XfSpLEfhtCWuZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705878992; c=relaxed/simple; bh=yzQRQ/1R24lj6F7UuJr1kP0CToRamtd1d7og6L0jAU8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=ktbUCcUV2upalw7VrIA4Zt4005zgc2n8RtVf1rlP5jTiQdzYF6vqecYBg2Ir94kzxtgCAWPNE0y4PJDNufE64ei1XXM5ZROHPij9AUa3fZPZmFohKWAE4d+DXTAnJ2uVBRwnwgDXKkNqk3BndRp+AxIE0dNjUgfyunkr0NIyyRY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from csb.redhat.com (deer0x03.wildebeest.org [172.31.17.133]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id AFC88302BBEA; Mon, 22 Jan 2024 00:16:29 +0100 (CET) Received: by csb.redhat.com (Postfix, from userid 10916) id 6E935CEF2C; Mon, 22 Jan 2024 00:16:29 +0100 (CET) From: Mark Wielaard To: binutils@sourceware.org Cc: Indu Bhagat , Mark Wielaard Subject: [PATCH] libsframe: Fix calloc argument order in dump_sframe_header Date: Mon, 22 Jan 2024 00:16:21 +0100 Message-Id: <20240121231621.576801-1-mark@klomp.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788743780514838769 X-GMAIL-MSGID: 1788743780514838769 GCC14 warns about the order of the arguments to calloc libsframe/sframe-dump.c: In function ‘dump_sframe_header’: libsframe/sframe-dump.c:70:39: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 70 | flags_str = (char*) calloc (sizeof (char), SFRAME_HEADER_FLAGS_STR_MAX_LEN); | ^~~~ libsframe/sframe-dump.c:70:39: note: earlier argument should specify number of elements, later size of each element Fix this by swapping the size and count arguments. libsframe/ * sframe-dump.c (dump_sframe_header): Swap arguments to calloc --- libsframe/sframe-dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 0d596918f72..42a086a5691 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -67,7 +67,7 @@ dump_sframe_header (sframe_decoder_ctx *sfd_ctx) /* Prepare SFrame section flags string. */ flags = header->sfh_preamble.sfp_flags; - flags_str = (char*) calloc (sizeof (char), SFRAME_HEADER_FLAGS_STR_MAX_LEN); + flags_str = (char*) calloc (SFRAME_HEADER_FLAGS_STR_MAX_LEN, sizeof (char)); if (flags) { if (flags & SFRAME_F_FDE_SORTED)