diff mbox series

i386: Use .insn describe jmpabs's testcases.

Message ID 20240108075310.1750454-1-lin1.hu@intel.com
State Unresolved
Headers
Series i386: Use .insn describe jmpabs's testcases. |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Hu, Lin1 Jan. 8, 2024, 7:53 a.m. UTC 
  Hi, all

We try to use .insn describe these inval tests.

BRs,
Lin

gas/ChangeLog:

	* testsuite/gas/i386/x86-64-apx-jmpabs-inval.s: Modify tests.
---
 gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jan Beulich Jan. 8, 2024, 7:57 a.m. UTC | #1 
On 08.01.2024 08:53, Hu, Lin1 wrote:
> Hi, all
> 
> We try to use .insn describe these inval tests.
> 
> BRs,
> Lin
> 
> gas/ChangeLog:
> 
> 	* testsuite/gas/i386/x86-64-apx-jmpabs-inval.s: Modify tests.

Perhaps replace "Modify" with what you're actually doing. Only then will
it be okay-ish for the change to come with no textual description. Okay
with a suitable adjustment.

Jan

> ---
>  gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
> index de4440a5466..481fc7ca1d1 100644
> --- a/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
> +++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
> @@ -2,14 +2,14 @@
>  
>  	.text
>  # With 66 prefix
> -	.byte 0x66,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
> +	.insn {rex2} data16 0xa1, $1{:u64}
>  # With 67 prefix
> -	.byte 0x67,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
> +	.insn {rex2} addr32 0xa1, $1{:u64}
>  # With F2 prefix
> -	.byte 0xf2,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
> +	.insn {rex2} repne 0xa1, $1{:u64}
>  # With F3 prefix
> -	.byte 0xf3,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
> +	.insn {rex2} rep 0xa1, $1{:u64}
>  # With LOCK prefix
> -	.byte 0xf0,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
> +	.insn {rex2} lock 0xa1, $1{:u64}
>  # REX2.M0 = 0 REX2.W = 1
>  	.byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
diff mbox series

Patch

diff --git a/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
index de4440a5466..481fc7ca1d1 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
+++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s
@@ -2,14 +2,14 @@ 
 
 	.text
 # With 66 prefix
-	.byte 0x66,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
+	.insn {rex2} data16 0xa1, $1{:u64}
 # With 67 prefix
-	.byte 0x67,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
+	.insn {rex2} addr32 0xa1, $1{:u64}
 # With F2 prefix
-	.byte 0xf2,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
+	.insn {rex2} repne 0xa1, $1{:u64}
 # With F3 prefix
-	.byte 0xf3,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
+	.insn {rex2} rep 0xa1, $1{:u64}
 # With LOCK prefix
-	.byte 0xf0,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00
+	.insn {rex2} lock 0xa1, $1{:u64}
 # REX2.M0 = 0 REX2.W = 1
 	.byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00