diff mbox series

[2/2] x86: Append "#pass" to APX tests

Message ID 20231229235033.338761-2-hjl.tools@gmail.com
State Unresolved
Headers
Series [1/2] x86: Don't use .insn with '/' |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

H.J. Lu Dec. 29, 2023, 11:50 p.m. UTC 
  Append "#pass" to APX tests for targets which pad text sections with NOPs.

	* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
	"#pass".
	* testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
	* testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
	* testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.
---
 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d | 1 +
 gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d      | 1 +
 gas/testsuite/gas/i386/x86-64-apx-ndd.d               | 1 +
 gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d  | 1 +
 gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d        | 1 +
 5 files changed, 5 insertions(+)

Comments

Jan Beulich Jan. 4, 2024, 9:35 a.m. UTC | #1 
On 30.12.2023 00:50, H.J. Lu wrote:
> Append "#pass" to APX tests for targets which pad text sections with NOPs.
> 
> 	* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
> 	"#pass".
> 	* testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.

It's interesting that you found a need for this, when I'm sure I made a
comment to this effect during review (somewhere in the series, but
obviously applicable throughout). When approving, you didn't check that
all review comments were addressed, did you?

Jan
diff mbox series

Patch

diff --git a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
index 3bfb5dec202..57bdf64c858 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d
@@ -39,3 +39,4 @@  Disassembly of section .text:
 [ 	]*[a-f0-9]+:[ 	]+62 74 7c 18 8f c0[ 	]+pop2   %rax,\(bad\)
 [ 	]*[a-f0-9]+:[ 	]+62 d4 3c 18 8f[ 	]+\(bad\)
 [ 	]*[a-f0-9]+:[ 	]+c0[ 	]+.*
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
index 48f0f1ceee3..773ceea686c 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-ndd-optimize.d
@@ -130,3 +130,4 @@  Disassembly of section .text:
 \s*[a-f0-9]+:\s*62 74 3e 18 66 c0    	adox   %eax,%r8d,%r8d
 \s*[a-f0-9]+:\s*62 d4 7e 18 66 c7    	adox   %r15d,%eax,%eax
 \s*[a-f0-9]+:\s*67 f3 0f 38 f6 04 0a 	adox   \(%edx,%ecx,1\),%eax
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-ndd.d b/gas/testsuite/gas/i386/x86-64-apx-ndd.d
index 73410606ce3..36d5c738e46 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-ndd.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-ndd.d
@@ -158,3 +158,4 @@  Disassembly of section .text:
 \s*[a-f0-9]+:\s*62 c4 3c 18 32 04 07 	xor    \(%r15,%rax,1\),%r16b,%r8b
 \s*[a-f0-9]+:\s*62 c4 3d 18 33 04 07 	xor    \(%r15,%rax,1\),%r16w,%r8w
 \s*[a-f0-9]+:\s*62 fc 5c 10 83 34 83 11 	xorl   \$0x11,\(%r19,%rax,4\),%r20d
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
index 44e3e96a5df..018a0e838dc 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d
@@ -12,3 +12,4 @@  Disassembly of section \.text:
 \s*[a-f0-9]+:\s*d5 19 57[	 ]+pushp  r31
 \s*[a-f0-9]+:\s*d5 08 58[	 ]+popp   rax
 \s*[a-f0-9]+:\s*d5 19 5f[	 ]+popp   r31
+#pass
diff --git a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
index b20e5ba9a35..a81f4838529 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
+++ b/gas/testsuite/gas/i386/x86-64-apx-pushp-popp.d
@@ -12,3 +12,4 @@  Disassembly of section \.text:
 \s*[a-f0-9]+:\s*d5 19 57[ 	]+pushp  %r31
 \s*[a-f0-9]+:\s*d5 08 58[ 	]+popp   %rax
 \s*[a-f0-9]+:\s*d5 19 5f[ 	]+popp   %r31
+#pass